Repository navigation
Date the two runtime history codes to 1.11.0 - #792
luisleo526 wants to merge 2 commits into
Conversation
runtime_history_budget_exhausted and runtime_storage_observation_incomplete were catalogued with since 1.10.1, a release that was never cut. The release workflow's catalog stamp refuses an added entry whose since names another release than the one being cut, so the 1.11.0 release stopped at "Stamp the run-failure catalog diff". Set since to 1.11.0 in docker/run_failure_codes.json, regenerate docker/run_failure_codes_diff.json (8 added since v1.10.0, check passes), update the ownership manifest and the catalog test that pin the value, and count both codes with the other 1.11.0 additions in docs/pages/run-failure-codes.md. No code number, class, retryability or argument changes. Co-Authored-By: Claude Opus 5.5 <[email protected]>
![graphify-labs[bot]](https://avatars.githubusercontent.com/in/4356270?s=60&v=4){kind=small}
There was a problem hiding this comment.
Graphify reviewed this change.
No issues found by static checks — no coupling regressions or blocking issues in the code graph. That is not the same as safe to merge: see what was not checked.
Not checked: tests were not run; no formal proof of the changed code.
Graphify review — findings
Re-attributes runtime_history_budget_exhausted and runtime_storage_observation_incomplete from release 1.10.1 to 1.11.0, since they first ship in 1.11.0. The catalog JSON, its release diff (including the regenerated catalog SHA-256), the ownership manifest and the registry test's since check all move together. The docs now count 8 codes added in 1.11.0, drop the separate 1.10.1 entry, and fold the two codes into the 1.11.0 list.
No blocking issues surfaced.
Analysis details — impact, health, verification
Impact & health
Graphify review
Impact — 2086 functions depend on the 135 functions this change touches.
Health — grade B; 10 existing hotspot(s) in the area this change touches (pre-existing, not introduced here):
commit_input— 32 callers, 14 callees (high)verify_report— 18 callers, 10 callees (high)make_run_failure()— 12 callers, 10 callees (high)strategy_native_submit_v1()— 19 callers, 6 callees (high)put_ok()— 22 callers, 4 callees (high)consume_matched_request— 2 callers, 43 callees (high)begin_ready— 4 callers, 21 callees (high)run()— 1 callers, 74 callees (high)- …and 2 more
Verification — 2086 functions in the blast radius were not formally verified this run (proofs are advisory here).
Gate & verification
graphify gate
PASS — objectively clean (no health regressions, tests not run — proofs not run this pass (advisory)). Grounded, not self-assessed.
Advisory (not blocking):
- verification_scope: 2047 function(s) in the blast radius were not formally verified this run
With both runtime history codes dated 1.11.0 they join the 1.11.0 additions, which the generator numbers by name. Regenerate include/pineforge/run_failure_codes.hpp and src/run_failure_registry.inc (scripts/check_run_failure_codes.py --write-registry): the three unreleased codes 80-82 change places (pine_map_capacity_exceeded 80, runtime_history_budget_exhausted 81, runtime_storage_observation_incomplete 82); the selected-capacity codes keep 83-87 and every released number is unchanged. The numbers are on no wire: the C getters answer with names. The number pins in tests/test_run_failure_code_numbers.py follow: one 1.11.0 group instead of a 1.10.1 group that was never released. Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
Superseded by #793: the same tree (588973b1) as one commit, whose message names the docs sentence it replaces; the doc-reverts check refused this PR's first commit. Branch kept. |
Summary
The 1.11.0 release dry run stopped at "Stamp the run-failure catalog diff":
Both codes were catalogued with
since1.10.1, a release that was never cut. They first ship in 1.11.0.Changes
docker/run_failure_codes.json:since1.10.1 -> 1.11.0 for the two codes.docker/run_failure_codes_diff.json: regenerated withscripts/gen_run_failure_catalog_diff.py --write(v1.10.0 -> unreleased: 8 added, 2 changed, 0 removed);--checkpasses.tests/ownership/manifest.v1.json,tests/test_run_failure_codes.cpp: the pinnedsincevalue follows.docs/pages/run-failure-codes.md: both codes are counted with the other 1.11.0 additions (8 added in 1.11.0).No code number, class, retryability or argument changes.
Verification
gen_run_failure_catalog_diff.py --checkwith release tags required: OK, byte-identical to its regeneration.--stamp --to-version 1.11.0 --previous-tag v1.10.0, now writes the stamped diff (8 added, 2 changed) instead of refusing.🤖 Generated with Claude Code