Repository navigation
tests: align adapter offset pins with placement storage growth - #763
Conversation
Expectation corrected: pine_view_ 88208 -> 88240, retired_row_scratch_ 88216 -> 88248 and staged_scopes_ 88888 -> 88920, because 075d86f added a bool, its seven bytes of alignment padding and three uint64 counters to PlacementTable. The adapter contains that table by value before the pinned members. The enclosing size pins were already updated; keep those and every other offset unchanged. Record filesystem capacity after sanitizer verification, including a failed verification, alongside the preparation measurements.
![graphify-labs[bot]](https://avatars.githubusercontent.com/in/4356270?s=60&v=4){kind=small}
There was a problem hiding this comment.
Graphify reviewed this change.
No issues found by static checks — no coupling regressions or blocking issues in the code graph. That is not the same as safe to merge: see what was not checked.
Not checked: tests were not run; no formal proof of the changed code.
Graphify review — findings
Adds a df -h / /mnt disk-space measurement step after verification in the sanitizer jobs of both ci-post.yml and native-live.yml. The step runs under always() once authz has succeeded, so it reports free space even when verification fails and before diagnostics are staged. Updates the ABI layout probe's pinned offsets for PineExecutionAdapter::pine_view_, retired_row_scratch_ and staged_scopes_, each shifted up by 32 bytes (to 88240, 88248 and 88920). The PineStrategyHost::adapter_ pin stays at 6440.
No blocking issues surfaced. 1 lower-confidence candidate did not survive cross-model review.
Analysis details — impact, health, verification
Impact & health
Graphify review
Impact — 46 functions depend on the 46 functions this change touches.
Health — grade A; no new coupling hotspots.
Verification — 46 functions in the blast radius were not formally verified this run (proofs are advisory here).
Gate & verification
graphify gate
PASS — objectively clean (no health regressions, tests not run — proofs not run this pass (advisory)). Grounded, not self-assessed.
Advisory (not blocking):
- verification_scope: 46 function(s) in the blast radius were not formally verified this run
Summary
Corrects three stale offset pins in
tests/test_abi_layout_probe.cpp. Commit 075d86f added abool, seven bytes of alignment padding and threeuint64_tcounters toPlacementTable(32 bytes).PineExecutionAdapterholds that table by value before the pinned members, so each of them moves by exactly 32 bytes:pine_view_retired_row_scratch_staged_scopes_The two size pins were already updated for that change; the three offsets were not. The members are fixed-width, so the new values do not depend on the compiler. No other number changes.
The sanitizer jobs of
ci-postandnative-livealso printdf -h / /mntafter verification, to show the remaining disk margin.Testing
The offset pins run only on Linux x86-64 with libstdc++, so this PR's hosted x86 jobs are the proof:
native-live-shard (native, 2/4),build-shard (Debug, 2/2)andbuild-shard (Release, 2/4).🤖 Generated with Claude Code