Skip to content

ci: run the rerun-preempted controller tests in preflight - #758

Closed
luisleo526 wants to merge 1 commit into
mainfrom
ci-rerun-preempted-tests
Closed

luisleo526 wants to merge 1 commit into
mainfrom
ci-rerun-preempted-tests

Conversation

@luisleo526

Copy link
Copy Markdown
Collaborator

What

  • Register scripts/test_ci_rerun_preempted.py in ci_preflight (as rerun-preempted-tests, next to release-gate-tests). Until now the file had no runner, so CI never executed it.
  • Extend the preflight registration tests (scripts/test_ci_preflight.py) to cover the new entry and the updated command counts.
  • The before-fix witness in test_ci_rerun_preempted.py reads an older revision with git show. When that commit is absent (shallow checkouts), it now skips with a printed reason instead of failing the file.
  • Replace a docstring line in scripts/ci/rerun_preempted.py that referred to an internal ticket with a description of what the controller does.

Tests

Run on a full-history checkout of this base (d3982793):

test_ci_preflight.py test_ci_rerun_preempted.py
base fails (new registration is missing) passes
this branch passes passes

The CI run on this PR should show the new rerun-preempted-tests step executing.

Draft: to be merged after the 1.11.0 tag.

🤖 Generated with Claude Code

scripts/test_ci_rerun_preempted.py had no runner, so CI never executed it.
Register it in ci_preflight next to the release-gate tests and extend the
preflight registration checks to cover it.

The before-fix witness reads an older revision with git show; when that
commit is absent from the checkout (shallow clones), the witness now skips
with a visible reason instead of failing the whole file.

Replace a docstring line that referred to an internal ticket with a
description of what the controller does.
@luisleo526

Copy link
Copy Markdown
Collaborator Author

Superseded: this change is contained in main 929c213 (hosted runner move). Branch kept.

@luisleo526 luisleo526 closed this Nov 6, 2026
@luisleo526 luisleo526 reopened this Nov 6, 2026
@luisleo526

Copy link
Copy Markdown
Collaborator Author

Reopened: closing this was a mistake. Main does not yet run these controller tests in preflight. This branch will be updated onto current main.

luisleo526 added a commit that referenced this pull request Nov 8, 2026
…n, trade text and RCI changes (#788)

## Summary

This branch combines seven source heads into one change on top of main (`755e6658`), so that the build, the parity sweep and the review each run once. Every source head was merged with an ordinary merge commit: nothing was rebased, nothing was squashed inside the branch, no conflict occurred in these merges and nothing was resolved by hand. Every source head contains main (`755e6658`) except the trade text channel's, which contains the main before one documentation-only commit (`63f3978a`); the combined branch contains main. When this change merges, pull requests 781, 758, 780 and 783 are closed with a link to it.

A moving average change (head `4c5c65f4`, "Compute SMA from a correctly rounded window sum") was merged into this branch between the trade text channel and #783 and is taken out again by the last commit of the branch, a plain revert of that merge (`git revert -m 1`, no conflict). The parity measurement of the branch with it showed 40 probes whose graded tier falls against their committed TradingView tapes, every one of them calling `ta.sma`; a measurement of main plus only that change gave the same 40 results, and no other probe changed. The change is not part of this merge; whether it returns, and in what form, is decided separately. The tree of this branch equals the tree of the seven heads below merged on main without it.

PR type: code (engine sources, tests, CI scripts and documentation).

Fixes #779

## Sources

| Source | Title | Source head |
|---|---|---|
| #781 | ci: validate split releases and retained smoke output | `130bda2db570bd63bdec57b6b5fdd3cabacab7fc` |
| branch | Validate corpus records and gitlink results in the pull-request checks | `46bb21fb169091722d49d3b2f2e4f1f589148166` |
| #758 | test(ci): register rerun-preempted controller tests | `348a89766e0ff23f88b4837bce80957f7635ef8e` |
| branch | Add an opt-in trade text companion channel | `5930d7f8d12010d67c77a098804eb6cd295095db` |
| #783 | Add generated CLI coverage for map pair limits | `163abf58f1a73c7ec9160120774954fb29f4bd2d` |
| branch | Avoid copying RCI price history during ranking | `022750f8451aadd93066ffad3b54695e23956116` |
| #780 | Make nested consumer state construction portable to Clang | `000e2dac0e8e5e73fe53551adec7fbdf3f251af6` |

The head listed for the corpus validation change already contains the heads listed for #781 and #758, so merging it brings both along and the separate merge of the #758 head changes nothing (it is listed because its pull request closes with this change). The merges that this branch makes of the source heads resolve no conflict by hand. The source histories themselves carry six merges that were resolved by hand in their own branches, before the heads were handed over: three in the history of the corpus validation head and three in the history of the trade text channel head. Corpus validation: `d482eb37` (`scripts/test_ci_preflight.py`: the stage-inventory counts between the registration of the rerun-controller tests and the corpus validation job), `f7519bb8` (`scripts/ci_preflight.py` and `scripts/test_ci_preflight.py`) and `cecedc0e` (`CHANGELOG.md`, `ci/cr150-source-bounds.yaml`, `scripts/test_cr150_source_gate.py` and `tests/private_fixture_reads.evidence`). Trade text channel: `09c9fb52` (`CHANGELOG.md` and `runner/main.cpp`), `8c17d14e` and `5930d7f8` (both in `ci/cr150-source-bounds.yaml` and `scripts/test_cr150_source_gate.py`). The head listed for #758 is that pull request's branch merged once with main; the head published on #758 is older. The head listed for #780 is the head of its branch (the construction fixes and the refreshed source citations in three documentation pages).

## How it was built

The merges were made in the order of the table, with the moving average change between the trade text channel and #783 (see above), except that the separate merge of the #758 head was skipped because the corpus validation head contains it. Relative to main, 52 files change. Besides the files that #781 and #758 share with the corpus validation head, three files are touched by more than one source and were merged automatically without a conflict: `docs/ci.md` (the corpus validation change and #783), `docs/design/native-feature-parity.md` (the trade text channel and #780) and `scripts/test_ci_preflight.py` (#781, #758, the corpus validation change and #783). For every source, the changed lines of the files that only it touches equal the changed lines of this branch, and for every shared file the union of the sources' changed lines equals the branch's; an independent chain of the same merges in the reverse order gives the same tree.

docs/ci.md: the slow-label bound paragraph and the slow-label inventory
paragraph, introduced by 69cddc9 (#679), now state the size of the pinned set
(90 names, including test_cr559_map_capacity_cli) instead of the retired
43 + 28 = 71 breakdown.

docs/ci.md: the three sentences of 42527b6 (#704) that said gke-pr.yml admits exactly two variants, that OLD is the shape without the arm job kept so earlier workflow files still pass, that NEW requires the exact arm classifier output, and that hybrids and extra jobs, outputs, needs or arm steps are refused while OLD retains its original exact rules and templates for a workflow without the arm job, are rewritten to cover the arm and the corpus variants.

## What was done before merge

Hosted CI was green on this head. One parity sweep against the active baseline measured this exact tree: 7,989 probes compared, no probe changed tier, no leaver, no regression, and the gate returned its neutral pass. One review of the combined diff, which cites each source, and of the revert commit gave a GO on this head and tree. The results already recorded on the individual pull requests and branches are not repeated here and do not stand in for these. The moving average change is not in this merge: it was merged into this branch and taken out again by the last commit, a plain revert.

The full post-merge workflow was also run on this head (run 42452226570). It failed exactly the twelve jobs that fail on main `755e6658` (run 42435140307): the eight sanitizer shards and the live-sanitizer job, each stopping at the final link with "No space left on device", and their aggregate jobs. Every other job passed, and no job failed that passes on main.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@luisleo526

Copy link
Copy Markdown
Collaborator Author

This change is merged as part of #788 (squash commit 0c8e1a8), which combined it with the other sources listed there. Closing in favour of that merge.

@luisleo526 luisleo526 closed this Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant