Repository navigation
ci: remove timeout-minutes (owner #827, no time limits) - #460
Closed
luisleo526 wants to merge 2 commits into
Closed
luisleo526 wants to merge 2 commits into
luisleo526 wants to merge 2 commits into
Conversation
…ve.yml (owner #827) Deletion-only sweep: 10 timeout-minutes lines removed. grep -rn timeout-minutes .github/ prints nothing; git diff --numstat shows 0 added. Co-Authored-By: Claude Code <[email protected]>
#827) The deletion commit 85d03d6 removed every timeout-minutes declaration, but the repository's own contract still required the deleted 360-minute deadlines: ci_preflight.py's JOB_RUNNERS carried a minutes member and runner_findings asserted it, and test_ci_preflight.py's table asserted that a changed 360 still fails and that removing it fails too. The preflight therefore refused the sweep head (rj-20261020t104302-5cba28: ci-workflow-contract and preflight-tests, 10 findings "must allow 360 minutes"). Now no job or step may declare timeout-minutes. JOB_RUNNERS holds (runner, command); runner_findings reports one finding per affected job when the job declares it at job level, at any step level, as a step's first key, or as a quoted key. Runner labels, PF_CI_LABELS, core-count sizing and every other contract are unchanged, and no workflow file is touched. The must-fail table keeps a changed value failing (360 -> 30/45/60/10) with the new message; the removal row now passes with an empty finding list; anchors that used the deleted line moved to `steps:`; the minutes == 360 assertion is replaced by an assertion that the source workflows carry no timeout-minutes, plus new coverage for job-level, step-level, first-key and quoted-key declarations. docs/ci.md says the repository declares no job or step time limit and GitHub's 6 h platform maximum is the only bound; measured durations stay as historical context. Co-Authored-By: Claude Code <[email protected]>
Collaborator
Author
|
Superseded by #462: same tree (a56cef36), with the second commit's message naming the four doc deletions the doc-reverts check requires. Replaced on a new branch instead of force-pushing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner rule #827 (no time limits in CI): delete every
timeout-minutes:line in this repo's workflows. GitHub's own 6 h job maximum stays the only hang catcher.grep -rnE '^[[:space:]]*timeout-minutes:' .github/prints nothing on this head.🤖 Generated with Claude Code