Skip to content

corpus: move the gitlink to 9245f28 (probe directories removed, headers state settings only) - #376

Merged
luisleo526 merged 1 commit into
mainfrom
ns27-engine
Oct 12, 2026
Merged

luisleo526 merged 1 commit into
mainfrom
ns27-engine

Conversation

@luisleo526

Copy link
Copy Markdown
Collaborator

Moves the corpus gitlink from b40aa8ec to 9245f28afe11378ed234e8303a911f2b2843e0ee and the # corpus line of scripts/corpus_parity_baseline.txt with it. The 312 baseline digests are unchanged. No pin, no engine code.

What the corpus change is (4 commits on b40aa8ec, branch engine-line)

  • Removes the 13 probe directories (60 files) that need non-public inputs: draft-probes/, special-validation/, validation/symbol-specified/. The default validation sweep never included them; the engine only skips them by name (scripts/verify_corpus.py, scripts/regen_validation_report.py, scripts/validation_report_self_test.py), so no engine file changes here. Later follow-up: the remaining references that still name these paths are reworded in a separate pull request that lands after this one.
  • Cleans the headers of 178 of the 312 validation strategy.pine files so that they state chart settings only, and corrects one probe's UDT history note (TradingView refuses a history reference on a UDT field with compile error CE10290; no claim about PineForge). Comment text only.
  • Call-site ids in generated.cpp derive from source line positions, so a line-count change in a corpus strategy.pine can move the generated ids; deleted comment lines are therefore kept as bare // lines (124 lines in 117 files). The tree with the lines simply deleted drifted in 80 of the 312 generated.cpp in a measured round; with the bare lines it does not.

Evidence (AWS spot boxes, this engine at 2dbd72f, nothing measured on a developer machine)

  • VERIFY=1 scripts/regen_corpus_cpp.sh at the pinned codegen (a4259656) over the new corpus tree: 312 strategies, 0 drifted, 0 failed to transpile; the regeneration at the next pin and a second verify give the same bytes as an independent earlier round for 312 of 312 files.
  • The engine's own scripts/check_corpus_parity.sh (full sweep, 312 probes) on this branch: corpus_trades_identity: 312 probes at corpus 9245f28afe11378ed234e8303a911f2b2843e0ee — baseline match=312, moved=0, unrecorded=0, missing=0, schema violations=0; verifier headline Verified 312 strategies — excellent=311, strong=0, moderate=0, weak=0, minimal=0, anomaly=1, engine_only=0, missing=0; "TradingView parity holds".
  • Program text of all 312 strategy.pine is identical to the parent once // comments are removed (checked per file), no non-comment line moved, every added line is exactly //, and the 60 removed files are exactly the files listed in the maintainers' removal manifest, with equal sha256.

Landing order

  1. This pull request first, together with the registry migration 0073_corpus_bundle_9245f28_probes_removed_headers.sql of the workflow repository (it must land TOGETHER with this gitlink bump; the case runner refuses a lane whose registered corpus commit differs from the Engine tree's gitlink). Apply the migration immediately before this pull request's engine gate run, never in a batch deploy and never early.
  2. The codegen pin pull request (NS-31) after this one; it is rebased onto this one.

The corpus branch is pushed once with all of its commits and fast-forwarded (never rebased or squashed); this pull request points at the fourth commit.

🤖 Generated with Claude Code

…ers state settings only)

Move the corpus gitlink from b40aa8ec to 9245f28afe11378ed234e8303a911f2b2843e0ee
and record the new commit on the `# corpus` line of scripts/corpus_parity_baseline.txt.
The 312 baseline digests do not change.

The corpus change (4 commits):
- removes the 13 probe directories (60 files) that need non-public inputs:
  draft-probes/, special-validation/ and validation/symbol-specified/. The
  default validation sweep never included them, and the engine only skips them
  by name (scripts/verify_corpus.py, regen_validation_report.py,
  validation_report_self_test.py), so no engine file changes;
- cleans the headers of 178 of the 312 validation strategy.pine files so that
  they state chart settings only, and corrects one probe's UDT history note
  (TradingView refuses a history reference on a UDT field with CE10290; no
  claim about PineForge).

Call-site ids in generated.cpp derive from source line positions, so a
line-count change in a corpus strategy.pine can move the generated ids; deleted
comment lines are therefore kept as bare // lines.

Measured on one AWS spot box with this engine (2dbd72f) over the new corpus
tree: the engine's own VERIFY=1 scripts/regen_corpus_cpp.sh at the pinned
codegen (a4259656) reports 312 strategies, 0 drifted, 0 failed to transpile,
so no committed generated.cpp changes. An earlier tree whose comment lines had
simply been deleted drifted in 80 of the 312 files, all among the 117 files that
had lost lines; that run is the reason for the bare // lines.

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
@luisleo526
luisleo526 marked this pull request as ready for review October 12, 2026 22:55
@luisleo526
luisleo526 merged commit 9da4c98 into main Oct 12, 2026
22 checks passed
luisleo526 added a commit that referenced this pull request Oct 14, 2026
* docs: the 1.6.0-rc.1 changelog entry

The changelog section for the first candidate of 1.6.0, tag v1.6.0-rc.1 on
commit 04607c1: the selected-window contract
revision 1.3 and the typed failures behind it (#388), finite trade and summary
doubles in every report writer (#384, #388), the favicon of the API
documentation (#355), the removed CI time limits and command-line options (#378),
and the tests, CI and benchmarks changes since 1.5.0 (#375, #376, #377, #382,
#383, #385, #386, #387).

The entry is inserted above the 1.5.0 section; no existing line changes. The
date is the UTC date of the tag.

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* README: link the apex pineforge.dev, not the www host

The README header link pointed at https://www.pineforge.dev. The product site
lives at the apex, https://pineforge.dev; the www host is being redirected to
it, and search indexes both forms today. One link changed, nothing else.

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* CHANGELOG: add the selected-window mode and typed failures to the 1.5.0 notes

Two things that are in the v1.5.0 tag were missing from its notes: the opt-in
selected-window mode with retained pre-roll bars (#363, already in
v1.5.0-rc.1) and the typed failures that docker/run_json.py raises for
exceptions from the selected-window helper modules (_typed_failure).

The new subsection "Additions to the 1.5.0 notes" only states what the code
and the #363 text say, with the same "development-only parity candidate"
limits (contract revision 1.3-parity, no claim of complete value-ownership
coverage, cannot be promoted to stable). It adds lines and changes none.

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

---------

Co-authored-by: Claude Sonnet 5.5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant