Repository navigation
tests: the ten test files that embed US-equity price data move to the private fixtures - #375
Merged
Merged
Conversation
… rows (Form B) Ten files leave the public tree for pineforge-private-fixtures (byte-exact copies, commit 5abcf8a6): tests/test_ta_series_length_data.hpp, test_ta_series_length_extremes.cpp, test_ta_series_length_supertrend.cpp, test_ta_simple_length.cpp, test_ta_window_underapplied_data.hpp, test_ta_window_underapplied.cpp, test_ta_window_round10_data.hpp, test_ta_window_round10.cpp, test_tv_fill_rounding.cpp, test_tv_fill_rounding_l4d.cpp. Their data headers and tables hold NYSE:F 15m bars, NASDAQ:AAPL closes and TradingView indicator values on NYSE:F@15. Six rows become private rows registered the #371 way (the real test when the overlay supplies the source, a SKIP placeholder with the pinned literal otherwise): test_ta_series_length_extremes, test_ta_series_length_supertrend, test_ta_simple_length, test_ta_window_underapplied, test_ta_window_round10, test_tv_fill_rounding_l4d. test_tv_fill_rounding (not the _l4d twin) was already retired through L3A_LEGACY_OWNER_TEST_SOURCES and registers no row; its source leaves and its name stays in that retirement list (REMOVE_ITEM of an absent name is harmless). The four source-bound rows are recorded in _pf_source_bound_private_rows so the kernel profile, which has no source layer, stays correct without the files. Pins: tests/private_fixture_rows.txt 368 -> 374 rows (and PRIVATE_FIXTURE_ROW_COUNT), tests/private_fixture_paths.txt +10 F lines (10,206 files, 12,910 paths, 2,704 directories). Floors: release private count 300 -> 306 (absent floor 610 -> 604), kernel private count 28 -> 30 (only the underapplied and round10 rows are source-free; absent floor 309 -> 307); full totals 910 and 337 are unchanged. Doc sentence reworded, named here for the doc-revert gate: "The full-run release and kernel floors are the table's own numbers above (610 and 309 rows absent, 910 and 337 with the overlay present); full runs do not exclude a label." now says 604 and 307 for the absent floors; the two cells of the floor table in docs/ci.md change the same way (610 -> 604, 309 -> 307). None of our release-built assets contains these files: the prebuilt tarballs are cmake --install with PINEFORGE_BUILD_TESTS=OFF plus LICENSE/NOTICE/VERSION (release.yml, the build at line 399 and the pack step at 433); only GitHub's automatic source archive carries tests/. Git history is not rewritten (owner ruling 10-11). First added: test_tv_fill_rounding.cpp 7fc7347 (2026-08-25, #163), test_tv_fill_rounding_l4d.cpp 73817c1 (2026-09-19, #254), test_ta_window_underapplied* ade627e and test_ta_window_round10* c8993aa (2026-09-06), test_ta_series_length_*, test_ta_simple_length.cpp 1e360bd (2026-09-27). Two existing gates carried the old numbers and move with the floors (found by the Claude read of the first cut): scripts/test_ci_verify.py (the literal pins (910,306)/(337,30) and absent floors 604/307, the kernel absent scenarios now with 30 pinned rows, the explicit --min-tests 307 case, the one-row-ran case 337 - 29 = 308, the websocket allowance case 337 - 30 - 1 = 306; the shrunken release registry 901/298 -> 603 still fails the 604 floor; dated measurements stay as history) and tests/private_fixture_reads.evidence (the CMake line it cites moved by -2: 3253 -> 3251, prose cites :3273 -> :3271, :3237 -> :3235, :3249 -> :3247, :3279-3280 -> :3277-3278). A comment in tests/CMakeLists.txt that cites the two gate suites follows (:2217/:2219 -> :2215/:2217). Not run locally (no suites on the Mac); the two-world proof runs on lab remote. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
luisleo526
marked this pull request as ready for review
October 12, 2026 14:38
luisleo526
added a commit
that referenced
this pull request
Oct 13, 2026
…OPE-1300, part 2) (#386) tests: fourteen engine test files and a data header of futures and forex captures move to the private fixtures; one row joins the private rows (US-SCOPE-1300, part 2) Owner ruling 2026-10-13: recorded market data of US futures, forex and spot metals is never public. Fifteen files leave the public tree for the private fixtures repository (byte-exact copies, commit cb5e0c2638b8 on top of da6ad27; sha256 of every copy read back): tests/test_famag_close_survives.cpp and _l4d, test_htf_weekly_lookahead.cpp, test_trail_close_restart_no_fold.cpp and _l4c, test_tv_money_precision.cpp and _l4b, test_tv_money_carried_pooc.cpp and _l4b, test_tv_money_band.cpp and _l4b, test_market_admission_commission.cpp and _l4b, test_ta_sma_stochrsi_ties.cpp and test_ta_sma_stochrsi_ties_data.hpp. Their tests pin floating-point residues of recorded captures (ulp directions of tick products, ten-digit money boundaries, crossover ties), so they are moved, not rewritten: an invented series would need its own independently justified oracle. Registration (the #375 way): seven of the rows were already private rows gated on a private data header (famag_close_survives_l4d, htf_weekly_lookahead, trail_close_restart_no_fold_l4c, tv_money_precision_l4b, tv_money_carried_pooc_l4b, tv_money_band_l4b, market_admission_commission_l4b): their gate and their recorded source-bound entries stay as they are, the overlay restores the .cpp beside the header. The six base files have no row (retired through L3A_LEGACY_OWNER_TEST_SOURCES): their sources leave and the names stay in that list. test_ta_sma_stochrsi_ties was a public, source-free row: it leaves TEST_SOURCES and registers like test_ta_window_round10 (the real test when the overlay supplies tests/test_ta_sma_stochrsi_ties.cpp, the pinned SKIP placeholder otherwise). Pins: tests/private_fixture_rows.txt 374 -> 375 rows (and PRIVATE_FIXTURE_ROW_COUNT), tests/private_fixture_paths.txt +15 F lines (10,221 files, 12,925 paths). Floors: release private count 306 -> 307 (absent floor 604 -> 603), kernel private count 30 -> 31 (the row is source-free; absent floor 307 -> 306); the full totals 910 and 337 are unchanged. Doc sentence reworded, named here for the doc-revert gate: "The full-run release and kernel floors are the table's own numbers above (604 and 307 rows absent, 910 and 337 with the overlay present); full runs do not exclude a label." now says 603 and 306 for the absent floors; the two cells of the floor table in docs/ci.md change the same way (604 -> 603, 307 -> 306). Gates that carried the old numbers move with the floors: scripts/test_ci_verify.py (the literal pins (910,307)/(337,31) and absent floors 603/306, the kernel absent scenarios with 31 pinned rows, the explicit --min-tests 306 case, the shrunken release registry 900/298 -> 602 which still fails the 603 floor, the comments of the one-row-ran and websocket cases) and tests/private_fixture_reads.evidence (the CMake lines it cites moved by -1: 3251 -> 3250, :3271 -> :3270, :3235 -> :3234, :3247 -> :3246, :3277-3278 -> :3276-3277); a comment in tests/CMakeLists.txt that cites the two gate suites follows (:2215/:2217 -> :2214/:2216). None of our release-built assets contains these files (the prebuilt tarballs are cmake --install with PINEFORGE_BUILD_TESTS=OFF); only GitHub's automatic source archive carries tests/. Git history is not rewritten (owner ruling 10-11). Not run locally (no suites on the Mac); the two-world proof runs on lab remote. docs: two pages stop citing the two admission tests that moved to the private fixtures (US-SCOPE-1300, part 2) The first release-and-preflight run of part 2 (lab job p382p2-absent: release and kernel passed) failed the doc-lint dead-path rule at four citations of tests/test_tv_money_precision_l4b.cpp and tests/test_tv_money_band_l4b.cpp, which part 2 moved out of the public tree. The two pages now say what those tests are instead of naming a path that no longer exists. Sentences reworded, named here for the doc-revert gate: * docs/pages/native-engine.md: "(the famr / famr3 tapes of `tests/test_tv_money_precision_l4b.cpp` and `tests/test_tv_money_band_l4b.cpp`)" now reads "(the famr / famr3 tapes of two tests that live in the private fixtures)". * docs/design/native-feature-parity.md, row SZ10a: "pinned by 445 famr3 tapes (`tests/test_tv_money_band_l4b.cpp`) and 202 famr tapes (`tests/test_tv_money_precision_l4b.cpp`)" now reads "pinned by 445 famr3 tapes and 202 famr tapes (two tests that live in the private fixtures)". The tape counts and every other word of both sentences are unchanged. scripts/check_doc_lint.py reports 0 offenders on this tree. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
luisleo526
added a commit
that referenced
this pull request
Oct 14, 2026
* docs: the 1.6.0-rc.1 changelog entry The changelog section for the first candidate of 1.6.0, tag v1.6.0-rc.1 on commit 04607c1: the selected-window contract revision 1.3 and the typed failures behind it (#388), finite trade and summary doubles in every report writer (#384, #388), the favicon of the API documentation (#355), the removed CI time limits and command-line options (#378), and the tests, CI and benchmarks changes since 1.5.0 (#375, #376, #377, #382, #383, #385, #386, #387). The entry is inserted above the 1.5.0 section; no existing line changes. The date is the UTC date of the tag. Co-Authored-By: Claude Sonnet 5.5 <[email protected]> * README: link the apex pineforge.dev, not the www host The README header link pointed at https://www.pineforge.dev. The product site lives at the apex, https://pineforge.dev; the www host is being redirected to it, and search indexes both forms today. One link changed, nothing else. Co-Authored-By: Claude Sonnet 5.5 <[email protected]> * CHANGELOG: add the selected-window mode and typed failures to the 1.5.0 notes Two things that are in the v1.5.0 tag were missing from its notes: the opt-in selected-window mode with retained pre-roll bars (#363, already in v1.5.0-rc.1) and the typed failures that docker/run_json.py raises for exceptions from the selected-window helper modules (_typed_failure). The new subsection "Additions to the 1.5.0 notes" only states what the code and the #363 text say, with the same "development-only parity candidate" limits (contract revision 1.3-parity, no claim of complete value-ownership coverage, cannot be promoted to stable). It adds lines and changes none. Co-Authored-By: Claude Sonnet 5.5 <[email protected]> --------- Co-authored-by: Claude Sonnet 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ten test files that embed US-equity price data leave the public tree. Six registered rows now need the private fixtures overlay, following the pattern #371 set (Form B): without the overlay, each row registers a SKIP placeholder.
What moves (into pineforge-private-fixtures at 5abcf8a6): tests/test_ta_series_length_data.hpp, test_ta_series_length_extremes.cpp, test_ta_series_length_supertrend.cpp, test_ta_simple_length.cpp, test_ta_window_underapplied_data.hpp, test_ta_window_underapplied.cpp, test_ta_window_round10_data.hpp, test_ta_window_round10.cpp, test_tv_fill_rounding.cpp and test_tv_fill_rounding_l4d.cpp.
Rows: test_ta_series_length_extremes, test_ta_series_length_supertrend, test_ta_simple_length, test_ta_window_underapplied, test_ta_window_round10 and test_tv_fill_rounding_l4d. The test_tv_fill_rounding row was already retired, so only its file leaves.
Counts:
Release assets: none of the release-built assets contained these files. The prebuilt tarballs are a
cmake --installbuilt withPINEFORGE_BUILD_TESTS=OFF(release.yml:399), plus LICENSE, NOTICE and VERSION, packed at release.yml:433-434. The other uploaded assets are the run-failure catalog JSON files. Only GitHub's automatic source archive carries tests/.First added, for the record (git history is not rewritten, per the owner's ruling of 10-11):
Notes:
Proof:
lab remote: without the overlay, all 8 steps; with the overlay at pin 5abcf8a6, preflight, release and kernel, including check_two_world_registration.🤖 Generated with Claude Code