Skip to content

Native terms follow-up: no-plan terminal for unresolved HostSized groups and the remaining provenance witnesses - #252

Merged
luisleo526 merged 1 commit into
mainfrom
fix/native-terms-r4-20260914
Sep 14, 2026
Merged

luisleo526 merged 1 commit into
mainfrom
fix/native-terms-r4-20260914

Conversation

@luisleo526

Copy link
Copy Markdown
Collaborator

Follow-up to #251 (R4-B native execution terms), addressing the final Fable review's remaining P1 and P2 items on the merged tree (cherry-pick of ff56aa9 onto e7cdf05).

What changes

  • Runtime (10 lines, src/native_execution_consumer.cpp): a current finite-nonpositive group exhaustion with an unresolved HostSized binding and no executable plan now bypasses provisional inspection, installs its terms receipt and returns Cancelled{Group}; queued finite-nonpositive input still returns NonpositivePrice with the attempted terms. Native route only; the generated (legacy) route does not reach this code.
  • Tests: Stop / Trail / StopLimit sibling, activation and provenance witnesses; replacement, StopLimit and BeginTrail non-transfer, gap (incl. exact-level gap) and replay controls as literal rows; partial/oversized CloseOpposite, bound HostSized rematch units, HostSized NaN preview/execute, injected post-binding NoChange, explicit-Transact preview units, SelectedExposure, percent-fee/marked-equity short accounting.
  • Docs: the v15 controls sentence in docs/pages/abi-stability.md; W2 coverage table corrected (A-O1 remaining, deferred to slice C; A-F4 forward subrow removed by A9).

Invariants

  • The six measured files (engine_strategy_commands.cpp, engine_fills.cpp, engine_orders.cpp, engine_risk.cpp, engine_run.cpp, engine_market_admission.cpp) are byte-identical to main.
  • No epoch change (native_order v4, engine_script_run v15, native-consumer v6, broker/stream 15, driver v4, PF_ABI_VERSION 4). R-EPOCH scans zero hits.

Evidence (attached as it lands)

  • Local ci_verify release on the exact head.
  • One full Cloud sweep (4190 probes) on this exact tree vs the R4-B reference, snapshot, actual pr-gate (the expected target.not-positive FAIL retained; baseline promotion deferred).

🤖 Generated with Claude Code

https://claude.ai/code/session_016iF71UAEuQ7F6eqWgecAHm

…rminal

(cherry picked from commit ff56aa9d016af4bed8115c36d486724836f8c1ae)
@luisleo526

Copy link
Copy Markdown
Collaborator Author

Local verification on the exact head 87ba397 (python3 scripts/ci_verify.py release --build-dir build-r4-release --jobs 6): 341/341 tests passed, smoke consumer 0.14.0 OK. The six measured files are byte-identical to main.

Cloud sweep exp-native-r4-b-r4-87ba397-20260914 (execution pineforge-experiment-run-9js4g, 72 cases / 4190 probes, codegen 7410c87) submitted at 01:27Z; readback, snapshot and the actual pr-gate follow in one chain. Evidence lands here when it completes; the PR stays draft until then.

@luisleo526

Copy link
Copy Markdown
Collaborator Author

Cloud sweep evidence for the exact head 87ba397 (tree 2c774ad2), codegen 7410c87:

  • Experiment exp-native-r4-b-r4-87ba397-20260914 (execution pineforge-experiment-run-9js4g): 72/72 cases, 4190/4190 probes, configuration-identical vs exp-ci-preflight-0679210-20260913; 0 trade, 0 grade, 0 substantive-verifier, 0 metadata, 0 coverage differences (accepted_non_regression).
  • Candidate snapshot ffe89d9bf869… graded 4190 with 0 grade differences vs the active baseline.
  • Actual pr-gate pineforge-pr-gate-l52s7: FAIL target.not-positive as expected for a neutral change; retained honestly, baseline pointer stable, no promotion.

Evidence root: measurement/R4-B-R4-87BA397/ (readback/SUMMARY.json, GATE-EVIDENCE.json). Marking ready.

@luisleo526
luisleo526 marked this pull request as ready for review September 14, 2026 01:45
@luisleo526
luisleo526 merged commit 66d9dc4 into main Sep 14, 2026
10 checks passed
@luisleo526
luisleo526 deleted the fix/native-terms-r4-20260914 branch October 5, 2026 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant