Repository navigation
Fix POOC admission and opening margin timing - #220
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ordinary process-on-close long MARKET orders could make the wrong admission decision at a money-rounding boundary, which changed later equity and prevented the expected opening margin event. Admission now uses the recorded signal cost and a tick-built slipped comparison price while preserving quantity sizing. For the covered single-lot position, the money event occurs at the next open before order-fill recalculation, with raw-opening valuation, one slippage charge per fill, and the existing waypoint order.
The rules use financial settings and physical order/position provenance. The new provenance bit is included in the ABI v4 broker-state hash. Existing competitor, fee, FX, risk, streaming, priced/RAW, short and larger-pyramiding paths remain outside this bounded change.
Validation:
Formal Cloud gate
pineforge-pr-gate-pvh86: PASS, target score +1, 704 hard probes evaluated, 0 regressions and 0 tolerated exceptions. The PASS receipt is recorded and corroborated in Postgres for this exact head.