Repository navigation
fix: reset filled-order limits on the broker session day - #213
Merged
Merged
Conversation
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A filled-order limit could remain latched past the symbol's session reset, rejecting valid evening orders even when the correct exchange timezone and session were supplied.
Use one broker-day key across order placement, filled orders, and direct market closes. The key follows the unmerged symbol session clock, so a futures holiday daily bar can stay combined while the broker renews its order budget. Continuous-session fallback, other risk-day rules, and the indicator/security calendar remain unchanged. The shared helper is internal C++; the C ABI is unchanged. Update the README with the measured round 29 scoreboard.
Validation on final
a752fef5b529ce3ff942717e8c6cda322fd9ccba:time("D")stays unchanged. 222/222 tests pass, including 253 focused assertions; C ABI and build freshness pass.pineforge-pr-gate-jqrjn: PASS, target score +1, all 704 hard probes unchanged, zero tolerated exceptions. Snapshot:a75857788f0ed079e946893e5882fde4fe9dd58346a04ffd08562a0c5a4958ed.Codegen remains
3fd97fe28abd7b191cb376d9f5db4e056fcfae4b. Grading metrics, verifier, harness, population, tapes, symbol inputs, and FX policy are unchanged. Runtime eligibility has no strategy, symbol, date, or benchmark-ID conditions.