Repository navigation
Support nullable matrix IDs - #127
Merged
Merged
Conversation
luisleo526
added a commit
that referenced
this pull request
Sep 17, 2026
…sidual lot (R4-D L10y) yukozb-gold-ny-orb-v19-close-20-00 #2/#3 and ahtisham-ee-decoded- volatility-expansion-ahtisham #126/#127: with default_qty_value=100 the legacy owner admits the entry and books it as a main lot plus a residual margin-call lot closed again on the entry bar; the switched route refused the whole entry. The adapter now sizes and admits the full-equity entry the way the owner's fill-time affordability and margin-call slice do, and samples the residual lot's open extremes like the owner. Both population reproductions replay identically to the owner. Pinned with embedded bars in tests/test_l10y_full_equity_entry_split.cpp (W21c, qwen3.8-max). Co-Authored-By: Claude Fable 5.1 <[email protected]> Claude-Session: https://claude.ai/code/session_01RKCCnMS51GLmRbA3AHtBDb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Pine permits
nafor matrix IDs. PineForge previously represented a default matrix as an empty matrix, so it could neither implementna(matrix_id)nor distinguish null-ID lifecycle errors from valid empty-matrix behavior. That runtime gap combined with a separate codegen target-typing gap.Impact
Generated strategies can now carry a real nullable matrix ID once the matching codegen follow-up lands. This is an internal C++ layout change, so consumers must cleanly rebuild and must not mix old objects with the new library.
This PR deliberately does not change matrix assignment alias semantics, nullable arrays, matrix-returning UDF inference, or UDT identity behavior.
Validation
89e43bf85aab0842ef731419e354a0fee6244d4b1c98d4d10b3999276c5b7254