Skip to content

Commit ff67778

Browse files
luisleo526claude
andauthored
Correct two changelog entries and say "work item" in the P8 row
The unreleased changelog said that a timezone name the engine does not accept now raises pine_timezone_error instead of silently reading UTC. That holds for the engine's own calendar functions. Of the code that the transpiler generates, only timestamp() still reads a zone that the host cannot load as UTC, without an error (with a zone argument, and without one on a symbol whose zone is not UTC); the entry now says so, and that this is fixed in a later release. The entry on invalid --syminfo values said they now produce typed refusals but named neither refusal. It now says that an invalid mintick is refused as symbol_feeds_refused with reason syminfo_mintick_invalid, and that an invalid point value uses the existing symbol metadata error, symbol_metadata_rejected with field point_value, as docker/run_json.py raises them. The P8 row of the native feature parity table said its open questions are verified "inside the lane that touches each", using "lane" for a unit of work; the rest of the page keeps "lane" for its design sense, so this row now says "work item". Documentation sentences this change removes or rewrites: - CHANGELOG.md, Unreleased: "A timezone name written in a script that the engine does not accept now raises `pine_timezone_error` with the function and zone instead of silently reading UTC." now reads "A timezone name written in a script that the engine's own calendar functions do not accept now raises `pine_timezone_error` with the function and zone instead of silently reading UTC.", followed by the new sentence on the generated `timestamp()` code. - CHANGELOG.md, Unreleased: "Invalid point values use the existing symbol metadata error." now reads "An invalid `mintick` is refused as `symbol_feeds_refused` with reason `syminfo_mintick_invalid`; an invalid point value uses the existing symbol metadata error, `symbol_metadata_rejected` with field `point_value`." - docs/design/native-feature-parity.md, row P8, last column: "verify inside the lane that touches each" now reads "verify inside the work item that touches each". Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 874585b commit ff67778

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

‎CHANGELOG.md‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ version number follows semantic versioning over the surfaces the
1515
- A memory failure during a session-calendar lookup now fails the run with a typed error instead of reading the bar as out of session.
1616
- A failed `setenv` or a memory failure during a timezone switch now fails the run instead of continuing in the previous zone or in UTC.
1717
- A timezone database lookup that fails because no file descriptors or memory are available, an input/output error occurs, or the database is missing now fails the run with an engine error instead of reporting an incorrect timezone name.
18-
- A timezone name written in a script that the engine does not accept now raises `pine_timezone_error` with the function and zone instead of silently reading UTC. This addition to the public failure catalog requires a minor release. The message is TradingView's text with the engine's bar prefix, `Error on bar N: `, or `Error before the first bar: ` when no bar is being executed, and the arguments carry `bar_index`.
18+
- A timezone name written in a script that the engine's own calendar functions do not accept now raises `pine_timezone_error` with the function and zone instead of silently reading UTC. Code that the transpiler generates for `timestamp()` still reads a zone that the host cannot load as UTC, without an error (with a zone argument, and without one on a symbol whose zone is not UTC); that is fixed in a later release. This addition to the public failure catalog requires a minor release. The message is TradingView's text with the engine's bar prefix, `Error on bar N: `, or `Error before the first bar: ` when no bar is being executed, and the arguments carry `bar_index`.
1919
- The void C setters for instrument and run settings now record exceptions on
2020
the handle, including allocation failures and changes refused by the engine.
2121
`strategy_last_run_status` reads 1; `strategy_get_last_error` and
@@ -29,8 +29,8 @@ version number follows semantic versioning over the surfaces the
2929
read through `strategy_state_query_status_v1`.
3030
- Non-positive or NaN `mintick` or `pointvalue` values in `--syminfo`, and
3131
`path_order` modes outside 0, 1 and 2, now produce typed refusals instead of
32-
being ignored or reset to AUTO. Invalid point values use the existing symbol
33-
metadata error.
32+
being ignored or reset to AUTO. An invalid `mintick` is refused as `symbol_feeds_refused` with reason
33+
`syminfo_mintick_invalid`; an invalid point value uses the existing symbol metadata error, `symbol_metadata_rejected` with field `point_value`.
3434
- A percent-of-equity default quantity above 100 percent is now capped at 100 percent of equity when `margin_long` and `margin_short` are both 0 (#805).
3535
- With `process_orders_on_close` and the default FIFO close rule, the named `strategy.exit` calls of a reversing `strategy.entry` with an explicit quantity, placed in the same execution after a `strategy.close` of the old position, are now sized from the new entry's own quantity: a percentage exit takes its share of the new entry and an absolute-quantity exit keeps its quantity, instead of being sized from a basis reduced by the old position (#803).
3636
- Without `process_orders_on_close`, the named `strategy.exit` calls placed with a reversing `strategy.entry` of explicit quantity now take their percentage from the new entry when its size differs from the position it replaces, and a take-profit given as an absolute quantity now fires; before, the percentage was taken from the position being replaced and an absolute-quantity take-profit never fired (#803).

‎docs/design/native-feature-parity.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1671,7 +1671,7 @@ the rule gives 9.9 + 9.89).
16711671
| P5 | **Test asymmetry:** 430 adapter test files vs 14 native when this plan was written (on this tree 486 `tests/*.cpp` name `source::PineStrategyHost`, 128 `NativeStrategyHost`) | native-only tests in every lane (§3.1 b) | O |
16721672
| P6 | **Stream vs batch.** The stream refuses monthly input, mixed modes, in-session gaps, security feeds and source setters, and tick input under an FX curve (any non-empty curve until the FX stream audit) (`native-engine.md`, "Stream limitations (current)") | L5 and L6 must state which refusals are generic and which are deliberate source limits | S |
16731673
| P7 | **C ABI variant growth** | §2.iii hardening rules | S |
1674-
| P8 | **Unverified in the inputs:** whether `execution::LifecycleEffects` (execution.hpp:136-139) is ever non-empty from the Pine path, else `PlacementSnapshot::legs` (pine_adapter.hpp:385) is the only live lifecycle (O); the `strategy.risk.allow_entry_in` setter chain beyond `set_pine_risk_direction` pine_strategy_host.cpp:1243 → `set_risk_direction` pine_adapter.cpp:27347 (O); what the ABI receipts pin (F); the probe corpus itself lives outside this tree (F) | verify inside the lane that touches each | F O |
1674+
| P8 | **Unverified in the inputs:** whether `execution::LifecycleEffects` (execution.hpp:136-139) is ever non-empty from the Pine path, else `PlacementSnapshot::legs` (pine_adapter.hpp:385) is the only live lifecycle (O); the `strategy.risk.allow_entry_in` setter chain beyond `set_pine_risk_direction` pine_strategy_host.cpp:1243 → `set_risk_direction` pine_adapter.cpp:27347 (O); what the ABI receipts pin (F); the probe corpus itself lives outside this tree (F) | verify inside the work item that touches each | F O |
16751675
16761676
### 4.3 Open design questions (supervisor level)
16771677

0 commit comments

Comments
 (0)