Skip to content

Commit fd78592

Browse files
luisleo526claude
andcommitted
Gate: the release row floor counts the post-wave-E rows that ran -- 572 (INT15)
Recounted on the integrated tree, not summed from the lanes' own bases: `ctest -N` registers 572 rows in the release profile and 203 in the kernel profile, of which the kernel's live-WebSocket row still skips on a system libcurl, so 202 kernel rows run. release 571 (main, 0ad1e8e) +1 E27 test_pooc_fill_stamp_aggregation (source-bound, release only) +0 E26 (its checks land inside test_session_islastbar_aggregation, which lane E25 already registered) = 572 registered, 572 run (no release row skips) kernel 202 (main) + 0 = 202 run, 203 registered -- E26 touches only src/source/pine_strategy_host.cpp, and E27's TU includes pineforge/source/, so neither registers in a source-free profile. `RELEASE_MIN_TESTS` moves 571 -> 572; `KERNEL_MIN_TESTS` stays 202. The added comment lines shift the constants, so the three published citations of `RELEASE_MIN_TESTS` follow them to ci_verify.py:168 and the three of `KERNEL_MIN_TESTS` to :127 (scripts/reanchor_doc_citations.py carried the `KERNEL_MIN_TESTS` half; the `RELEASE_MIN_TESTS` half cites the constant's own line, which the bump rewrites, so its digits are carried here). check_doc_anchors.py: bad=0. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
1 parent 9f27d92 commit fd78592

3 files changed

Lines changed: 17 additions & 6 deletions

File tree

‎CONTRIBUTING.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,8 +149,8 @@ What each gate refuses:
149149
### The floors
150150

151151
`ci_verify.py` counts the CTest rows that actually **ran** and fails below a
152-
floor — `KERNEL_MIN_TESTS` ci_verify.py:122 and `RELEASE_MIN_TESTS`
153-
ci_verify.py:157.
152+
floor — `KERNEL_MIN_TESTS` ci_verify.py:127 and `RELEASE_MIN_TESTS`
153+
ci_verify.py:168.
154154
A deleted or silently skipped row is a failure, not a quieter run. If your
155155
change adds rows, raise the floor in the same commit and say by how much; if it
156156
legitimately removes one, lower it deliberately and say why. `--min-tests`

‎docs/pages/contributing-llm.md‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,8 @@ finding to report, not a step to take.
103103
coverage claim.
104104

105105
10. **A test row never silently disappears.** Each profile counts the rows that
106-
*ran* against a floor: `KERNEL_MIN_TESTS` ci_verify.py:122 and
107-
`RELEASE_MIN_TESTS` ci_verify.py:157. Adding rows means raising the floor
106+
*ran* against a floor: `KERNEL_MIN_TESTS` ci_verify.py:127 and
107+
`RELEASE_MIN_TESTS` ci_verify.py:168. Adding rows means raising the floor
108108
in the same commit.
109109

110110
## The recipe for a lane
@@ -249,7 +249,7 @@ measurement that produced it, so a later change to it is visible as a change to
249249
the record, not as an edit to a literal.
250250

251251
**floor** — the minimum number of CTest rows a profile must actually run
252-
(`KERNEL_MIN_TESTS` ci_verify.py:122, `RELEASE_MIN_TESTS` ci_verify.py:157). It
252+
(`KERNEL_MIN_TESTS` ci_verify.py:127, `RELEASE_MIN_TESTS` ci_verify.py:168). It
253253
counts rows that ran, so a skipped row does not pad it.
254254

255255
**receipt** — the recorded evidence an ABI-comparison row needs (a prepared

‎scripts/ci_verify.py‎

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,11 @@
119119
# no commit. E18, E20, E21 and E22 add no row either: every one of their
120120
# witnesses is a scenario inside a TU that already existed.
121121
# 203 registered, 202 run: the WebSocket row still skips on a system libcurl.
122+
# The R5 post-wave-E lanes (INT15) leave this profile alone: E26 changes
123+
# src/source/pine_strategy_host.cpp and adds its checks to the TU lane E25
124+
# already registered, and E27's witness includes pineforge/source/, so it
125+
# registers in release only -- see RELEASE_MIN_TESTS. Still 203 registered,
126+
# 202 run, recounted on the integrated tree.
122127
KERNEL_MIN_TESTS = 202
123128
# Release-row floor, the same gate for the default profile. Before lane P7
124129
# only the kernel profile had one, so a row that left release alone (a
@@ -154,7 +159,13 @@
154159
# +1 E19 test_e19_excursion_path_order
155160
# +1 E25 test_session_islastbar_aggregation
156161
# No release row skips, so 571 registered is 571 run.
157-
RELEASE_MIN_TESTS = 571
162+
# 572 = those 571 plus the one TU of the R5 post-wave-E lanes (INT15):
163+
# +1 E27 test_pooc_fill_stamp_aggregation
164+
# Its TU reaches the source layer, so it registers in release only and the
165+
# kernel floor does not move. Lane E26 adds no row: its witnesses are
166+
# scenarios inside test_session_islastbar_aggregation, which lane E25
167+
# already registered. No release row skips, so 572 registered is 572 run.
168+
RELEASE_MIN_TESTS = 572
158169
# CTest's closing summary: '100% tests passed out of N' when nothing failed,
159170
# '97% tests passed, 3 tests failed out of N' otherwise. N includes a skipped
160171
# row (counted as passed) and a row CTest could not start (counted as

0 commit comments

Comments
 (0)