Skip to content

Commit f85ce18

Browse files
authored
Land a stack of ten engine changes: paged strings and maps, ABI 5, report-sink vectors, release environments and parallel preflight (#609)
This lands a stack of ten engine pull requests as one change, verified and measured once on the combined tree: - #567 tests: descriptor report-sink guard rows, Darwin write bookkeeping, per-platform stream memory bound - #572 kernel residual check: scan section payloads and symbols, never executable bytes - #511 ci: bind App-token minting jobs to release environments - #568 engine: Pine strings and maps stored on the paged object layer, flat in the number of bars - #574 metrics: carry the monthly return key as 64 bits, so extreme timestamps no longer overflow int - #575 abi: native_order_v8 and PF_ABI_VERSION 5, so a stale native module or a strategy library built for ABI 4 is refused - #558 docker: add the pf-report-sink/v1 golden vectors with a generator, a native capture tool and a drift test - #595 entrypoint: forward PINEFORGE_RUN_ID to run_json.py --run-id - #604 ci: route same-repository PR proof through member-only admission - #609 ci: parallelize independent preflight stages and balance unittest shards The member pull requests are closed as landed here.
1 parent d55b116 commit f85ce18

163 files changed

Lines changed: 13641 additions & 3542 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.github/actionlint.yaml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ self-hosted-runner:
44
- self-hosted
55
- pf-ci
66
- pf-ci-release
7-
- pf-gcp-pr
87
- pf-gcp-post
98
- pf-gcp-main
109
- gke-2cpu-4gb-amd64
Lines changed: 2 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,9 @@
11
name: Set up native runner libcurl
2-
description: Cache and build the checksum-pinned WebSocket-enabled libcurl
3-
inputs:
4-
cache-namespace:
5-
description: Isolate dependency caches for each verification profile
6-
default: shared
7-
cold-cache:
8-
description: Bypass dependency cache restore and save
9-
default: 'false'
2+
description: Build the checksum-pinned WebSocket-enabled libcurl
103
outputs:
114
curl-dir:
125
description: CMake package directory for ci_verify.py --curl-dir
136
value: ${{ steps.dependencies.outputs.curl-dir }}
14-
cache-hit:
15-
description: Whether the pinned installation was restored from cache
16-
value: ${{ steps.curl-cache.outputs.cache-hit }}
177
runs:
188
using: composite
199
steps:
@@ -31,24 +21,9 @@ runs:
3121
} > build-native-deps/environment.txt
3222
echo "identity=$(sha256sum build-native-deps/environment.txt | cut -d ' ' -f 1)" >> "$GITHUB_OUTPUT"
3323
echo "curl-dir=${GITHUB_WORKSPACE}/build-native-deps/curl-install/lib/cmake/CURL" >> "$GITHUB_OUTPUT"
34-
- name: Restore pinned WebSocket-enabled libcurl
35-
id: curl-cache
36-
if: ${{ inputs.cold-cache != 'true' }}
37-
uses: actions/cache/restore@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0
38-
with:
39-
path: build-native-deps/curl-install
40-
key: curl-${{ inputs.cache-namespace }}-${{ steps.dependencies.outputs.version }}-${{ steps.dependencies.outputs.sha256 }}-${{ steps.dependencies.outputs.identity }}-${{ hashFiles('.github/actions/setup-live-curl/action.yml', 'scripts/build_live_curl.sh') }}-${{ runner.os }}-${{ runner.arch }}
4124
- name: Build pinned WebSocket-enabled libcurl
4225
id: curl-build
4326
shell: bash
4427
env:
45-
CURL_CACHE_HIT: ${{ steps.curl-cache.outputs.cache-hit }}
28+
CURL_CACHE_HIT: "false"
4629
run: bash scripts/build_live_curl.sh build-native-deps 4
47-
# Save as soon as the dependency build succeeds. Later test failures and
48-
# job timeouts must not prevent a valid pinned installation from surviving.
49-
- name: Save pinned WebSocket-enabled libcurl
50-
if: ${{ inputs.cold-cache != 'true' && steps.curl-build.outcome == 'success' && steps.curl-cache.outputs.cache-hit != 'true' }}
51-
uses: actions/cache/save@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0
52-
with:
53-
path: build-native-deps/curl-install
54-
key: ${{ steps.curl-cache.outputs.cache-primary-key }}

‎.github/workflows/ci-post.yml‎

Lines changed: 0 additions & 85 deletions
Original file line numberDiff line numberDiff line change
@@ -303,17 +303,6 @@ jobs:
303303
sudo apt-get update
304304
sudo DEBIAN_FRONTEND=noninteractive apt-get install -y libeigen3-dev tzdata-legacy ccache strace
305305
306-
# PRs restore the newest compatible main cache via the default-branch
307-
# fallback. Only main writes this namespace, never a PR merge ref.
308-
- name: Restore ccache
309-
id: ccache-restore
310-
uses: actions/cache/restore@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0
311-
with:
312-
path: ${{ env.CCACHE_DIR }}
313-
key: ccache-main-${{ runner.os }}-${{ runner.arch }}-${{ matrix.build_type }}-${{ github.sha }}
314-
restore-keys: |
315-
ccache-main-${{ runner.os }}-${{ runner.arch }}-${{ matrix.build_type }}-
316-
317306
# The release profile fails below its CTest row floor (its row of the
318307
# PRIVATE_FIXTURE_PROFILE_FLOORS table in scripts/ci_verify.py);
319308
# debug registers a subset of those rows.
@@ -341,13 +330,6 @@ jobs:
341330
path: ci-diagnostics/
342331
if-no-files-found: warn
343332

344-
- name: Save main ccache
345-
if: ${{ success() && github.ref == 'refs/heads/main' && matrix.shard == 1 && steps.ccache-restore.outputs.cache-hit != 'true' }}
346-
uses: actions/cache/save@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0
347-
with:
348-
path: ${{ env.CCACHE_DIR }}
349-
key: ${{ steps.ccache-restore.outputs.cache-primary-key }}
350-
351333
build-debug:
352334
name: build-shard (${{ matrix.platform.os }}, ${{ matrix.build_type }}, ${{ matrix.shard }}/2)
353335
needs: [authz, changes]
@@ -400,16 +382,6 @@ jobs:
400382
sudo apt-get update
401383
sudo DEBIAN_FRONTEND=noninteractive apt-get install -y libeigen3-dev tzdata-legacy ccache strace
402384
403-
# Every shard restores the same key; only shard 1 publishes it.
404-
- name: Restore ccache
405-
id: ccache-restore
406-
uses: actions/cache/restore@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0
407-
with:
408-
path: ${{ env.CCACHE_DIR }}
409-
key: ccache-main-${{ runner.os }}-${{ runner.arch }}-${{ matrix.build_type }}-${{ github.sha }}
410-
restore-keys: |
411-
ccache-main-${{ runner.os }}-${{ runner.arch }}-${{ matrix.build_type }}-
412-
413385
- name: Verify (${{ matrix.build_type }})
414386
env:
415387
PINEFORGE_RUNTIME_BUDGET_CANDIDATE_ONLY: '0'
@@ -429,13 +401,6 @@ jobs:
429401
path: ci-diagnostics/
430402
if-no-files-found: warn
431403

432-
- name: Save main ccache
433-
if: ${{ success() && github.ref == 'refs/heads/main' && matrix.shard == 1 && steps.ccache-restore.outputs.cache-hit != 'true' }}
434-
uses: actions/cache/save@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0
435-
with:
436-
path: ${{ env.CCACHE_DIR }}
437-
key: ${{ steps.ccache-restore.outputs.cache-primary-key }}
438-
439404
build-release-gate:
440405
name: build (ubuntu-24.04, Release)
441406
needs: [authz, changes, build]
@@ -530,17 +495,6 @@ jobs:
530495
sudo apt-get update
531496
sudo DEBIAN_FRONTEND=noninteractive apt-get install -y libeigen3-dev tzdata-legacy ccache strace
532497
533-
# PRs restore the newest compatible main cache via the default-branch
534-
# fallback. Only main writes this namespace, never a PR merge ref.
535-
- name: Restore ccache
536-
id: ccache-restore
537-
uses: actions/cache/restore@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0
538-
with:
539-
path: ${{ env.CCACHE_DIR }}
540-
key: ccache-main-${{ runner.os }}-${{ runner.arch }}-${{ matrix.build_type }}-${{ github.sha }}
541-
restore-keys: |
542-
ccache-main-${{ runner.os }}-${{ runner.arch }}-${{ matrix.build_type }}-
543-
544498
# The release profile fails below its CTest row floor (its row of the
545499
# PRIVATE_FIXTURE_PROFILE_FLOORS table in scripts/ci_verify.py);
546500
# debug registers a subset of those rows.
@@ -568,13 +522,6 @@ jobs:
568522
path: ci-diagnostics/
569523
if-no-files-found: warn
570524

571-
- name: Save main ccache
572-
if: ${{ success() && github.ref == 'refs/heads/main' && steps.ccache-restore.outputs.cache-hit != 'true' }}
573-
uses: actions/cache/save@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0
574-
with:
575-
path: ${{ env.CCACHE_DIR }}
576-
key: ${{ steps.ccache-restore.outputs.cache-primary-key }}
577-
578525
# Dedicated AddressSanitizer + UndefinedBehaviorSanitizer lane. Without this,
579526
# the determinism / NaN-propagation / handle-reuse / C-ABI-lifecycle probes
580527
# would run un-instrumented and could not actually trip the leak / double-free
@@ -625,15 +572,6 @@ jobs:
625572
sudo apt-get update
626573
sudo DEBIAN_FRONTEND=noninteractive apt-get install -y libeigen3-dev tzdata-legacy ccache
627574
628-
- name: Restore ccache
629-
id: ccache-restore
630-
uses: actions/cache/restore@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0
631-
with:
632-
path: ${{ env.CCACHE_DIR }}
633-
key: ccache-${{ runner.os }}-${{ runner.arch }}-sanitizers-${{ github.sha }}
634-
restore-keys: |
635-
ccache-${{ runner.os }}-${{ runner.arch }}-sanitizers-
636-
637575
- name: Verify (sanitizers)
638576
if: ${{ needs.authz.result == 'success' }}
639577
run: python3 scripts/ci_verify.py sanitizers --build-dir build-asan --jobs "$(getconf _NPROCESSORS_ONLN)" --ccache --ctest-shard ${{ matrix.shard }}/4
@@ -650,13 +588,6 @@ jobs:
650588
path: ci-diagnostics/
651589
if-no-files-found: warn
652590

653-
- name: Save main ccache
654-
if: ${{ success() && github.ref == 'refs/heads/main' && matrix.shard == 1 && steps.ccache-restore.outputs.cache-hit != 'true' }}
655-
uses: actions/cache/save@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0
656-
with:
657-
path: ${{ env.CCACHE_DIR }}
658-
key: ${{ steps.ccache-restore.outputs.cache-primary-key }}
659-
660591
sanitizers-gate:
661592
name: sanitizers
662593
needs: [authz, changes, sanitizers]
@@ -724,15 +655,6 @@ jobs:
724655
sudo apt-get update
725656
sudo DEBIAN_FRONTEND=noninteractive apt-get install -y cmake ninja-build libeigen3-dev tzdata-legacy libsqlite3-dev libssl-dev zlib1g-dev ccache
726657
727-
- name: Restore ccache
728-
id: ccache-restore
729-
uses: actions/cache/restore@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0
730-
with:
731-
path: ${{ env.CCACHE_DIR }}
732-
key: ccache-${{ runner.os }}-${{ runner.arch }}-kernel-${{ github.sha }}
733-
restore-keys: |
734-
ccache-${{ runner.os }}-${{ runner.arch }}-kernel-
735-
736658
- name: Set up pinned WebSocket-enabled libcurl
737659
id: curl-deps
738660
if: ${{ needs.authz.result == 'success' }}
@@ -754,13 +676,6 @@ jobs:
754676
path: ci-diagnostics/
755677
if-no-files-found: warn
756678

757-
- name: Save main ccache
758-
if: ${{ success() && github.ref == 'refs/heads/main' && matrix.shard == 1 && steps.ccache-restore.outputs.cache-hit != 'true' }}
759-
uses: actions/cache/save@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0
760-
with:
761-
path: ${{ env.CCACHE_DIR }}
762-
key: ${{ steps.ccache-restore.outputs.cache-primary-key }}
763-
764679
kernel-only-gate:
765680
name: kernel-only
766681
needs: [authz, changes, kernel-only]

0 commit comments

Comments
 (0)