Skip to content

Commit d590ca1

Browse files
luisleo526claude
andauthored
comments: say what the code does in four places that said something else (#569)
Corrects four comments that no longer match the code they describe, and one stale line number in a script comment: ci_verify.py names the selected-sink memory test's current CMakeLists line; the pinned create-diagnostics test header names the producing files; the placement-table comment in pine_adapter.cpp describes the retained-placement scan and the historical minima for erased rows; the native_host.hpp live-order read comment no longer claims the reads never allocate. No code changes. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
1 parent b08fc6f commit d590ca1

4 files changed

Lines changed: 7 additions & 7 deletions

File tree

‎include/pineforge/native_host.hpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1281,7 +1281,7 @@ class NativeStrategyHost : public BacktestEngine {
12811281
/// without any bookkeeping to keep in step. Text that matches nothing is
12821282
/// not a command.
12831283
std::vector<NativeWorkingRequest> native_working_requests() const;
1284-
/// Allocation-free live-order reads with the owning accessor's visibility.
1284+
/// Live-order reads, owning accessor's visibility; spilled rows may allocate and do scratch I/O.
12851285
/// Callbacks may read or write their own scratch store, but issue no host
12861286
/// commands. False returns cancelled, even for the last row.
12871287
detail::ScratchStatus visit_native_working_requests(void*, bool (*)(void*, const NativeWorkingRequest&)) const;

‎scripts/ci_verify.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -953,7 +953,7 @@ def permitted_exclusion_skips(pinned: frozenset[str], host_platform: str) -> fro
953953
'test_native_runtime_ambient',
954954
'test_native_script_bucket_completions',
955955
'test_native_settlement_carry',
956-
# tests/CMakeLists.txt:7354.
956+
# tests/CMakeLists.txt:7516.
957957
'test_run_json_selected_sink_memory_l9s',
958958
# tests/CMakeLists.txt:7354 (report-memory bound row).
959959
'test_report_sink_scratch_curve_resident',

‎src/source/pine_adapter.cpp‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6686,8 +6686,8 @@ void PineExecutionAdapter::retire_in_position_exits_at_flat(
66866686
std::uint64_t PineExecutionAdapter::command_sequence_for_exit(
66876687
const SourceId& exit_id, const SourceId& from_entry) const {
66886688
// The same-bar exit sort asks this on every script bar while its tail
6689-
// group persists; the table answers from its per-id index instead of a
6690-
// scan over every placement ever retained (quadratic over a long run).
6689+
// group persists; the table scans retained placements and consults the
6690+
// historical minima for erased rows.
66916691
return placement_.command_sequence_for(exit_id, from_entry);
66926692
}
66936693

‎tests/test_scratch_create_pinned_text.cpp‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
// Pin the 1.6.3 create diagnostics through real opens, with explicit paths.
2-
// No TMPDIR changes or injected failures. RED at e36e585064 is predicted,
3-
// not observed: compile and execute this unit only on the supervisor's box.
1+
// Pin the create diagnostics of the scratch files and the wrappers that open
2+
// them (command, report, id-pair and successor-roots scratch) through real
3+
// opens, with explicit paths. No TMPDIR changes or injected failures.
44
#include "scratch_process_fixture.hpp"
55
#include "../src/command_scratch_production.hpp"
66
#include "../src/report_scratch.hpp"

0 commit comments

Comments
 (0)