Repository navigation
Commit d21ea8d
TradeLedger: per-field accessors and a 65,536-row default read cache for closedtrades loops
Round 3 cached decoded rows, but hungpixi (24,238 closed trades, a loop over
all of them each bar) thrashed the 4096-row cache and every Pine accessor still
built a whole Trade by value to read one field. Now:
- TradeLedger::<field>_at(i) returns one field straight from the cached record
(numeric: no Trade, no string; string: only the requested packed bytes), with
the same checked-row contract as at(); the closed_trade_* accessors in
engine.hpp use them (values and error behaviour unchanged, percent formulas
unchanged).
- Default budget 65,536 rows (max 1,048,576); entry = 168-byte record + 16-byte
key/generation + 128 inline string bytes = 312 bytes (20,447,232 B at the
default). A row whose four strings exceed 128 bytes keeps its numeric fields
cached and reads strings from scratch.
- The cache array grows lazily to min(budget, next power of two >= max(64,
rows)), so a run with few trades allocates a few KiB, and memory is bounded by
the budget independent of bars.
- seal() no longer invalidates the cache: publication changes no row content and
the checked accessors refuse sealed rows before reaching the cache; otherwise
every published trade would make the next loop cold again.
Tests: hungpixi-shaped 24,238-row loop (zero reads/writes after warm-up,
oracle-compared), allocation check for numeric hits, lazy growth boundaries,
wide-string fallback, replace/rewind/move invalidation, sealed-row refusal for
every new accessor. Refusal still uses setting_rejected until the shared
resident-budget code lands.
Edit-only lane: nothing built or run at commit time; lab verification follows.
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>1 parent 6548775 commit d21ea8d
6 files changed
Lines changed: 473 additions & 109 deletions
File tree
- include/pineforge
- src
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1605 | 1605 | | |
1606 | 1606 | | |
1607 | 1607 | | |
1608 | | - | |
| 1608 | + | |
1609 | 1609 | | |
1610 | 1610 | | |
1611 | 1611 | | |
1612 | 1612 | | |
1613 | | - | |
| 1613 | + | |
1614 | 1614 | | |
1615 | 1615 | | |
1616 | 1616 | | |
1617 | | - | |
| 1617 | + | |
1618 | 1618 | | |
1619 | 1619 | | |
1620 | 1620 | | |
1621 | | - | |
| 1621 | + | |
1622 | 1622 | | |
1623 | 1623 | | |
1624 | 1624 | | |
1625 | | - | |
| 1625 | + | |
1626 | 1626 | | |
1627 | 1627 | | |
1628 | 1628 | | |
1629 | | - | |
| 1629 | + | |
1630 | 1630 | | |
1631 | 1631 | | |
1632 | 1632 | | |
1633 | | - | |
| 1633 | + | |
1634 | 1634 | | |
1635 | 1635 | | |
1636 | 1636 | | |
1637 | | - | |
| 1637 | + | |
1638 | 1638 | | |
1639 | 1639 | | |
1640 | 1640 | | |
1641 | | - | |
| 1641 | + | |
1642 | 1642 | | |
1643 | 1643 | | |
1644 | 1644 | | |
1645 | | - | |
| 1645 | + | |
1646 | 1646 | | |
1647 | 1647 | | |
1648 | 1648 | | |
1649 | | - | |
| 1649 | + | |
1650 | 1650 | | |
1651 | 1651 | | |
1652 | 1652 | | |
1653 | | - | |
| 1653 | + | |
1654 | 1654 | | |
1655 | 1655 | | |
1656 | 1656 | | |
1657 | | - | |
| 1657 | + | |
1658 | 1658 | | |
1659 | 1659 | | |
1660 | 1660 | | |
1661 | | - | |
| 1661 | + | |
1662 | 1662 | | |
1663 | 1663 | | |
1664 | 1664 | | |
1665 | | - | |
| 1665 | + | |
1666 | 1666 | | |
1667 | 1667 | | |
1668 | 1668 | | |
1669 | | - | |
| 1669 | + | |
1670 | 1670 | | |
1671 | 1671 | | |
1672 | 1672 | | |
1673 | 1673 | | |
1674 | 1674 | | |
1675 | 1675 | | |
1676 | 1676 | | |
1677 | | - | |
1678 | | - | |
1679 | | - | |
| 1677 | + | |
| 1678 | + | |
1680 | 1679 | | |
1681 | 1680 | | |
1682 | 1681 | | |
1683 | | - | |
| 1682 | + | |
1684 | 1683 | | |
1685 | 1684 | | |
1686 | 1685 | | |
1687 | | - | |
1688 | | - | |
1689 | | - | |
| 1686 | + | |
| 1687 | + | |
1690 | 1688 | | |
1691 | 1689 | | |
1692 | 1690 | | |
1693 | 1691 | | |
1694 | 1692 | | |
1695 | | - | |
| 1693 | + | |
1696 | 1694 | | |
1697 | 1695 | | |
1698 | 1696 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
| |||
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
22 | | - | |
| 23 | + | |
| 24 | + | |
23 | 25 | | |
24 | 26 | | |
25 | 27 | | |
| |||
36 | 38 | | |
37 | 39 | | |
38 | 40 | | |
39 | | - | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
40 | 44 | | |
41 | | - | |
| 45 | + | |
42 | 46 | | |
43 | 47 | | |
44 | | - | |
45 | | - | |
| 48 | + | |
| 49 | + | |
46 | 50 | | |
47 | 51 | | |
48 | 52 | | |
| |||
80 | 84 | | |
81 | 85 | | |
82 | 86 | | |
83 | | - | |
| 87 | + | |
84 | 88 | | |
85 | | - | |
86 | | - | |
| 89 | + | |
| 90 | + | |
87 | 91 | | |
88 | 92 | | |
89 | 93 | | |
90 | 94 | | |
91 | 95 | | |
92 | 96 | | |
93 | 97 | | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
94 | 102 | | |
95 | 103 | | |
96 | 104 | | |
| |||
108 | 116 | | |
109 | 117 | | |
110 | 118 | | |
111 | | - | |
112 | | - | |
| 119 | + | |
| 120 | + | |
113 | 121 | | |
114 | 122 | | |
115 | 123 | | |
116 | 124 | | |
117 | 125 | | |
118 | | - | |
119 | | - | |
| 126 | + | |
| 127 | + | |
120 | 128 | | |
121 | 129 | | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
122 | 151 | | |
123 | 152 | | |
124 | 153 | | |
| |||
0 commit comments