Repository navigation
Commit d1c1934
ci: admit the typed Eigen3_DIR flag in the release step contract (#795)
The release prebuilt configure passes -DEigen3_DIR=/usr/share/eigen3/cmake
and then requires the cache line Eigen3_DIR:PATH=/usr/share/eigen3/cmake.
Without a type CMake caches the entry as Eigen3_DIR:UNINITIALIZED, so the
check fails after every successful configure. The fix is the typed flag,
but the PR admission rules judge a pull request's workflows with main's
contract, which names the untyped flag exactly.
Read -DEigen3_DIR:PATH=/usr/share/eigen3/cmake as the reviewed untyped flag
wherever the release prebuilt steps are compared, so both forms are
admitted. release.yml is unchanged here; the switch to the typed flag, and
the contract's return to a single form, follow in their own change. Any
other Eigen3_DIR value is still refused.
Co-Authored-By: Claude Opus 5.5 <[email protected]>1 parent a3964ad commit d1c1934
2 files changed
Lines changed: 33 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4764 | 4764 | | |
4765 | 4765 | | |
4766 | 4766 | | |
| 4767 | + | |
| 4768 | + | |
| 4769 | + | |
| 4770 | + | |
| 4771 | + | |
| 4772 | + | |
| 4773 | + | |
| 4774 | + | |
| 4775 | + | |
| 4776 | + | |
| 4777 | + | |
| 4778 | + | |
| 4779 | + | |
| 4780 | + | |
| 4781 | + | |
4767 | 4782 | | |
| 4783 | + | |
4768 | 4784 | | |
4769 | 4785 | | |
4770 | 4786 | | |
| |||
4857 | 4873 | | |
4858 | 4874 | | |
4859 | 4875 | | |
| 4876 | + | |
4860 | 4877 | | |
4861 | 4878 | | |
4862 | 4879 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12853 | 12853 | | |
12854 | 12854 | | |
12855 | 12855 | | |
| 12856 | + | |
| 12857 | + | |
| 12858 | + | |
| 12859 | + | |
| 12860 | + | |
| 12861 | + | |
| 12862 | + | |
| 12863 | + | |
| 12864 | + | |
| 12865 | + | |
| 12866 | + | |
| 12867 | + | |
| 12868 | + | |
| 12869 | + | |
| 12870 | + | |
| 12871 | + | |
12856 | 12872 | | |
12857 | 12873 | | |
12858 | 12874 | | |
| |||
0 commit comments