Skip to content

Commit c9a6414

Browse files
authored
tests: align adapter offset pins with placement storage growth (#763)
Expectation corrected: pine_view_ 88208 -> 88240, retired_row_scratch_ 88216 -> 88248 and staged_scopes_ 88888 -> 88920, because 075d86f added a bool, its seven bytes of alignment padding and three uint64 counters to PlacementTable. The adapter contains that table by value before the pinned members. The enclosing size pins were already updated; keep those and every other offset unchanged. Record filesystem capacity after sanitizer verification, including a failed verification, alongside the preparation measurements.
1 parent eb29cf5 commit c9a6414

3 files changed

Lines changed: 11 additions & 3 deletions

File tree

‎.github/workflows/ci-post.yml‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -746,6 +746,10 @@ jobs:
746746
TMPDIR: /mnt/pineforge-sanitizers/${{ github.run_id }}-${{ matrix.shard }}/tmp
747747
run: python3 scripts/ci_verify.py sanitizers --build-dir build-asan --jobs "$(getconf _NPROCESSORS_ONLN)" --ccache --ctest-shard ${{ matrix.shard }}/8
748748

749+
- name: Measure sanitizer disk space after verification
750+
if: ${{ always() && needs.authz.result == 'success' }}
751+
run: df -h / /mnt
752+
749753
- name: Stage and summarize diagnostics
750754
if: ${{ always() && needs.authz.result == 'success' }}
751755
run: python3 scripts/collect_ci_diagnostics.py --build-dir build-asan --profile sanitizers

‎.github/workflows/native-live.yml‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -292,6 +292,10 @@ jobs:
292292
TMPDIR: /mnt/pineforge-native-sanitizers/${{ github.run_id }}-${{ matrix.profile }}/tmp
293293
run: python3 scripts/ci_verify.py ${{ matrix.profile }} --build-dir ${{ matrix.build_dir }} --jobs "$(getconf _NPROCESSORS_ONLN)" --generator Ninja --curl-dir "${{ steps.curl-deps.outputs.curl-dir }}" --ccache
294294

295+
- name: Measure sanitizer disk space after verification
296+
if: ${{ always() && needs.authz.result == 'success' }}
297+
run: df -h / /mnt
298+
295299
- name: Stage and summarize diagnostics
296300
if: always()
297301
env:

‎tests/test_abi_layout_probe.cpp‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -197,11 +197,11 @@ int main() {
197197
pins_hold &= pin("RetiredRowScratch::origin_fronts_pinned",
198198
member_offset(adapter.*access(RetiredScratch{}), &Scratch::origin_fronts_pinned), 664);
199199
pins_hold &= pin("PineExecutionAdapter::pine_view_",
200-
member_offset(adapter, access(BeforeScratch{})), 88208);
200+
member_offset(adapter, access(BeforeScratch{})), 88240);
201201
pins_hold &= pin("PineExecutionAdapter::retired_row_scratch_",
202-
member_offset(adapter, access(RetiredScratch{})), 88216);
202+
member_offset(adapter, access(RetiredScratch{})), 88248);
203203
pins_hold &= pin("PineExecutionAdapter::staged_scopes_",
204-
member_offset(adapter, access(AfterScratch{})), 88888);
204+
member_offset(adapter, access(AfterScratch{})), 88920);
205205
pins_hold &= pin("PineStrategyHost::adapter_",
206206
member_offset(host, access(HostAdapter{})), 6440);
207207
return pins_hold ? 0 : 1;

0 commit comments

Comments
 (0)