You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit b883edb
Browse filesBrowse the repository at this point in the historyBrowse files
ci-cx
committed
tests: compare a borrowed fd's F_GETFL without Darwin's "descriptor was written" bit (CR-150 follow-up, fixes the three macOS-red tests)
macOS-26 Debug has been red on main since the CR-150 merge because
test_report_nonfinite_equity_cabi_fd, test_report_nonfinite_equity_cpp_fd and
test_report_sink_fd compare the raw F_GETFL of a borrowed pipe fd across a run.
The diagnostics run (engine-free control test_pipe_writer_fd_flags, no engine in
the process) showed that on macOS the first successful write to any pipe sets
bit 0x00010000 in the writer's F_GETFL (0x1 -> 0x10001), F_GETFD unchanged.
The engine does not change a caller-controlled flag; the assumption in the
tests is wrong on Darwin.
- tests/fd_flag_diagnostics.hpp: comparable_status_flags() clears exactly that
one bit on __APPLE__ (FWASWRITTEN, static_asserted to 0x00010000) and is the
identity everywhere else; a failed query stays negative. same_flags() now
also refuses a failed F_GETFL on either side.
- The three tests (all raw F_GETFL equalities across a run, including the
rejected-replacement comparison in test_report_sink_fd that the macOS run
never reached) compare the masked value on both sides; F_GETFD stays strict;
the failure messages still print the raw hex values.
- test_pipe_writer_fd_flags: on Apple the raw difference after the first write
must be 0 or exactly that bit, on Linux the raw values must be equal; added
Linux-running mutation controls showing the helper does not hide a change of
O_NONBLOCK, O_APPEND, the access mode or FD_CLOEXEC, nor a failed fcntl.
No src/ or include/ change. Verified only by the branch CI (macOS-26 Debug).
0 commit comments