Repository navigation
Commit a2bb907
* ci: reject workflow-level defaults and env in the promote-baseline pin (SEC846 follow-up)
Post-merge read of #482: the preflight pinned only the promote-guard job block, so
a workflow-level defaults.run.shell or an env carrying a secret passed the checker
while changing how the guard runs. ci_workflow_findings now rejects both, and the
guard's own defaults, with specific findings; tests cover each reported input, the
quoted and empty variants, and the unmodified workflow.
Lane: ci-fu-eng482 (Codex gpt-6.1-sol).
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
* test: expect the pinned-guard finding in main's current wording (engine #483 after the main merge)
After main (#470) landed, the checker's finding for a changed promote-guard block reads "must start
with the pinned read-only promote-guard"; this PR's new test_promotion_guard_rejects_job_defaults
still expected the earlier "credential-free" wording in its three subtests, so preflight failed. The
expected list is now the exact list the checker emits (the job-level defaults finding, then the
pinned-guard finding); the assertion stays an exact ordered equality. Checker unchanged.
Lane: ci-fu-eng483b (Codex gpt-6.1-sol).
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
---------
Co-authored-by: Claude Sonnet 5.5 <[email protected]>
1 parent 72d9fd5 commit a2bb907
3 files changed
Lines changed: 48 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1199 | 1199 | | |
1200 | 1200 | | |
1201 | 1201 | | |
1202 | | - | |
| 1202 | + | |
| 1203 | + | |
| 1204 | + | |
1203 | 1205 | | |
1204 | 1206 | | |
1205 | 1207 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1712 | 1712 | | |
1713 | 1713 | | |
1714 | 1714 | | |
| 1715 | + | |
| 1716 | + | |
| 1717 | + | |
| 1718 | + | |
1715 | 1719 | | |
| 1720 | + | |
| 1721 | + | |
1716 | 1722 | | |
1717 | 1723 | | |
1718 | 1724 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
944 | 944 | | |
945 | 945 | | |
946 | 946 | | |
| 947 | + | |
| 948 | + | |
| 949 | + | |
| 950 | + | |
| 951 | + | |
| 952 | + | |
| 953 | + | |
| 954 | + | |
| 955 | + | |
| 956 | + | |
| 957 | + | |
| 958 | + | |
| 959 | + | |
| 960 | + | |
| 961 | + | |
| 962 | + | |
| 963 | + | |
| 964 | + | |
| 965 | + | |
| 966 | + | |
| 967 | + | |
| 968 | + | |
| 969 | + | |
| 970 | + | |
| 971 | + | |
| 972 | + | |
| 973 | + | |
| 974 | + | |
| 975 | + | |
| 976 | + | |
| 977 | + | |
| 978 | + | |
| 979 | + | |
| 980 | + | |
| 981 | + | |
| 982 | + | |
| 983 | + | |
| 984 | + | |
| 985 | + | |
947 | 986 | | |
948 | 987 | | |
949 | 988 | | |
| |||
0 commit comments