Skip to content

Commit 9392273

Browse files
luisleo526claude
andcommitted
The floors count the rows the integrated tree runs (INT13, wave D)
Recomputed on the final tree, under lane Q12's rule: a floor is the number of rows that RAN, never the number registered, and a skipped row is listed rather than counted. No lane's own number is taken -- every lane raised its floor against its own base (0a47cbf, 189/554), while this branch is built on the documentation wave's main (9b50973, 193/558), so the lane values (E1 190/555, E10 191/556, ...) are all relative to a tree that no longer exists. Measured, not summed: python3 scripts/ci_verify.py kernel --build-dir build-ci-kernel --jobs 6 ctest ran 199 rows (floor 193); not counted: 1 skipped (test_native_live_websocket) -> 200 registered python3 scripts/ci_verify.py release --build-dir build-ci-release --jobs 6 ctest ran 566 rows (floor 558) -> 566 registered, none skipped KERNEL_MIN_TESTS 193 -> 199, per lane: +1 E1 test_native_anchored_trail_absent_arm +1 E3 test_native_margin_fx_clock +1 E4 test_abi_receipt_skips (registers in every profile) +1 E6 test_e6_entry_bar_mask_declaration +1 E10 test_e10_dead_path_prefix +1 E14 test_native_trail_best_seed (kernel-only, unlike E5's and E9's) RELEASE_MIN_TESTS 558 -> 566: those six, plus the two TUs that reach the source layer and therefore register in release only: +1 E5 test_offset_trail_quantized_arm +1 E9 test_trail_activation_tick_reach E2, E7, E8, E11, E12, E13 and E15 add no row: every witness they wrote is a new scenario inside a TU that already existed (test_native_report_truth, test_native_c_api, test_native_toolkit_bracket), which is why their lane reports say the integrator adds nothing for them. Cross-checked against a configure of origin/main's own tree with the same options: 558 rows registered there, 566 here, and the diff of the two `ctest -N` name lists is exactly those eight names with nothing removed. The comment that records this arithmetic moves both constants inside `scripts/ci_verify.py` (KERNEL_MIN_TESTS 93 -> 108, RELEASE_MIN_TESTS 116 -> 137), so the six citations of them in `CONTRIBUTING.md` and `docs/pages/contributing-llm.md` are re-anchored here rather than in the documentation commit: they are this commit's own line move. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
1 parent 3e17bc9 commit 9392273

3 files changed

Lines changed: 28 additions & 7 deletions

File tree

‎CONTRIBUTING.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,8 +146,8 @@ What each gate refuses:
146146
### The floors
147147

148148
`ci_verify.py` counts the CTest rows that actually **ran** and fails below a
149-
floor — `KERNEL_MIN_TESTS` ci_verify.py:93 and `RELEASE_MIN_TESTS`
150-
ci_verify.py:116.
149+
floor — `KERNEL_MIN_TESTS` ci_verify.py:108 and `RELEASE_MIN_TESTS`
150+
ci_verify.py:137.
151151
A deleted or silently skipped row is a failure, not a quieter run. If your
152152
change adds rows, raise the floor in the same commit and say by how much; if it
153153
legitimately removes one, lower it deliberately and say why. `--min-tests`

‎docs/pages/contributing-llm.md‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,8 @@ finding to report, not a step to take.
103103
coverage claim.
104104

105105
10. **A test row never silently disappears.** Each profile counts the rows that
106-
*ran* against a floor: `KERNEL_MIN_TESTS` ci_verify.py:93 and
107-
`RELEASE_MIN_TESTS` ci_verify.py:116. Adding rows means raising the floor
106+
*ran* against a floor: `KERNEL_MIN_TESTS` ci_verify.py:108 and
107+
`RELEASE_MIN_TESTS` ci_verify.py:137. Adding rows means raising the floor
108108
in the same commit.
109109

110110
## The recipe for a lane
@@ -249,7 +249,7 @@ measurement that produced it, so a later change to it is visible as a change to
249249
the record, not as an edit to a literal.
250250

251251
**floor** — the minimum number of CTest rows a profile must actually run
252-
(`KERNEL_MIN_TESTS` ci_verify.py:93, `RELEASE_MIN_TESTS` ci_verify.py:116). It
252+
(`KERNEL_MIN_TESTS` ci_verify.py:108, `RELEASE_MIN_TESTS` ci_verify.py:137). It
253253
counts rows that ran, so a skipped row does not pad it.
254254

255255
**receipt** — the recorded evidence an ABI-comparison row needs (a prepared

‎scripts/ci_verify.py‎

Lines changed: 23 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,22 @@
9090
# (test_doc_anchors, test_doc_lint) and L14-B's two example hosts
9191
# (example_native_auxiliary_feed_strategy, example_native_open_lots_strategy).
9292
# 194 registered, 193 run: the WebSocket row still skips on a system libcurl.
93-
KERNEL_MIN_TESTS = 193
93+
# 199 = those 193 plus the six TUs the R5 follow-up wave (INT13, wave D) adds
94+
# that this profile builds -- one per lane, measured on the integrated tree,
95+
# not summed from the lanes' own bases:
96+
# +1 E1 test_native_anchored_trail_absent_arm
97+
# +1 E3 test_native_margin_fx_clock
98+
# +1 E4 test_abi_receipt_skips (registers in every profile)
99+
# +1 E6 test_e6_entry_bar_mask_declaration
100+
# +1 E10 test_e10_dead_path_prefix
101+
# +1 E14 test_native_trail_best_seed
102+
# Lanes E5 and E9 add a row each as well (test_offset_trail_quantized_arm,
103+
# test_trail_activation_tick_reach), but both TUs reach the source layer, so
104+
# they register in release only -- see RELEASE_MIN_TESTS. E2, E7, E8, E11,
105+
# E12, E13 and E15 add no row: every one of their witnesses is a scenario
106+
# inside a TU that already existed.
107+
# 200 registered, 199 run: the WebSocket row still skips on a system libcurl.
108+
KERNEL_MIN_TESTS = 199
94109
# Release-row floor, the same gate for the default profile. Before lane P7
95110
# only the kernel profile had one, so a row that left release alone (a
96111
# source-bound TU dropped from TEST_SOURCES, a deleted twin or ABI row) left a
@@ -113,7 +128,13 @@
113128
# suites register wherever the tests do, the two example hosts wherever
114129
# PINEFORGE_BUILD_EXAMPLES is ON. No release row skips, so 558 registered is
115130
# 558 run.
116-
RELEASE_MIN_TESTS = 558
131+
# 566 = those 558 plus the eight TUs of the R5 follow-up wave (INT13, wave D):
132+
# the six KERNEL_MIN_TESTS lists above, which register here too, plus the two
133+
# source-bound ones the kernel profile does not build:
134+
# +1 E5 test_offset_trail_quantized_arm
135+
# +1 E9 test_trail_activation_tick_reach
136+
# No release row skips, so 566 registered is 566 run.
137+
RELEASE_MIN_TESTS = 566
117138
# CTest's closing summary: '100% tests passed out of N' when nothing failed,
118139
# '97% tests passed, 3 tests failed out of N' otherwise. N includes a skipped
119140
# row (counted as passed) and a row CTest could not start (counted as

0 commit comments

Comments
 (0)