@@ -508,6 +508,83 @@ def test_root_and_directory_symlinks_are_rejected(self):
508508 records = self .assert_verdict (self .run_checker (), False )
509509 self .assert_issue (records , link , "symlink" )
510510
511+ def test_ancestor_entry_added_between_stat_and_open_is_accepted (self ):
512+ ancestor = self .root
513+ self .root = ancestor / "payload"
514+ declare (self .root )
515+ self .generated (self .root ).mkdir ()
516+ path = self .shared ("lib/good.so" )
517+ entry = ancestor / "parallel ctest entry"
518+ declare (entry )
519+ self .generated (entry )
520+ module = self .load_checker ()
521+ original = os .open
522+ mutations = []
523+
524+ def add_entry (name , flags , * args , ** kwargs ):
525+ if (name == ancestor .name and flags & os .O_DIRECTORY
526+ and kwargs .get ("dir_fd" ) is not None and not mutations
527+ and os .path .samestat (os .fstat (kwargs ["dir_fd" ]), self .area .stat ())):
528+ # open_root has already statted this ancestor, but has not
529+ # opened it yet. The entry is outside the staged payload.
530+ before = ancestor .stat ()
531+ entry .mkdir ()
532+ # Force distinct metadata even on a coarse timestamp clock.
533+ os .utime (ancestor , ns = (before .st_atime_ns ,
534+ before .st_mtime_ns + 1_000_000_000 ))
535+ mutations .append ((before , ancestor .stat ()))
536+ return original (name , flags , * args , ** kwargs )
537+
538+ with mock .patch .object (module .os , "open" , side_effect = add_entry ):
539+ outcome = self .in_process (module )
540+ self .assertEqual (len (mutations ), 1 )
541+ before , after = mutations [0 ]
542+ self .assertTrue (entry .is_dir ())
543+ self .assertEqual ((before .st_dev , before .st_ino , before .st_mode ),
544+ (after .st_dev , after .st_ino , after .st_mode ))
545+ self .assertNotEqual (before .st_mtime_ns , after .st_mtime_ns )
546+ records = self .assert_verdict (outcome , True )
547+ self .assertTrue (self .targets (records )[str (path )]["inspected" ])
548+
549+ def test_ancestor_inode_replaced_between_stat_and_open_is_refused (self ):
550+ ancestor = self .root
551+ self .root = ancestor / "payload"
552+ declare (self .root )
553+ self .generated (self .root ).mkdir ()
554+ path = self .shared ("lib/good.so" )
555+ replacement = self .area / "replacement ancestor"
556+ retired = self .area / "original ancestor"
557+ declare (replacement , retired )
558+ self .generated (retired )
559+ # Keep a valid payload in the replacement so a weakened identity
560+ # check cannot pass this control by failing on missing libraries.
561+ self .copy (path , replacement / path .relative_to (ancestor ))
562+ module = self .load_checker ()
563+ original = os .open
564+ mutations = []
565+
566+ def replace_ancestor (name , flags , * args , ** kwargs ):
567+ if (name == ancestor .name and flags & os .O_DIRECTORY
568+ and kwargs .get ("dir_fd" ) is not None and not mutations
569+ and os .path .samestat (os .fstat (kwargs ["dir_fd" ]), self .area .stat ())):
570+ before = ancestor .stat ()
571+ ancestor .rename (retired )
572+ replacement .rename (ancestor )
573+ mutations .append ((before , ancestor .stat ()))
574+ return original (name , flags , * args , ** kwargs )
575+
576+ with mock .patch .object (module .os , "open" , side_effect = replace_ancestor ):
577+ outcome = self .in_process (module )
578+ self .assertEqual (len (mutations ), 1 )
579+ before , after = mutations [0 ]
580+ self .assertEqual (before .st_dev , after .st_dev )
581+ self .assertEqual (before .st_mode , after .st_mode )
582+ self .assertNotEqual (before .st_ino , after .st_ino )
583+ records = self .assert_verdict (outcome , False )
584+ self .assert_issue (records , self .root , "root component changed" )
585+ self .assertEqual (records [- 1 ]["inspected" ], 0 )
586+ self .assertFalse (any (row ["event" ] == "command" for row in records ))
587+
511588 def test_protected_entry_and_library_named_directory_fail_without_content_reads (self ):
512589 self .shared ("lib/good.so" )
513590 protected = self .root / ".env"
0 commit comments