Repository navigation
Commit 7da487a
ci/tests: remove the CI time limits; a platform-maximum stop is a HANG to re-run (EN-116) (#378)
tests: a slow compile must pass the native include-independence helper and its verifier stage (red first, EN-116)
Owner rule (EN-105 G9, EN-116): slowness never fails a required check. scripts/check_native_include_independence.py
compile_object() kills a compile after 120 seconds, raises InfrastructureError, and scripts/ci_verify.py records the
stage as failed. This test runs the real helper through the real Driver.invoke()/default_runner with a compiler
wrapper that sleeps 122 seconds and then runs the real compiler with the same arguments, and requires exit 0, the
object and dependency files, a passed stage with no recorded failure, and no timeout or deadline text in the
captured diagnostic or the stage log. It takes about two minutes on purpose. No production code, bound or
constant is changed or patched by the test, and no CMake registration or row count changes (the test lives in the
already registered scripts/test_ci_verify.py).
On this commit it FAILS (the helper's 120 second compile deadline expires); the commits that follow remove the
deadlines and it passes.
tests: remove the subprocess time limits of CI tests and checks (owner rule)
Owner rule (2026-10-12 15:52, verbatim): 不要做任何時間限制
類似的問題已經出現太多次了 很煩 — no time limits of any kind; problems of
this kind have come up too often.
Two CI jobs failed on 2026-10-12 only because a bound was too tight for a slow
row: hosted kernel-only run 38213895073 was killed at 1800 s, and main push run
38217844683 (native-live) died with "test_ci_verify: TIMEOUT 3600 must be
positive and less than stage deadline 2820".
This removes every `timeout=` bound on a subprocess a CI test or check runs,
together with the two local helpers that carried a timeout default
(`run_command` in scripts/check_native_include_independence.py, `run` in
scripts/prepare_settlement_cpp_abi_base.py), the `GIT_SECONDS` constant of
scripts/ci_docs_only.py, and the `timeout` parameter of `run_release` in
scripts/pf_release_run.py. Synchronization waits (threading Event/Barrier,
Thread.join, Queue.get, sqlite3 connect, socket settimeout, wait_for poll
helpers) and product configuration named timeout (connect_timeout_ms,
total_timeout_ms, --feed-idle-timeout, --feed-message-timeout) are untouched:
they are behaviour under test, not CI limits. scripts/ci_verify.py,
scripts/ci_preflight.py, scripts/test_ci_verify.py, scripts/test_ci_preflight.py,
tests/CMakeLists.txt, runner/CMakeLists.txt, .github/workflows/*.yml and
docs/ci.md belong to the sibling lane and are not touched here.
The platform's 360-minute job limit is the only hang catcher left.
Bounds removed per file (count):
benchmarks/speed/aggregate.py: 1
benchmarks/tests/test_run_all.py: 1
docker/run_json_provenance_test.py: 12
scripts/check_kernel_residuals.py: 1
scripts/check_native_include_independence.py: 6
scripts/check_pending_order_prefix_compiler.py: 1
scripts/check_runtime_budget.py: 2
scripts/ci_docs_only.py: 2
scripts/cpp_abi_pairing.py: 6
scripts/pf_release_run.py: 2
scripts/prepare_settlement_cpp_abi_base.py: 4
scripts/test_ci_docs_only.py: 1
scripts/test_cmake_version_source.py: 1
scripts/test_example_runner.py: 2
scripts/test_native_cpp_versions.py: 1
scripts/test_oracle_fixture_checks.py: 1
scripts/test_private_fixture_reads.py: 4
scripts/test_run_json_outputs.py: 1
scripts/test_twin_parity.py: 1
scripts/test_two_world_registration.py: 1
scripts/update_twin_parity_fixtures.py: 1
tests/checked_settings_e2e.py: 6
tests/confirmed_capabilities_e2e.py: 1
tests/confirmed_capabilities_refusals.py: 1
tests/confirmed_receipt_versions.py: 1
tests/extract_native_engine_complete_host.py: 1
tests/live_phase_a_migration.py: 3
tests/native_live_chart_calendar_e2e.py: 1
tests/native_live_chart_input_e2e.py: 7
tests/native_live_d7_fixtures.py: 3
tests/native_live_e2e.py: 4
tests/native_live_equivalence_e2e.py: 4
tests/native_live_report_e2e.py: 1
tests/native_live_routing_e2e.py: 12
tests/native_live_service_e2e.py: 7
tests/native_live_startup_e2e.py: 1
tests/native_live_tick_tape.py: 4
tests/native_live_websocket_e2e.py: 2
tests/same_calc_bracket_e2e.py: 1
tests/strategy_capabilities_e2e.py: 7
tests/test_compile_inventory_pipeline.py: 3
TOTAL: 122 bounds removed in 41 files. (An earlier version of this message listed
scripts/check_native_cpp_abi.py: 8 and a total of 130 in 42 files; that file has no
timeout in this commit's parent or in its tree, so it was never part of the change.)
ci: remove the verifier's own time limits and say the HANG rule (EN-116)
Owner rule (EN-105 G9 AMENDED, EN-116): slowness never fails a required check. No verifier stage, CTest row,
workflow step or profile carries a deadline of ours; the only hang catcher is the CI job envelope at the platform
maximum (360 minutes), and a job stopped there is a HANG to re-run, not a failed check. Exit-code, signal,
missing-summary and diagnostic checks stay.
* scripts/ci_verify.py: the options --test-timeout and --ctest-timeout, their config fields, validators, the
row-versus-stage deadline inventory check, the summary fields testTimeoutSeconds and ctestTimeoutSeconds, the
runner timeout parameters nobody passes any more and the dead TimeoutExpired handlers are removed; ctest is
called with --timeout 0 (no default per-test deadline of ours) instead of 21600; a row's own TIMEOUT property
is untouched.
* scripts/test_ci_verify.py: the deadline-contract tests assert the removed options, the absent summary fields
and unbounded dispatch; the deliberate CTest Timeout case now drives a row's own TIMEOUT 1 property and keeps its
exit-8, witness, failed-stage, log and JUnit checks.
* scripts/ci_preflight.py, scripts/test_ci_preflight.py, .github/workflows/native-live.yml: the native
verification step carries no step deadline; the job-level 360 minutes stay and are still required.
* Docs reworded so each sentence is true. Sentences named for the doc-revert gate (old text, first words):
"The opt-in --test-timeout N gives CTest a default per-test deadline in seconds"; "Neither is set anywhere in CI
any more (owner rule, 2026-10-12"; "With no explicit stage deadline the driver refuses no row for its speed";
"--test-timeout alone is accepted; both flags together still refuse a run whose per-test deadline";
"The native workflow passes neither flag." "The summary records both bounds (null when unset)"; "Their sanitizers CTest
stage gets no bound of its own any more"; "Its sanitizer job ran 61.5 min and hit the verifier's then-30-minute
CTest stage timeout (no stage carries a bound of ours any more)"; "No bound of the verifier's own is left to
bind first"; "Now no stage, row, step, profile or matrix entry carries a time limit of this repository's: every
row runs until it finishes"; "Its stages carry no timeout of their own any more -- the old 2400 s stage bound is
gone"; "No row, stage or step bound remains: its old 3600 s row bound is what collided with the 2820 s stage
deadline"; "Its old per-row 900 s and stage 1200 s deadlines are gone; a row now runs until it finishes"; "Its old
900/1200-s row/stage bounds are gone like live-sanitizers'" (docs/ci.md); "fails on a nonzero exit, a signal, a
timeout or a missing summary line" (docs/adr/0001-kernel-adapter-boundary.md, docs/pages/pine-to-native.md twice,
docs/pages/native-engine.md). The citations of ci_verify.py:794 became :789 in CONTRIBUTING.md:162,
docs/pages/contributing-llm.md:136 and :284 and docs/pages/native-engine.md:4616.
Not changed: the CPU-ratio and runtime-budget measurement gates, benchmarks/run_all.sh, the intentional
timeout-contract fixtures, runner/ product timeouts and .claude/settings.json.
tests: the native-live Python tests wait without deadlines (EN-116)
Owner rule (EN-105 G9, EN-116): slowness never fails a required check; the only hang catcher is the CI job
envelope, and an expiry there is a HANG (re-run), not a failed test. Exit codes, results and assertions on
what the code under test did stay. Polling intervals and deliberate delays stay; only the overall deadlines go.
* tests/native_live_service_e2e.py: the condition helper wait_for() and the delivery/keepalive event waits are
unbounded (two caller overrides of 30 s removed; the dead TimeoutExpired cleanup handler removed).
* tests/native_live_routing_e2e.py: the receiver barrier, the two newer-action event waits, the receiver and
reader joins, the condition helper and the queue read are unbounded; the ledger read retries a locked database
(only "database is locked", every other error propagates) instead of failing after 30 s of busy wait.
* tests/native_live_tick_tape.py, tests/native_live_websocket_e2e.py: the 30 s and 20 s socket read deadlines
and the dead TimeoutError handler are removed.
* tests/test_native_live_equivalence_harness.py: seven completion/reap waits, the log-readiness loop and the
helper subprocess are unbounded; their exit-code and exact-log assertions stay.
* tests/native_live_test_process.py: wait() with no timeout polls until the child ends; the explicit-timeout
path stays for the intentional timeout-contract test.
Not changed here (kept for a ruling): the elapsed-time assertions that prove a behaviour is prompt or that an
idle timeout fired (native_live_service_e2e.py "elapsed < 10", native_live_routing_e2e.py drain bound and two
"< 10" SIGTERM checks, native_live_websocket_e2e.py "elapsed >= 14"), the crash-window searches that need the
child to still be running (native_live_equivalence_e2e.py accepted.wait(120) against the 120 s ACK hold,
native_live_tick_tape.py deadline 600), and the explicit-timeout witness of the process helper.
tests: the native-live C++ test servers and one self-test wait without deadlines (EN-116)
Owner rule (EN-105 G9, EN-116): slowness never fails a required check; the only hang catcher is the CI job
envelope, and an expiry there is a HANG (re-run). Polling intervals stay; the intentional timeout-contract
cases stay.
* tests/test_native_live_websocket.cpp, tests/test_native_live_store.cpp: the mock servers' socket receive and
accept polls wait with no limit (poll(..., -1)) instead of throwing "receive/accept timeout" after 2-5 s;
a failing poll still throws.
* tests/test_native_live_service.cpp: the callback rendezvous and the periodic-status observation wait without
a deadline; their asserts stay.
* tests/native_live_service_strategy.cpp: the resume gate waits without a 10 s expiry; its 5 ms poll stays.
* scripts/derive_corpus_feeds_self_test.py: the writer barrier and the future results wait without 5 s limits.
Kept on purpose: the 20 ms connect / 30 ms total timeout cases and the 1000 ms total with a 50 ms cancellation
predicate (they test the product's timeout), and the mock servers' configured delays.
Not changed here (kept for a ruling): tests/test_local_time_lock_free_hit.cpp, a witness that releases the
timezone lock when its 5 s rendezvous expires.
tests: the native-live routing and service rows no longer fail on elapsed time (EN-116)
Owner rule (EN-105 G9, EN-116): slowness never fails a required check. Four rows asserted that a SIGTERM or a
fatal drain finished within a pinned number of seconds, so a slow or loaded host failed them:
tests/native_live_service_e2e.py (`elapsed < 10`), tests/native_live_routing_e2e.py (the fatal drain bound of three
total timeouts, and the two `< 10` SIGTERM checks).
The timing predicates are removed. Every return-code, stopped-state, blocked-receiver, outbox, unsent-action,
pending-count and report assertion of those rows stays, so each row still proves that the runner stops, keeps its
ledger and loses nothing. The row that asserts a MINIMUM (tests/native_live_websocket_e2e.py `elapsed >= 14`, an
idle timeout that must not fire early) is not touched: slowness cannot fail it.
Kept on purpose, not verdict bounds: the crash-window searches (tests/native_live_equivalence_e2e.py accepted.wait(120)
against the 120 s ACK hold, tests/native_live_tick_tape.py deadline 600), the explicit timeout-contract witness
(tests/test_native_live_equivalence_harness.py with TimedProcess.wait(timeout=...) in tests/native_live_test_process.py)
and the timezone-lock rendezvous witness (tests/test_local_time_lock_free_hit.cpp). A follow-up redesigns the first two
and the last without a wall-clock deadline.
ci: a native profile job stopped at the platform maximum is named a HANG to re-run (EN-116)
docs/ci.md now says a job stopped by the platform at its 360-minute maximum is recorded as a HANG to re-run, not
as a failed check. The native-live aggregate job saw only the result `cancelled` and printed nothing about it.
When any native profile job result is `cancelled` it now prints `HANG (re-run)` with the reason and still exits 1:
the check is not green, it is classified. `success` still exits 0; `failure`, `skipped` and an empty result still
exit 1 without the HANG line. scripts/ci_preflight.py still pins the `PROFILES_RESULT` environment line and the
`test "$PROFILES_RESULT" = success` line; scripts/test_ci_preflight.py asserts the HANG line appears exactly for
`cancelled`.
tests: finish removing the CI time limits the gating read found, and say the HANG rule exactly (EN-116)
A Claude gating read of the EN-116 engine diff found no faked pass and five mechanical leftovers; this commit
fixes them and nothing else.
* scripts/test_ci_preflight.py: the two subprocess time limits left in this required test are removed (the
`--check-ci-workflow` run and the aggregate-script run). The aggregate-script test now also requires exit code
exactly 1 for every result other than success, beside the existing success and HANG checks.
* tests/native_live_routing_e2e.py, tests/native_live_service_e2e.py: four `Event.wait()` guards that could not
fail (a wait without a timeout always returns true, so the `raise` or `assert` after it never fired) are plain
waits; three PASS lines no longer advertise a "3x global-timeout guard" or "within 10 s" guard that is gone. The
asserts on the behaviour (exit codes, ledger rows, reports) are untouched.
* docs/ci.md: the sentence that said a job stopped at the platform's 360-minute maximum "must be recorded as a HANG
to re-run, not as a failed check" (the prose and the `preflight` table row) is replaced by what the workflow does:
the native-live aggregate job names such a stop `HANG (re-run)` in its log, and the check still fails.
Kept on purpose, not time limits of the verifier: the equivalence harness waits (tests/native_live_equivalence_e2e.py,
a file no registered row runs), the explicit-timeout contract witness (tests/test_native_live_equivalence_harness.py
and tests/native_live_test_process.py), and product configuration named timeout.
Known residuals, named in the pull request: tests/native_live_tick_tape.py (600 s mid-tape kill wait, feeds the
registered native_live_genuine_retry_e2e row) and tests/test_local_time_lock_free_hit.cpp (5 s read bound).
Gates: pineforge/verify 8/8 on tree 6d64498 (release, sanitizers, debug, kernel, parity 312/312); pineforge/parity neutral (sweep exp-en378b-20261013, 7989 comparable, 0 moves; snapshot f766b251 published).
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>1 parent 2ea42e8 commit 7da487a
59 files changed
Lines changed: 363 additions & 430 deletions
File tree
- .github/workflows
- benchmarks
- speed
- tests
- docker
- docs
- adr
- pages
- scripts
- tests
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
109 | 109 | | |
110 | 110 | | |
111 | 111 | | |
112 | | - | |
113 | 112 | | |
114 | 113 | | |
115 | 114 | | |
| |||
154 | 153 | | |
155 | 154 | | |
156 | 155 | | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
157 | 159 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
159 | 159 | | |
160 | 160 | | |
161 | 161 | | |
162 | | - | |
| 162 | + | |
163 | 163 | | |
164 | 164 | | |
165 | 165 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
73 | | - | |
| 73 | + | |
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
115 | | - | |
| 115 | + | |
116 | 116 | | |
117 | 117 | | |
118 | 118 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
74 | | - | |
75 | | - | |
| 74 | + | |
76 | 75 | | |
77 | 76 | | |
78 | 77 | | |
| |||
274 | 273 | | |
275 | 274 | | |
276 | 275 | | |
277 | | - | |
| 276 | + | |
278 | 277 | | |
279 | 278 | | |
280 | 279 | | |
| |||
400 | 399 | | |
401 | 400 | | |
402 | 401 | | |
403 | | - | |
| 402 | + | |
404 | 403 | | |
405 | 404 | | |
406 | 405 | | |
| |||
562 | 561 | | |
563 | 562 | | |
564 | 563 | | |
565 | | - | |
| 564 | + | |
566 | 565 | | |
567 | 566 | | |
568 | 567 | | |
| |||
589 | 588 | | |
590 | 589 | | |
591 | 590 | | |
592 | | - | |
| 591 | + | |
593 | 592 | | |
594 | 593 | | |
595 | 594 | | |
| |||
657 | 656 | | |
658 | 657 | | |
659 | 658 | | |
660 | | - | |
| 659 | + | |
661 | 660 | | |
662 | 661 | | |
663 | 662 | | |
| |||
671 | 670 | | |
672 | 671 | | |
673 | 672 | | |
674 | | - | |
| 673 | + | |
675 | 674 | | |
676 | 675 | | |
677 | 676 | | |
| |||
741 | 740 | | |
742 | 741 | | |
743 | 742 | | |
744 | | - | |
| 743 | + | |
745 | 744 | | |
746 | 745 | | |
747 | 746 | | |
| |||
823 | 822 | | |
824 | 823 | | |
825 | 824 | | |
826 | | - | |
| 825 | + | |
827 | 826 | | |
828 | 827 | | |
829 | 828 | | |
| |||
841 | 840 | | |
842 | 841 | | |
843 | 842 | | |
844 | | - | |
| 843 | + | |
845 | 844 | | |
846 | 845 | | |
847 | 846 | | |
| |||
974 | 973 | | |
975 | 974 | | |
976 | 975 | | |
977 | | - | |
| 976 | + | |
978 | 977 | | |
979 | 978 | | |
980 | 979 | | |
| |||
1023 | 1022 | | |
1024 | 1023 | | |
1025 | 1024 | | |
1026 | | - | |
| 1025 | + | |
1027 | 1026 | | |
1028 | 1027 | | |
1029 | 1028 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
450 | 450 | | |
451 | 451 | | |
452 | 452 | | |
453 | | - | |
| 453 | + | |
454 | 454 | | |
455 | 455 | | |
456 | 456 | | |
| |||
0 commit comments