Skip to content

Commit 7d79006

Browse files
luisleo526claude
andauthored
ci: remove timeout-minutes (owner #827, no time limits) (#462)
* CI: drop timeout-minutes from ci.yml, corpus-parity.yml and native-live.yml (owner #827) Deletion-only sweep: 10 timeout-minutes lines removed. grep -rn timeout-minutes .github/ prints nothing; git diff --numstat shows 0 added. Co-Authored-By: Claude Code <[email protected]> * CI: the engine preflight requires the absence of timeout-minutes (owner #827) The deletion commit 85d03d6 removed every timeout-minutes declaration, but the repository's own contract still required the deleted 360-minute deadlines: ci_preflight.py's JOB_RUNNERS carried a minutes member and runner_findings asserted it, and test_ci_preflight.py's table asserted that a changed 360 still fails and that removing it fails too. The preflight therefore refused the sweep head (rj-20261020t104302-5cba28: ci-workflow-contract and preflight-tests, 10 findings "must allow 360 minutes"). Now no job or step may declare timeout-minutes. JOB_RUNNERS holds (runner, command); runner_findings reports one finding per affected job when the job declares it at job level, at any step level, as a step's first key, or as a quoted key. Runner labels, PF_CI_LABELS, core-count sizing and every other contract are unchanged, and no workflow file is touched. The must-fail table keeps a changed value failing (360 -> 30/45/60/10) with the new message; the removal row now passes with an empty finding list; anchors that used the deleted line moved to `steps:`; the minutes == 360 assertion is replaced by an assertion that the source workflows carry no timeout-minutes, plus new coverage for job-level, step-level, first-key and quoted-key declarations. docs/ci.md says the repository declares no job or step time limit and GitHub's 6 h platform maximum is the only bound; measured durations stay as historical context. check_doc_reverts names the four deleted sentences this commit supersedes, each stated here so the deletion stays attributable: "The native workflow retains only its 360-minute job envelopes, with no verification-step deadline." (7da487a); "Under the owner rule, no required-check stage, row, step, profile or matrix entry may carry a time limit of this repository's; the only hang catcher is the platform's own 360-minute job maximum, which every job below carries." (7da487a); "The table below reports each job's measured duration and the platform maximum that replaced its old limit, so the margin the removal buys stays visible." (2394ba2); "The numbers are measured durations, not a two-times multiplier." (2394ba2). Co-Authored-By: Claude Code <[email protected]> --------- Co-authored-by: Claude Code <[email protected]>
1 parent 88ec1b3 commit 7d79006

6 files changed

Lines changed: 93 additions & 67 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ jobs:
5656
fromJSON('["self-hosted","pf-ci","pf-ci-x64"]') || 'ubuntu-24.04' }}
5757
env:
5858
PF_CI_LABELS: '["self-hosted","pf-ci","pf-ci-x64"]'
59-
timeout-minutes: 360
6059
outputs:
6160
docs_only: ${{ steps.classify.outputs.docs_only }}
6261
verifier_slow: ${{ steps.verifier.outputs.verifier_slow }}
@@ -116,7 +115,6 @@ jobs:
116115
# shards, and no stage of this preflight carries a timeout of its own any
117116
# more (owner rule, 2026-10-12). A hang reaches the platform maximum; a
118117
# slow stage never fails the run.
119-
timeout-minutes: 360
120118
steps:
121119
- uses: actions/checkout@v4
122120
with:
@@ -178,7 +176,6 @@ jobs:
178176
# test_ci_verify CTest row, 976-1288 s on the standard runners at
179177
# 0d76a099, which more cores do not shorten. No bound of ours may fail a
180178
# slow leg (owner rule, 2026-10-12).
181-
timeout-minutes: 360
182179
strategy:
183180
fail-fast: false
184181
matrix:
@@ -289,7 +286,6 @@ jobs:
289286
# full set ran out of the old 30- and 60-minute stage bounds twice, and
290287
# the owner rule of 2026-10-12 removed the bounds rather than raising
291288
# them again.
292-
timeout-minutes: 360
293289
env:
294290
PF_CI_LABELS: '["self-hosted","pf-ci","pf-ci-x64-16"]'
295291
ASAN_OPTIONS: detect_leaks=1:halt_on_error=1:abort_on_error=1
@@ -361,7 +357,6 @@ jobs:
361357
# PRs exclude the measured slow rows; push and dispatch run the whole
362358
# kernel set. 360 minutes is the platform maximum, the only hang catcher
363359
# (owner rule, 2026-10-12).
364-
timeout-minutes: 360
365360
steps:
366361
- uses: actions/checkout@v4
367362
with:
@@ -449,7 +444,6 @@ jobs:
449444
fromJSON('["self-hosted","pf-ci","pf-ci-x64"]') || 'ubuntu-24.04' }}
450445
env:
451446
PF_CI_LABELS: '["self-hosted","pf-ci","pf-ci-x64"]'
452-
timeout-minutes: 360
453447
steps:
454448
- name: Require every verification lane to have passed
455449
shell: bash

‎.github/workflows/corpus-parity.yml‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,6 @@ jobs:
100100
# 16.3-26.2 min on the standard runner; 360 minutes is the platform maximum,
101101
# the only hang catcher (owner rule,
102102
# 2026-10-12: no bound of our own may fail a run for slowness).
103-
timeout-minutes: 360
104103
steps:
105104
- uses: actions/checkout@v4
106105
with:
@@ -184,7 +183,6 @@ jobs:
184183
PF_CI_LABELS: '["self-hosted","pf-ci","pf-ci-x64-16"]'
185184
# 1.8-4.7 min on the standard runner; 360 minutes is the platform
186185
# maximum, the only hang catcher (owner rule, 2026-10-12).
187-
timeout-minutes: 360
188186
steps:
189187
# Credentials stay persisted, exactly as the nightly job above: the
190188
# submodule clone and `git lfs pull` below go out over https and the

‎.github/workflows/native-live.yml‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ jobs:
4646
(github.event_name != 'pull_request' ||
4747
(github.event.pull_request.head.repo.full_name == github.repository && github.event.pull_request.head.repo.fork == false)) &&
4848
fromJSON('["self-hosted","pf-ci","pf-ci-x64-16"]') || 'ubuntu-24.04' }}
49-
timeout-minutes: 360
5049
strategy:
5150
fail-fast: false
5251
matrix:
@@ -161,7 +160,6 @@ jobs:
161160
fromJSON('["self-hosted","pf-ci","pf-ci-x64"]') || 'ubuntu-24.04' }}
162161
env:
163162
PF_CI_LABELS: '["self-hosted","pf-ci","pf-ci-x64"]'
164-
timeout-minutes: 360
165163
steps:
166164
- name: Require every native profile to have passed
167165
env:

‎docs/ci.md‎

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -249,8 +249,9 @@ receipts, and saving a cache cannot turn a failed verification into success.
249249
The verifier accepts no row or stage deadline options (owner rule,
250250
2026-10-12: no time limit may fail a run for slowness). It passes
251251
`ctest --timeout 0` to request no default per-test deadline; an explicit
252-
`TIMEOUT` property on a row remains untouched. The native workflow retains
253-
only its 360-minute job envelopes, with no verification-step deadline.
252+
`TIMEOUT` property on a row remains untouched. Under owner #827 (2026-10-20),
253+
this repository declares no job or step time limits; GitHub's own 6 h platform
254+
maximum is the only bound.
254255
The summary records discovered and selected row counts, executed rows,
255256
skipped or not-run rows, and stage timings, including when a test fails.
256257

@@ -1119,19 +1120,20 @@ that rule removed: the `test_ci_verify` row's 3600 s property outlived main's
11191120
2820 s native-live stage deadline, and main's own native-live job refused its
11201121
row set with `TIMEOUT 3600 must be positive and less than stage deadline
11211122
2820`. The hosted kernel-only job lost the same day's run the other way, to a
1122-
1800 s stage bound (exit 124). Under the owner rule, no required-check stage,
1123-
row, step, profile or matrix entry may carry a time limit of this repository's;
1124-
the only hang catcher is the platform's own 360-minute job maximum, which
1125-
every job below carries. The native-live aggregate job names a stop at that maximum
1123+
1800 s stage bound (exit 124). Under owner #827 (2026-10-20), this repository
1124+
declares no time limits: no required-check job, stage, row, step, profile or
1125+
matrix entry may declare one, and GitHub's own 6 h platform maximum is the only
1126+
bound. The native-live aggregate job names a stop at that maximum
11261127
`HANG (re-run)` in its log; the check still fails. Exit-code, signal,
11271128
missing-summary and diagnostic failures still fail. Historically, `test_ci_verify` alone took up to 1288 s
11281129
at 0d76a099 (Ubuntu Debug), most of the 30-minute stage it then had, and a
1129-
fork's sanitizers compile took 1277-1335 s; those measurements now inform the
1130-
job-level maximum alone.
1130+
fork's sanitizers compile took 1277-1335 s; those measurements remain historical
1131+
context for job duration.
11311132

1132-
The table below reports each job's measured duration and the platform maximum
1133-
that replaced its old limit, so the margin the removal buys stays visible. The
1134-
numbers are measured durations, not a two-times multiplier.
1133+
The table below reports each job's measured duration and GitHub's platform
1134+
maximum, with the old declared limits retained for historical context; owner
1135+
#827 removed every `timeout-minutes` declaration on 2026-10-20.
1136+
The duration numbers are measurements, not declared time limits.
11351137
The standard-runner times are the eight CI runs from
11361138
main's 8cf3be58 (2026-09-24) to 0d76a099 (2026-09-25), pull requests included,
11371139
and the corpus-parity workflow's ten runs of 2026-09-22 to 2026-09-25. The
@@ -1140,9 +1142,9 @@ measurements; the standard-runner timings describe the former hosted policy
11401142
and provide historical context for the ci-spot fallback. Pool timings await
11411143
measurements on the new runners.
11421144

1143-
| Job | Limit (min) | Measured basis |
1145+
| Job | Platform maximum (min; no declared limit) | Measured basis |
11441146
| --- | --- | --- |
1145-
| `preflight` | 360 (was 45) | 7.3-9.8 min on the standard runner through 1a0e7ea1; cancelled at 10.3 min at 0d76a099, 593 s into `verifier-tests`, which takes about 15 min there at that tree (above), so preflight about 16 min. 4.8-8.2 min on the verification hosts. Preflight supplies no stage deadline -- the old 2400 s stage bound is gone (owner rule, 2026-10-12); the native-live aggregate job names a stop at the platform's 360-minute maximum `HANG (re-run)` in its log; the check still fails. |
1147+
| `preflight` | 360 (was 45) | 7.3-9.8 min on the standard runner through 1a0e7ea1; cancelled at 10.3 min at 0d76a099, 593 s into `verifier-tests`, which takes about 15 min there at that tree (above), so preflight about 16 min. 4.8-8.2 min on the verification hosts. Preflight supplies no stage deadline -- the old 2400 s stage bound is gone (owner rule, 2026-10-12), and owner #827 (2026-10-20) removed every declared job timeout; the native-live aggregate job names a stop at GitHub's own 6 h platform maximum `HANG (re-run)` in its log; the check still fails. |
11461148
| `build` | 360 (was 75) | A Release leg runs its full population on push and dispatch events; a pull request's Release legs, a fork's included, exclude the `slow` rows like its Debug legs, and that pull-request time is to be measured on real PR runs. Measured while Release ran its full population on every event, a fork's pull request included: 30.3 min Ubuntu and 32.0 min macOS on the standard runners at 0d76a099, where the full Debug legs took 43.5 and 37.0 min. Pull-request Debug sets 17.2-17.7 min. 11.1-18.4 min on the verification hosts. |
11471149
| `sanitizers` | 360 (was 120; the verifier's CTest stage bound was 60 min full, 30 min PR) | A fork's pull-request set took 35.2 min on the standard runner, whose compile alone took 1277-1335 s (pull-request run 36139176292, and main at 0d76a099). Full runs on the standard runner took 34.0-69.4 min (at 0d76a099 30 min of build and ABI providers, then 39 min of CTest, 1768 s of it the serial `test_ci_verify` row), and 18.2-19.0 min on the verification hosts. |
11481150
| `kernel-only` | 360 (was 60) | Push and dispatch events run the whole kernel set; a pull request's kernel-only leg excludes the `slow` rows, and that pull-request time is to be measured on real PR runs. Measured while every event ran the whole kernel set: 7.9-22.3 min on the standard runner, 6.5-9.8 min on the verification hosts. The hosted kernel-only run of 2026-10-12 lost its job to the old 1800 s stage bound (exit 124). |

‎scripts/ci_preflight.py‎

Lines changed: 21 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -101,22 +101,21 @@
101101
CORES = '"$(getconf _NPROCESSORS_ONLN)"'
102102
VERIFY, PARITY = 'ci_verify.py', 'check_corpus_parity.sh'
103103
PARITY_COMMAND = f'JOBS={CORES} ./scripts/{PARITY}'
104-
# Every job with a runner in the workflows a CI run starts: its runs-on, its
105-
# timeout-minutes, exactly, and the command that must carry the core count.
106-
# Every one of them is the platform's own 360-minute job maximum, the only
107-
# hang catcher left (owner rule, 2026-10-12: no time limit of this repository
108-
# may fail a run for slowness); docs/ci.md says so.
104+
# Every job with a runner in the workflows a CI run starts: its runs-on and
105+
# the command that must carry the core count. No job or step may declare
106+
# timeout-minutes: owner #827 removed every declaration on 2026-10-20.
107+
# GitHub's own 6 h platform maximum is the only bound; docs/ci.md says so.
109108
JOB_RUNNERS = {
110-
'ci.yml': {'changes': (LIGHT_RUNNER, 360, None),
111-
'preflight': (LIGHT_RUNNER, 360, None),
112-
'build': (MATRIX_RUNNER, 360, VERIFY),
113-
'sanitizers': (LINUX_RUNNER, 360, VERIFY),
114-
'kernel-only': (LINUX_RUNNER, 360, VERIFY),
115-
'build-gate': (LIGHT_RUNNER, 360, None)},
116-
'native-live.yml': {'native-live': (LINUX_RUNNER, 360, VERIFY),
117-
'native-live-gate': (LIGHT_RUNNER, 360, None)},
118-
'corpus-parity.yml': {'corpus-parity': (LINUX_RUNNER, 360, PARITY),
119-
'corpus-parity-subset': (LINUX_RUNNER, 360, PARITY)},
109+
'ci.yml': {'changes': (LIGHT_RUNNER, None),
110+
'preflight': (LIGHT_RUNNER, None),
111+
'build': (MATRIX_RUNNER, VERIFY),
112+
'sanitizers': (LINUX_RUNNER, VERIFY),
113+
'kernel-only': (LINUX_RUNNER, VERIFY),
114+
'build-gate': (LIGHT_RUNNER, None)},
115+
'native-live.yml': {'native-live': (LINUX_RUNNER, VERIFY),
116+
'native-live-gate': (LIGHT_RUNNER, None)},
117+
'corpus-parity.yml': {'corpus-parity': (LINUX_RUNNER, PARITY),
118+
'corpus-parity-subset': (LINUX_RUNNER, PARITY)},
120119
}
121120
# L6: credential-bearing deployment jobs and the entire release workflow
122121
# retain their exact pre-CR-171 hosted routing, including its older images.
@@ -426,9 +425,13 @@ def runner_findings(workflows: dict[str, str]) -> list[str]:
426425
findings.append(f'{name} job {job} must set job env PF_CI_LABELS to {labels} exactly once')
427426
if job not in timed:
428427
continue
429-
_, minutes, command = timed[job]
430-
if _job_values(body, 'timeout-minutes') != [str(minutes)]:
431-
findings.append(f'{name} job {job} must allow {minutes} minutes')
428+
_, command = timed[job]
429+
if (_job_values(body, 'timeout-minutes')
430+
or any(_step_values(step, 'timeout-minutes')
431+
or _key_value(step.splitlines()[0].lstrip()[2:],
432+
'timeout-minutes') is not None
433+
for step in _steps(body))):
434+
findings.append(f'{name} job {job} must declare no timeout-minutes (owner #827)')
432435
# Keep parallelism tied to the runner's available cores.
433436
if not _sized(_counted_text(body), command):
434437
findings.append(f'{name} job {job} must size its parallelism to the runner')

0 commit comments

Comments
 (0)