You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 7d79006
Browse filesBrowse the repository at this point in the historyBrowse files
ci: remove timeout-minutes (owner #827, no time limits) (#462)
* CI: drop timeout-minutes from ci.yml, corpus-parity.yml and native-live.yml (owner #827)
Deletion-only sweep: 10 timeout-minutes lines removed.
grep -rn timeout-minutes .github/ prints nothing; git diff --numstat shows 0 added.
Co-Authored-By: Claude Code <[email protected]>
* CI: the engine preflight requires the absence of timeout-minutes (owner #827)
The deletion commit 85d03d6 removed every timeout-minutes declaration, but
the repository's own contract still required the deleted 360-minute deadlines:
ci_preflight.py's JOB_RUNNERS carried a minutes member and runner_findings
asserted it, and test_ci_preflight.py's table asserted that a changed 360 still
fails and that removing it fails too. The preflight therefore refused the
sweep head (rj-20261020t104302-5cba28: ci-workflow-contract and preflight-tests,
10 findings "must allow 360 minutes").
Now no job or step may declare timeout-minutes. JOB_RUNNERS holds (runner,
command); runner_findings reports one finding per affected job when the job
declares it at job level, at any step level, as a step's first key, or as a
quoted key. Runner labels, PF_CI_LABELS, core-count sizing and every other
contract are unchanged, and no workflow file is touched.
The must-fail table keeps a changed value failing (360 -> 30/45/60/10) with the
new message; the removal row now passes with an empty finding list; anchors that
used the deleted line moved to `steps:`; the minutes == 360 assertion is
replaced by an assertion that the source workflows carry no timeout-minutes,
plus new coverage for job-level, step-level, first-key and quoted-key
declarations.
docs/ci.md says the repository declares no job or step time limit and GitHub's
6 h platform maximum is the only bound; measured durations stay as historical
context. check_doc_reverts names the four deleted sentences this commit
supersedes, each stated here so the deletion stays attributable:
"The native workflow retains only its 360-minute job envelopes, with no
verification-step deadline." (7da487a); "Under the owner rule, no
required-check stage, row, step, profile or matrix entry may carry a time limit
of this repository's; the only hang catcher is the platform's own 360-minute
job maximum, which every job below carries." (7da487a); "The table below
reports each job's measured duration and the platform maximum that replaced its
old limit, so the margin the removal buys stays visible." (2394ba2); "The
numbers are measured durations, not a two-times multiplier." (2394ba2).
Co-Authored-By: Claude Code <[email protected]>
---------
Co-authored-by: Claude Code <[email protected]>
Copy file name to clipboardExpand all lines: docs/ci.md
+15-13Lines changed: 15 additions & 13 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -249,8 +249,9 @@ receipts, and saving a cache cannot turn a failed verification into success.
249
249
The verifier accepts no row or stage deadline options (owner rule,
250
250
2026-10-12: no time limit may fail a run for slowness). It passes
251
251
`ctest --timeout 0` to request no default per-test deadline; an explicit
252
-
`TIMEOUT` property on a row remains untouched. The native workflow retains
253
-
only its 360-minute job envelopes, with no verification-step deadline.
252
+
`TIMEOUT` property on a row remains untouched. Under owner #827 (2026-10-20),
253
+
this repository declares no job or step time limits; GitHub's own 6 h platform
254
+
maximum is the only bound.
254
255
The summary records discovered and selected row counts, executed rows,
255
256
skipped or not-run rows, and stage timings, including when a test fails.
256
257
@@ -1119,19 +1120,20 @@ that rule removed: the `test_ci_verify` row's 3600 s property outlived main's
1119
1120
2820 s native-live stage deadline, and main's own native-live job refused its
1120
1121
row set with `TIMEOUT 3600 must be positive and less than stage deadline
1121
1122
2820`. The hosted kernel-only job lost the same day's run the other way, to a
1122
-
1800 s stage bound (exit 124). Under the owner rule, no required-check stage,
1123
-
row, step, profile or matrix entry may carry a time limit of this repository's;
1124
-
the only hang catcher is the platform's own 360-minute job maximum, which
1125
-
every job below carries. The native-live aggregate job names a stop at that maximum
1123
+
1800 s stage bound (exit 124). Under owner #827 (2026-10-20), this repository
1124
+
declares no time limits: no required-check job, stage, row, step, profile or
1125
+
matrix entry may declare one, and GitHub's own 6 h platform maximum is the only
1126
+
bound. The native-live aggregate job names a stop at that maximum
1126
1127
`HANG (re-run)`in its log; the check still fails. Exit-code, signal,
1127
1128
missing-summary and diagnostic failures still fail. Historically, `test_ci_verify` alone took up to 1288 s
1128
1129
at 0d76a099 (Ubuntu Debug), most of the 30-minute stage it then had, and a
1129
-
fork's sanitizers compile took 1277-1335 s; those measurements now inform the
1130
-
job-level maximum alone.
1130
+
fork's sanitizers compile took 1277-1335 s; those measurements remain historical
1131
+
context for job duration.
1131
1132
1132
-
The table below reports each job's measured duration and the platform maximum
1133
-
that replaced its old limit, so the margin the removal buys stays visible. The
1134
-
numbers are measured durations, not a two-times multiplier.
1133
+
The table below reports each job's measured duration and GitHub's platform
1134
+
maximum, with the old declared limits retained for historical context; owner
1135
+
#827 removed every `timeout-minutes` declaration on 2026-10-20.
1136
+
The duration numbers are measurements, not declared time limits.
1135
1137
The standard-runner times are the eight CI runs from
1136
1138
main's 8cf3be58 (2026-09-24) to 0d76a099 (2026-09-25), pull requests included,
1137
1139
and the corpus-parity workflow's ten runs of 2026-09-22 to 2026-09-25. The
@@ -1140,9 +1142,9 @@ measurements; the standard-runner timings describe the former hosted policy
1140
1142
and provide historical context for the ci-spot fallback. Pool timings await
1141
1143
measurements on the new runners.
1142
1144
1143
-
| Job | Limit (min) | Measured basis |
1145
+
| Job | Platform maximum (min; no declared limit) | Measured basis |
1144
1146
| --- | --- | --- |
1145
-
| `preflight` | 360 (was 45) | 7.3-9.8 min on the standard runner through 1a0e7ea1; cancelled at 10.3 min at 0d76a099, 593 s into `verifier-tests`, which takes about 15 min there at that tree (above), so preflight about 16 min. 4.8-8.2 min on the verification hosts. Preflight supplies no stage deadline -- the old 2400 s stage bound is gone (owner rule, 2026-10-12); the native-live aggregate job names a stop at the platform's 360-minute maximum `HANG (re-run)` in its log; the check still fails. |
1147
+
| `preflight` | 360 (was 45) | 7.3-9.8 min on the standard runner through 1a0e7ea1; cancelled at 10.3 min at 0d76a099, 593 s into `verifier-tests`, which takes about 15 min there at that tree (above), so preflight about 16 min. 4.8-8.2 min on the verification hosts. Preflight supplies no stage deadline -- the old 2400 s stage bound is gone (owner rule, 2026-10-12), and owner #827 (2026-10-20) removed every declared job timeout; the native-live aggregate job names a stop at GitHub's own 6 h platform maximum `HANG (re-run)` in its log; the check still fails. |
1146
1148
| `build` | 360 (was 75) | A Release leg runs its full population on push and dispatch events; a pull request's Release legs, a fork's included, exclude the `slow` rows like its Debug legs, and that pull-request time is to be measured on real PR runs. Measured while Release ran its full population on every event, a fork's pull request included: 30.3 min Ubuntu and 32.0 min macOS on the standard runners at 0d76a099, where the full Debug legs took 43.5 and 37.0 min. Pull-request Debug sets 17.2-17.7 min. 11.1-18.4 min on the verification hosts. |
1147
1149
| `sanitizers` | 360 (was 120; the verifier's CTest stage bound was 60 min full, 30 min PR) | A fork's pull-request set took 35.2 min on the standard runner, whose compile alone took 1277-1335 s (pull-request run 36139176292, and main at 0d76a099). Full runs on the standard runner took 34.0-69.4 min (at 0d76a099 30 min of build and ABI providers, then 39 min of CTest, 1768 s of it the serial `test_ci_verify` row), and 18.2-19.0 min on the verification hosts. |
1148
1150
| `kernel-only` | 360 (was 60) | Push and dispatch events run the whole kernel set; a pull request's kernel-only leg excludes the `slow` rows, and that pull-request time is to be measured on real PR runs. Measured while every event ran the whole kernel set: 7.9-22.3 min on the standard runner, 6.5-9.8 min on the verification hosts. The hosted kernel-only run of 2026-10-12 lost its job to the old 1800 s stage bound (exit 124). |
0 commit comments