You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 783bb39
Browse filesBrowse the repository at this point in the historyBrowse files
Apply syminfo.mincontract as the engine's lot grid in the Docker harness (#322)
* Apply syminfo.mincontract as the engine's lot grid in the Docker harness
The harness applied only mintick, pointvalue, timezone and session from the
--syminfo file, so a percent-of-equity strategy traded sub-lot quantities that
the instrument does not allow. A positive finite mincontract is now set as the
engine's qty_step metadata (order quantities are floored to it) and as the
mincontract metadata, before the other setters. Absent or null changes
nothing; any other value, or a library without the metadata setter, fails the
run with the structured error line, which shows the value's JSON text. An
applied grid is recorded as applied_runtime.syminfo and so in the fingerprint.
pineforge-release vendors docker/run_json.py from the engine tag at every
release, so the change has to live here to reach a published image: this is
the same file as pineforge-release#21, whose copy the next sync overwrites.
docker/README.md, the docker/entrypoint.sh header comment and CHANGELOG.md
document it; docker/run_json_syminfo_test.py covers it.
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
* Address review of the lot-grid harness change
Tests: restore the checks the port from pineforge-release dropped (SyminfoError
is a ValueError; the grid sits in the digested token bytes in canonical form and
the plain token has no syminfo) and pin the recorded grid to floats, so an
integer mincontract is not recorded as an int.
Docs: the error text shows the parsed value re-encoded as JSON, not the file's
text; a file that is not JSON or not an object still ends in a traceback; a
library without the metadata setter fails the run only when mincontract is set
(CHANGELOG); the PINEFORGE_SYMINFO row leaves the "runtime args" table (it is
applied through the syminfo setters and has its own section); the extra-keys
object is named plainly.
docker/run_json.py and docker/entrypoint.sh are unchanged.
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
---------
Co-authored-by: Claude Sonnet 5.5 <[email protected]>
0 commit comments