Skip to content

Commit 6b77f06

Browse files
luisleo526claude
andauthored
Pine adapter: admission fill half on, close-first entries, point order, exit tombstones, pyramiding records (#335)
TradingView admits an order in two halves: rules 2 and 5 at the signal close, then one price-scale check at the fill. This change turns the fill half on and adds the TradingView behaviours that the fixtures under tests/fixtures/admission_rules pin. Each rule has its own internal switch in MarginRuleSwitches. All switches are on, and only tests change one. - unified_placement: the placement half, split out of fill_price_recheck. A reversal that rule 5 refuses stays placed, marked signal_price_refused. It drops at its fill, and the script's later close of the held id stays an ordinary close. - fill_price_recheck, now on: the whole order drops iff sig10(sig10(E_signal) / (Q m)) is under the slipped tick-built fill quote. The tie band is removed. Inside the unified scope, the explicit market long's money check on the unslipped next-bar quote is never reached. - close_first_admission: an entry the script placed on the same bar behind its own strategy.close(<held id>) or strategy.close_all() of the position it opposes is checked by rule 2 only. - It fills flat with its frozen quantity. - The fact is recorded once, at the close or close_all call, and stamped on the entry at its entry() call. - point_fills_before_margin: at the open, the queued orders execute first, then the exits the open reaches, then the margin check on what is left. Two kinds of order fill before that check: - a protective strategy.exit stop or limit that the opening print reaches and whose entry holds units of the position; an exit armed for an entry that holds nothing fills nothing there. from_entry_units, the units an exit's entry holds, is shared with the process_orders_on_close bracket ranking in flush_pending_bracket_legs, whose inert exit also needs an entry with no working order; each site keeps its own test; - a close the script placed ahead of its opposite entry. Two shapes keep the earlier order: - A process_orders_on_close short's call sized at the previous close, while the open does not re-size it, is a queued order, so it executes before a stop the open gaps through (TradingView's tape of axealgo-tp-sl-toolkit-axealgo on OANDA:XAUUSD: the call of 1, then the stop's 1.62). A call the open re-sizes is the open's own check, after the exits; no tape decides that shape yet. - A partial exit fills first only when what it leaves is margined; a remainder still short keeps the call at the open first. No tape decides that case yet. test_point_order_open_call pins both shapes, each with a control. - exit_child_tombstones: a partial exit child that filled is never revived for the entry incarnation it filled under. - pyramiding_ledger_records: under pyramiding above one, the cap counts the open close-ledger records, one per entry fill not yet booked, not the physical lots. An exit armed for one opening books that opening first. Every rule runs only on a power-of-ten lot grid, which every tape and every population member uses. The unified admission also leaves out calc_on_order_fills, the bar magnifier, stops that reverse, default-sized stops, a resting book and same-open pairs; those keep the earlier rules. New durable state is folded into the source-adapter hash only while it is set. Three rules are left out, because nothing tells them apart from the current behaviour. Decision counters ran over every ctest fixture and 198 replayed population scripts and found no divergence: - the commission-0 POOC unit: 23,510 calls; - the whole-book add at the signal close: 413 calls; - the lagged follow-up on whole-share grids: 1 call. docs/pine-adapter-kernel-notes.md section 1.8 names the TradingView control each one needs. Fixtures: - tests/fixtures/admission_rules: 73 TradingView tapes in four groups, gap_admission, point_order_and_book, stop_priority and explicit_short. - The engine reproduces all 73, and 56 of the 59 NYSE:F tapes book the same trades as a backtest and as a stream; the other three cross a holiday that a stream takes as an in-session gap. - Each of the six rules above loses tapes when turned off alone. - test_qty_step_lot_grid_case, the hosted lot-grid case, still books every recorded row exactly, with and without the 1e-05 grid. - The explicit-short twin control in test_taro_price_gap_admission_l4d is re-pinned on TradingView's own tape of it (explicit_short/offset0-fill). TradingView fills that order, so its literal check moves to the -.00032 offset, where the order is declined. - The margin_call_rules, margin_ledger_rules and forward-replay lists drop the entries the fill half now reproduces. - test_integer_flat_budget_tie_l4d asserts the one row it moves. On a 0.01 lot grid, rule 2 drops a default long from flat one ulp under the cost, as TradingView's margin_ledger_rules tape eth-flat-m100-ulp-under does. The witness tables move on hash fields only. Every closed trade of every run-pass is identical, field for field, to the parent commit's. The margin-rules notes said the unified admission ships off; it now ships on, so these sentences of docs/pine-adapter-kernel-notes.md are replaced: - "Two narrowings keep the scraped population's orders on the earlier rules" - "Outside that scope the engine's earlier admission rules run unchanged." - "The tree ships this unified admission off" - "gates it whole, its fill half and the placement half's reach" - "With it on, the scraped population lost orders" - "keeps the earlier scopes: an explicit quantity from flat" - "With the shipped switches the engine reproduces 170" - "The tests list 3 single-position and 104 ledger tapes" - "The fill re-check, and with it the unified admission" - "On the scraped population it dropped reversals and openings" - "The tapes pin the check only at a one-tick" Co-authored-by: Claude Opus 5.5 (1M context) <[email protected]>
1 parent 7afba5c commit 6b77f06

361 files changed

Lines changed: 8900 additions & 711 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎docs/adr/0001-kernel-adapter-boundary.md‎

Lines changed: 19 additions & 19 deletions
Large diffs are not rendered by default.

‎docs/design/native-feature-parity.md‎

Lines changed: 79 additions & 79 deletions
Large diffs are not rendered by default.

‎docs/native-refactor-progress.md‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ them for the record only. "Linux aarch64" is the maintainers' Cortex-A725 host.
173173

174174
| Item | What it is | Measured size | Deferred by | Prototype and evidence | Reopens when |
175175
| --- | --- | --- | --- | --- | --- |
176-
| D2-B, the quiet-bar protocol and one receipt read per bar | PERF-D2's lane: a per-bar bar-open request, a bulk fold of quiet driver points, the adapter's quiet-open predicate with lazy open bookkeeping, and a gate before the receipt poll. D2-A landed the hook declarations and the O(1) `has_command_after` (`src/native_execution_consumer.hpp:269`). PERF-L4 gated the read inside `observe_terminal_receipts` (`src/source/pine_adapter.cpp:6012`), which still runs about three times a bar | PERF-D2, Linux aarch64 (Cortex-A725), callgrind and GBench: about ×0.88 on the 14 probes (an estimate from a measured −13 to −14 % floor bound for the bar-open request alone); after PB the receipt poll still costs about 250 instructions a bar on the no-order floor. On this tree the quiet-bar probe asks the receipt gate 40,996 times and each once-per-bar-open gate 13,248 times: 3.09 reads a bar, 82 % of them stopped at the gate (macOS arm64, AppleClang 17, Release) | "R5 PERF-D2 DONE 2026-09-24 19:56" (D2-B after V19-D); "R5 SUPERVISOR RULING 2026-09-25 00:15 Taipei": "D2-B (quiet-bar protocol) waits for PERF-D3's verdict"; TRIAGE1 §D | An unpublished prototype branch and its patches. PERF-D3's S1 (next row) prototyped the request and the lazy opening | A post-release performance epoch. Done when the receipt gate is asked as often as the once-per-bar gates |
176+
| D2-B, the quiet-bar protocol and one receipt read per bar | PERF-D2's lane: a per-bar bar-open request, a bulk fold of quiet driver points, the adapter's quiet-open predicate with lazy open bookkeeping, and a gate before the receipt poll. D2-A landed the hook declarations and the O(1) `has_command_after` (`src/native_execution_consumer.hpp:269`). PERF-L4 gated the read inside `observe_terminal_receipts` (`src/source/pine_adapter.cpp:6031`), which still runs about three times a bar | PERF-D2, Linux aarch64 (Cortex-A725), callgrind and GBench: about ×0.88 on the 14 probes (an estimate from a measured −13 to −14 % floor bound for the bar-open request alone); after PB the receipt poll still costs about 250 instructions a bar on the no-order floor. On this tree the quiet-bar probe asks the receipt gate 40,996 times and each once-per-bar-open gate 13,248 times: 3.09 reads a bar, 82 % of them stopped at the gate (macOS arm64, AppleClang 17, Release) | "R5 PERF-D2 DONE 2026-09-24 19:56" (D2-B after V19-D); "R5 SUPERVISOR RULING 2026-09-25 00:15 Taipei": "D2-B (quiet-bar protocol) waits for PERF-D3's verdict"; TRIAGE1 §D | An unpublished prototype branch and its patches. PERF-D3's S1 (next row) prototyped the request and the lazy opening | A post-release performance epoch. Done when the receipt gate is asked as often as the once-per-bar gates |
177177
| S1a, kernel quiet-bar driving (PERF-D3) | A bar with nothing live, a flat book and a declined opening is driven in a quiet form: the kernel writes the bookkeeping its four price points would leave (ordinals, the last two driver marks, the floor, the point epochs) without walking them or calling the bar-open callback. Additive host cadence declarations; C hosts declare from their callback table; one C symbol under the PF_API checklist | PERF-D3, Linux aarch64 (Cortex-A725), GBench time and `perf stat` instructions, on the L3 tree `b33ea659`, S1a with S1b: no-order floor 0.764 / 0.660 in time (0.718 / 0.656 in instructions), 14 probes 0.958 / 0.921 (0.892 / 0.856), 100 slots 0.972 / 0.956 per slot. A bare kernel host that opts in: idle 0.545× (35 % fewer instructions a bar), market 0.81×, bracket 0.92×. Byte-identical: corpus 312/312, the 132-configuration battery with its hash columns | "FINDING PERF-D3 (filed for a post-release epoch per the owner's cap)" (ledger, 2026-09-24 16:58 UTC); "OWNER DECISION 2026-09-25 00:20 Taipei"; TRIAGE1 §D: "PERF-D3 S1/S2 (post-release epoch)" | An unpublished prototype branch (five commits on L3's tree) and its patches | The post-release epoch, with the owner calls PERF-D3 lists (the API under the existing ruling, the restated gate count) |
178178
| S1b, the Pine lazy opening | The Pine host records what its skipped opening and its uncalled input callback would have written, at the bar's first host callback. Member functions only, no layout change | Measured with S1a. A quiet bar then asks 15 gates, not 30, so the quiet-bar cost check `CHECK(asked >= 20 * o.boundary.size())` (`tests/test_adapter_quiet_bar.cpp:1054`) must be restated | As S1a | As S1a. The in-script hash witnesses caught the prototype's one miss (`awaiting_legacy_script_open_ms_`) | As S1a |
179179
| S1c, the held-position wake band | S1 for bars that hold a position with nothing live, 41 % of the median public slot's bars. The host declares a price band, and the kernel calls the opening only when the bar's range leaves it. The adapter derives the band from its margin model and declines when it cannot bound it | PERF-D3, a measurement-only upper bound without the band, which is not sound in general: 100 slots 0.776 / 0.716 per slot, 14 probes 0.830 / 0.761, cumulative against L3 with S1, S2 and D2-A | As S1a; the owner call "Fund the price band" | An unpublished measurement-only script | As S1a. Size L, parity risk high: TradingView's margin money rules |
@@ -183,7 +183,7 @@ them for the record only. "Linux aarch64" is the maintainers' Cortex-A725 host.
183183
| Compact journal records and a history ring buffer (L3) | Smaller command records and a ring buffer for the request core's history. `WorkingRequestCore::history` (`include/pineforge/native_order.hpp:1709`) hands out the whole vector and the core holds `history_` (`include/pineforge/native_order.hpp:2197`) inside `native_order_v7`, so both are a layout and API change | L3, Linux aarch64 (Cortex-A725), `perf` call graphs, inclusive shares: at most 3.68 % of bracket, 11.99 % of re-issue, 4.26 % of market and 3.42 % of the 14 probes (retiring the history alone: 1.64, 4.51, 2.53 and 1.00 %); only part is realisable, since records must still be written | "R5 L3 DONE + ACCEPTED 2026-09-24 22:10 Taipei", ruling 1: "DEFERRED to the PERF-D3 structural plan"; TRIAGE1 §D: "compact journal records" | Lane L3's code, merged by INT22 (#285); its profiles are unpublished | A `native_order` layout epoch |
184184
| A checked-values handoff for executions (L3) | `execution_values` runs twice, in `check_execution` (`src/native_order.cpp:4791`) and again in `apply_execution` (`src/native_order.cpp:4805`); handing the checked values across needs a public type, an API addition with no layout change | L3, as above: 2.21 % of bracket for the two together, about 1.1 % recoverable | L3 ruling 2: "a public checked-values handoff for executions (~1.1% bracket) -> DEFERRED" | As above | An owner decision on the API addition |
185185
| A chunked `trades_` store (L3) | Closed trades in chunks rather than one vector; `trades_` (`include/pineforge/engine.hpp:546`) is protected `BacktestEngine` state, so script ABI | L3, as above: on bracket, vector growth 0.64 %, `Trade` moves 0.74 % and `record_close_trade` 0.43 % (at most about 1.4 %); at most 0.35 % on the 14 probes | L3 ruling 4: "chunked trades_ store (ABI) -> DEFERRED" | As above | An `engine_script_run` epoch that changes the engine's protected layout |
186-
| A zoned chart-day memo (D2-D finding 4) | On a chart with a timezone, `libc_chart_day_key` (`src/source/pine_adapter.cpp:16106`) takes the process timezone lock through `ScopedTimezone` and calls `localtime_r` on every bar, because `on_bar_open` (`src/source/pine_adapter.cpp:19793`) reads `chart_day_key` (`src/source/pine_adapter.cpp:20014`) unconditionally. The non-UTC monthly Sharpe/Sortino walk, `month_key_local` (`src/engine_metrics.cpp:33`), pays one `localtime_r` per equity point. UTC charts use D2-D's memo, `civil_chart_day_key` (`src/source/pine_adapter.cpp:16090`) | Not measured on a zoned chart. The UTC path cost 134 instructions a bar before D2-D's memo and 68 after (D2-D, Linux aarch64, callgrind on the floor). PERF-K1: `ScopedTimezone` copies the zone name, which allocates for names of 16 or more characters under libstdc++ | TRIAGE1 §D: "D2-D finding 4 (the timezone `localtime_r` memo)", under the owner's cap. D2-D's report: an exact zoned memo "would need the zone's transition table, which belongs in `timezone.cpp`" | None; the UTC memo's witness is `tests/test_chart_day_memo.cpp` | A lane that owns `src/timezone.cpp` and builds an exact zone-transition memo (PERF-K1's Sitka case shows why a shortcut is not exact), byte-identical, with the zoned keys of `test_chart_day_memo` still equal to the computed ones |
186+
| A zoned chart-day memo (D2-D finding 4) | On a chart with a timezone, `libc_chart_day_key` (`src/source/pine_adapter.cpp:16314`) takes the process timezone lock through `ScopedTimezone` and calls `localtime_r` on every bar, because `on_bar_open` (`src/source/pine_adapter.cpp:20036`) reads `chart_day_key` (`src/source/pine_adapter.cpp:20257`) unconditionally. The non-UTC monthly Sharpe/Sortino walk, `month_key_local` (`src/engine_metrics.cpp:33`), pays one `localtime_r` per equity point. UTC charts use D2-D's memo, `civil_chart_day_key` (`src/source/pine_adapter.cpp:16298`) | Not measured on a zoned chart. The UTC path cost 134 instructions a bar before D2-D's memo and 68 after (D2-D, Linux aarch64, callgrind on the floor). PERF-K1: `ScopedTimezone` copies the zone name, which allocates for names of 16 or more characters under libstdc++ | TRIAGE1 §D: "D2-D finding 4 (the timezone `localtime_r` memo)", under the owner's cap. D2-D's report: an exact zoned memo "would need the zone's transition table, which belongs in `timezone.cpp`" | None; the UTC memo's witness is `tests/test_chart_day_memo.cpp` | A lane that owns `src/timezone.cpp` and builds an exact zone-transition memo (PERF-K1's Sitka case shows why a shortcut is not exact), byte-identical, with the zoned keys of `test_chart_day_memo` still equal to the computed ones |
187187
| Thread-local reads that remain per call | D2-C moved the three scopes' writes onto the pump's block, `pump_ambient` (`src/native_execution_consumer.hpp:444`). A reader still reaches the block through `tl_runtime_ambient` (`src/ta_extremes_volume.cpp:29`): `bar_context` (`src/ta_extremes_volume.cpp:82`), read by every `ExtremeRing::update` (`src/ta_extremes_volume.cpp:117`), which backs `ta.highest`, `ta.lowest`, `ta.highestbars` and `ta.lowestbars` and, through an embedded `Highest` and `Lowest`, `ta.stoch`, `ta.wpr` and `ta.range`; and `matching_day_partition` (`src/timeframe.cpp:605`), read by the default-anchored `ta.vwap` through `session_day_index`, by `crosses_boundary` on a DAY period (`timeframe.change("D")`) and by the session-period helpers. `decompose_ms_local` (`src/session_time.cpp:250`) reads two thread-locals per call on a zoned clock, and the prepared order storage's `free_blocks` (`src/native_order.cpp:605`) one per prepared mutation. `ema_na_warmup_flag` is read once per EMA, at its first compute | One thread-local access per reader call. AUDIT4, macOS arm64, a dlopen'd tutorial-MACD probe, counted by `_tlv_get_addr` breakpoints and by descriptor patching: 1.000 a bar for one `ta::Highest` and for one default `ta::VWAP`, 1.999 for one `pine_hour` on a New York clock, 0.000 on the no-order floor and with orders. On Linux a TLS-descriptor call costs about 20 instructions: D2-C's 13 → 4 calls a bar was 260 → 80 instructions (Linux aarch64, GCC 13, callgrind). INT23: 2.00 a bar on the zoned probe 064, 0.08 on probe 008 | None for the TA and day-partition readers: "RULING: INT23 ACCEPTED" (ledger, 2026-09-24 23:30 UTC) reads "dlopen TLS 13->0/bar", and INT23's report names only the timezone and order-core residuals. This row is their record | Unpublished (AUDIT4's scratch) | A byte-identical lane that hands these readers the pump's block without a thread-local read. `ta::bar_context()` is script ABI, so its public declaration stays as it is |
188188
| "audit-off mode", "LTO", "data-oriented layout" | Named in "OWNER DECISION 2026-09-25 00:20 Taipei" among the post-release structural items: "S1 bulk quiet bars, S2 per-strategy specialization, audit-off mode, LTO+PGO, data-oriented layout". No engine or campaign document defines, designs or measures the three | None | The owner decision | None | Struck from this inventory until a design note defines one of them |
189189

@@ -199,7 +199,7 @@ unless the retention is Full, and `presize_logs`
199199
(`src/native_execution_consumer.cpp:9460-9471`) sizes no journal under Window.
200200
`NativeRunSpec::event_retention` (`include/pineforge/native_run_spec.hpp:714`)
201201
defaults to Window, and the Pine adapter declares
202-
`NativeEventRetention::Window` (`src/source/pine_adapter.cpp:2701`). K4 still
202+
`NativeEventRetention::Window` (`src/source/pine_adapter.cpp:2705`). K4 still
203203
sizes Full runs (driver log and journal) and Commands runs (journal), and its
204204
witness, `tests/test_native_batch_log_presize.cpp`, runs under Full. PERF-K24's
205205
replay figure (14.9 % less CPU on Linux aarch64) describes the tree before V19-B. In
@@ -210,7 +210,7 @@ or more, and the same run under Full holds 66,000 points in one block of
210210
**PERF-L4 reads the receipts about three times a bar, not once.** PERF-L4's
211211
brief asked it to "read the receipts ONCE per bar instead of three times". The
212212
lane gated the read instead: `observe_terminal_receipts`
213-
(`src/source/pine_adapter.cpp:6012`) returns at its receipt gate when no
213+
(`src/source/pine_adapter.cpp:6031`) returns at its receipt gate when no
214214
command lies above its cursor. `every_gate_is_taken_both_ways`
215215
(`tests/test_adapter_quiet_bar.cpp:1061`) prints
216216
`gate ReceiptRead asked 40996 quiet 33552 live 7444`, against `asked 13248`
@@ -241,7 +241,7 @@ Mac's 489 and 412 and 1003 of 1249, and no Mac output moved.
241241

242242
- **PERF-L4's retired reader slots.** `event_high_water_reader_` and
243243
`terminal_receipt_high_water_reader_`
244-
(`include/pineforge/source/pine_adapter.hpp:2108-2109`), with their type
244+
(`include/pineforge/source/pine_adapter.hpp:2136-2137`), with their type
245245
`ReceiptHighWaterReader`, are storage nothing reads or writes since PERF-L4:
246246
they keep `PineExecutionAdapter`'s layout, which is part of
247247
`PineStrategyHost`'s and so of the generated script's ABI. They go at the next

‎docs/pages/market-admission.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ broker `OpeningReceipt` Check/Exempt decision, which belongs to a committed fill
2525
Three historical placement views are fixed when an order is placed and kept in
2626
the adapter's placement snapshot (`projection_after_close`,
2727
`projection_over_pyramiding`, `projection_opposite_market_predecessor`
28-
pine_adapter.hpp:269-271):
28+
pine_adapter.hpp:280-282):
2929

3030
- The prior-close view compares the original accepted-close
3131
quantity with the existing quantity tolerance. This describes a source-time

‎docs/pages/native-engine.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1496,7 +1496,7 @@ adapter answers `margin_check_allowed` with TradingView's scheduling — which
14961496
includes the post-exit re-size: when a priced bracket leg of the script bar
14971497
fills, the slice resting at that bar's adverse extreme was sized on the
14981498
pre-exit book, and the legacy broker cancelled and re-scheduled it there
1499-
(`margin_check_allowed` `pine_adapter.cpp:16540-16573`), so the adapter admits
1499+
(`margin_check_allowed` `pine_adapter.cpp:16748-16781`), so the adapter admits
15001500
the kernel's own point for that driver point while (and only while) a slice
15011501
rests —
15021502
`resolve_margin_requirement` with its ten-significant-digit money and

0 commit comments

Comments
 (0)