You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 6aa1d13
Browse filesBrowse the repository at this point in the historyBrowse files
runtime: wire syminfo.pointvalue through all money paths; hold ScopedTimezone lock for full scope
- O2: pointvalue now multiplies open_profit, percent/cash sizing,
percent commission, margin admission, and trade accessors
(default 1.0 — crypto corpus bit-identical; pv=50 scaling test added)
- O6: ScopedTimezone held its mutex only inside the ctor; now RAII-held
for the full scope (concurrency regression test added)
- docs: refresh stale coverage.md claims (19 C-ABI symbols, int64/source
getters, VWAP bands, intraday-cap key, risk gates, TA file layout);
mark input.source/input.color resolved in audit master
- corpus: bump submodule to regenerated generated.cpp (parity unchanged:
245 excellent + 1 known anomaly)
Co-authored-by: Cursor <[email protected]>
-**#28`input.time`** — RESOLVED. Engine [pineforge-engine#22](https://github.com/pineforge-4pass/pineforge-engine/pull/22) added `get_input_int64`; codegen [#15](https://github.com/pineforge-4pass/pineforge-codegen/pull/15) routes `input.time` to it (Pine v6 returns `series int` Unix-ms; old `get_input_int` int32 overflowed).
32
32
-**Drawing-var dangling-identifier minor** — RESOLVED. codegen [#16](https://github.com/pineforge-4pass/pineforge-codegen/pull/16) tracks omitted drawing-typed UDT fields (`_udt_omitted_fields`) and rewrites reads to `/* drawing field omitted */ 0` / strips writes (closes codegen issue #10).
33
-
-**#26 / #27`input.color` / `input.source`** — remaining codegen-helper work tracked by [pineforge-engine#23](https://github.com/pineforge-4pass/pineforge-engine/issues/23)(`get_input_source` + `get_input_color` engine helpers) and codegen issue #9.
33
+
-**#26 / #27`input.color` / `input.source`** — RESOLVED (verified against pineforge-codegen source 2026-06-10, commit `64fc886` "input.source series binding, packed-color defval"). Engine ships `get_input_source(title, default_series) → const Series<double>&` and codegen emits `get_input_source("title", _src_<field>_)[0]` for `input.source`; `input.color` routes to `get_input_int64` with a packed-ARGB defval, so the `get_input_color` engine helper contemplated by [pineforge-engine#23](https://github.com/pineforge-4pass/pineforge-engine/issues/23)was deemed unnecessary.
34
34
35
35
## Critical issues — consolidated by class
36
36
@@ -92,8 +92,8 @@ Identifier resolves to a different runtime symbol than spec.
92
92
93
93
| # | Identifier | Doc claim | Reality |
94
94
|---|---|---|---|
95
-
| 26 |`input.color()`|`get_input_string()` + color parse |**[PARTIAL RESOLVED 2026-05-29, PR codegen#13]** Analyzer now requires defval to be `color.<const>` / `color.new(...)` / `color.rgb(...)`; rejects arbitrary expressions. Codegen still emits `get_input_int` (engine has no `get_input_color` helper — full fix is cross-repo follow-up). |
96
-
| 27 |`input.source()`| series source |**[BLOCKED]** Codegen still emits `get_input_double` → frozen scalar (verified Phase C investigation: `current_bar_.close` captured once at call site). Fix requires new `get_input_source(name, default_series) → const Series<double>&` helper in pineforge-engine; tracked as cross-repo follow-up on codegen issue #9. |
95
+
| 26 |`input.color()`|`get_input_string()` + color parse |**[RESOLVED — verified vs codegen source 2026-06-10]** Analyzer requires defval to be `color.<const>` / `color.new(...)` / `color.rgb(...)` (PR codegen#13); codegen now emits `get_input_int64` with a packed-ARGB defval (`0xAARRGGBB` overflows int32, hence int64). A dedicated engine `get_input_color` helper (engine issue #23) was deemed unnecessary. |
96
+
| 27 |`input.source()`| series source |**[RESOLVED — verified vs codegen source 2026-06-10]** Engine ships `get_input_source(name, default_series) → const Series<double>&`; codegen emits `get_input_source("title", _src_<field>_)[0]` against the engine's always-materialized native source series (no more frozen scalar). Remaining engine issue #23 scope (`get_input_color`) deemed unnecessary — see #26. |
| 29 |`color.rgb()`| optional `transp` arg |**[RESOLVED — false-positive in original audit]** Verified `visit_call.py:1095-1098` correctly passes `args[3]` as transparency in the 4-arg form; 3-arg fallback defaults to 0. Original audit claim was wrong. |
1.**`input.source` / `input.color` series-/color-aware emission** (#26, #27, codegen issue #9): cross-repo blocker — needs `get_input_source(name, default_series) → const Series<double>&`and `get_input_color` helpers in pineforge-engine. Tracked by [pineforge-engine#23](https://github.com/pineforge-4pass/pineforge-engine/issues/23). `input.source` currently produces a frozen scalar.
197
+
1.~~**`input.source` / `input.color` series-/color-aware emission** (#26, #27, codegen issue #9)~~ — RESOLVED (verified vs codegen source 2026-06-10): engine `get_input_source` landed and codegen binds `input.source` to the native source series; `input.color` uses packed `get_input_int64` (the `get_input_color` helper from [pineforge-engine#23](https://github.com/pineforge-4pass/pineforge-engine/issues/23) deemed unnecessary).
198
198
2.**Remaining class A items** — #5 (`extend.*, font.*, hline.*, ...` namespaces) and #6 (`color.from_gradient`) still emit `std::string("<member>")` or hardcoded `0`. Same rejection pattern applies.
199
199
3.**Class H #35** — `barmerge.*` / `alert.freq_*` as free expressions still emit `std::string(...)` typed as INT. Same fix pattern as #36/#37.
200
200
4.**Doc** — refresh `pine_v6_coverage_detail.md` bucket assignments now that rejections moved several identifiers from "✅ Runtime" or "❓ Unknown" to "❌ Unsupported (loud reject)".
0 commit comments