Repository navigation
Commit 4f2a475
Install other symbols' bars for request.security in the Docker harness (--symbol-feeds) (#327)
* Install other symbols' bars for request.security in the Docker harness
docker/run_json.py --symbol-feeds (PINEFORGE_SYMBOL_FEEDS in the entrypoint)
reads a JSON index of other symbols' bars, keyed by the exact symbol string a
script passes to request.security and by timeframe, and installs each symbol's
catalog syminfo (tickerid as canonical, type, timezone, session, currency,
mintick) and feeds through strategy_set_symbol_facts and
strategy_set_symbol_feed, which engine and codegen have shipped since 1.0.0
but no release harness called. A feed is an OHLCV CSV like --ohlcv; each
bar's close is its open plus the timeframe unless a time_close column gives it.
Everything is checked before the first strategy state: timeframe spelling
(bare D/W/M/S folded, "4h" refused), one feed per timeframe, CSV columns and
numbers, increasing opens, closes at or before the next open, mintick, the
256-feed cap. A refusal, a library without the setters or a feed the engine
refuses is the structured {"engine","error"} line (harness exit 1, entrypoint
exit 4), like a rejected --syminfo. What was installed is recorded as
applied_runtime.symbol_feeds (facts, bar counts, first/last open, a value
hash), so such a run has its own fingerprint; without --symbol-feeds the
report is unchanged.
Stacked on harness/syminfo-mincontract (#322): it reuses that change's
structured-failure path in main().
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
* Address review of the symbol-feeds harness change
- Every refusal is the structured line, never a traceback: a feed that is not
UTF-8 (or a CSV error), a time outside +-(2^53-1) ms or a monthly close
outside the calendar, a mintick integer beyond binary64, a symbol or fact
string with a lone surrogate, an index nested past the recursion limit.
- A header-only feed is installed without bars, as the engine documents it
(its requests read na), instead of refused.
- An empty time_close cell falls back to open plus timeframe; a UTF-8 BOM is
read; error line numbers are the CSV's own (blank lines counted).
- Install-time refusals carry the same "--symbol-feeds:" prefix.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
* Document the symbol-feed limits and that no feed is aggregated
The harness README gains a limits bullet (256 symbols and 256 feeds, the chart
as its own input with the engine's exact error, historical runs only, the cost
of a feed, request.security_lower_tf) and states that a feed must be at the
timeframe it serves: the engine aggregates only the chart's own input and the
C ABI has no call that aggregates bars, so a 1m feed serves neither a 240 nor a
D request. The CHANGELOG entry says the same.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
* Correct the symbol-feeds README on syminfo reads and aggregation
Review fixes. Inside the request syminfo.tickerid is always the key and
syminfo.ticker the key after its last ":"; the catalog tickerid is set as the
canonical fact, which no syminfo.* reads. The no-aggregation bullet now says
why (the engine looks a feed up by exact symbol and timeframe and installs its
bars as given) instead of claiming no C call aggregates. The missing-feed
sentence covers an index that lacks the requested symbol or timeframe, and the
refusal list is marked as examples ("timestamps that do not strictly
increase").
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
* Place the symbol-feeds CHANGELOG entry after the confirmed-bar streams one
After the rebase onto #325 the entry sat at the top of Unreleased; it now
follows #325's entry, as the merge order asks. Wording unchanged.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
---------
Co-authored-by: Claude Opus 5.5 (1M context) <[email protected]>1 parent 7b59662 commit 4f2a475
5 files changed
Lines changed: 847 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
34 | 47 | | |
35 | 48 | | |
36 | 49 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
172 | 172 | | |
173 | 173 | | |
174 | 174 | | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
175 | 257 | | |
176 | 258 | | |
177 | 259 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
46 | 54 | | |
47 | 55 | | |
48 | 56 | | |
| |||
140 | 148 | | |
141 | 149 | | |
142 | 150 | | |
| 151 | + | |
143 | 152 | | |
144 | 153 | | |
145 | 154 | | |
146 | 155 | | |
147 | 156 | | |
148 | 157 | | |
| 158 | + | |
149 | 159 | | |
150 | 160 | | |
151 | 161 | | |
| |||
0 commit comments