Repository navigation
Commit 4dc496d
Report timeframe fields restored; aggregated-chart admission no longer aborts (FIX-E1E2) (#299)
* FIX-E1E2 (E1): the report's script_tf_ratio and needs_aggregation again
pf_report_t::script_tf_ratio and needs_aggregation read 0 on every run
since #254 (73817c1) retired the legacy scheduler, whose run_tf_impl set
both (pine_scheduler.cpp:1334-1335) and whose simple run set 1 / false.
The native scheduler computes the same ratio at run begin
(PineScheduler::run_begin) and now hands it to the report fields there,
for every run the Pine host begins: the bare run, the timeframe-aware run,
an auto-detected input, the magnifier, a stream. Report-only: no trade
moves.
test_report_timeframe_ratio runs each route and a reused host; at
35db01c it fails 19 of its 79 checks (every ratio and aggregation flag
reads 0). ADR-0001 gains the row the kernel-seam-rows gate asks for
(the timeframe report facts, report-only, outside the hashed region);
doc anchors into pine_scheduler_native.cpp carried through the line map
from 35db01c.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
* FIX-E1E2 (E2): an aggregated chart's admission receipts name their command's bar
A run with Pine v6's default sizing (100 % of equity), a commission and
process_orders_on_close stopped on an aggregated chart with "admission
receipt requires its exact earlier command" (market_admission.cpp:26).
The adapter binds each entry command's admission observation to the row's
projection bar, the input slot (projection_bar_index). Since #289
(0d76a09) the kernel's public interval_index is the script bar, and the
receipts that follow a command kept reading it: the sizing revision a
margin call makes of a pending default-quantity entry
(refresh_pending_sizing_after_margin) and the three market reviews
(DefaultGross, ExplicitPair, TerminalGross). On an aggregated chart the
script bar is smaller than the input slot, so the receipt preceded its own
command and Draft::sizing_revised / reviewed threw. The terminal review of
a process_orders_on_close pair of fixed-quantity calls at pyramiding 0 hit
the same check with no commission or percent sizing at all. Every receipt
now carries projection_bar_index(context); on a chart run the two indices
are equal.
With the pair's terminal review running on an aggregated chart, its
same-bar round trips were dated at the next bar's open: the reversing call
closes the first leg's lot before the first leg's own notification re-dates
it to the chart bar's open (PineStrategyHost::on_native_applied). The
opening notification now also re-dates the rows a later execution of the
same pass booked from its lot.
TradingView's tapes of two synthetic probes written for this lane
(tests/fixtures/aggregated_admission_receipt, BINANCE:ETHUSDT.P 60,
lab tv --no-note): test_aggregated_admission_receipt_tapes replays both on
the chart's bars and aggregated from 15 and from 5 minutes. At 35db01c the
four aggregated rows stop with the receipt error (8 of 66 checks fail);
with the receipts alone the pair's aggregated rows misdate eight round
trips (16 of 150 fail); all 150 pass.
ADR-0001's row of the kernel-row fields the Pine host amends names
Trade::entry_time. Floors: RELEASE_MIN_TESTS 792 and EXCLUDED_REGISTERED_MIN 773/773/782 for
the lane's two rows; doc anchors into pine_adapter.cpp and
pine_strategy_host.cpp carried through the line map from 35db01c, and the
RELEASE_MIN_TESTS citations to its new line.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
---------
Co-authored-by: Claude Opus 5.5 (1M context) <[email protected]>1 parent 35db01c commit 4dc496d
23 files changed
Lines changed: 1777 additions & 64 deletions
File tree
- docs
- adr
- design
- pages
- scripts
- src/source
- tests
- fixtures/aggregated_admission_receipt
- fe2-pooc-mc-cost-m50
- fe2-pooc-pair
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
153 | 153 | | |
154 | 154 | | |
155 | 155 | | |
156 | | - | |
| 156 | + | |
157 | 157 | | |
158 | 158 | | |
159 | 159 | | |
| |||
Large diffs are not rendered by default.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
183 | 183 | | |
184 | 184 | | |
185 | 185 | | |
186 | | - | |
| 186 | + | |
187 | 187 | | |
188 | 188 | | |
189 | 189 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
118 | 118 | | |
119 | 119 | | |
120 | 120 | | |
121 | | - | |
| 121 | + | |
122 | 122 | | |
123 | 123 | | |
124 | 124 | | |
| |||
264 | 264 | | |
265 | 265 | | |
266 | 266 | | |
267 | | - | |
| 267 | + | |
268 | 268 | | |
269 | 269 | | |
270 | 270 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
584 | 584 | | |
585 | 585 | | |
586 | 586 | | |
587 | | - | |
| 587 | + | |
| 588 | + | |
| 589 | + | |
| 590 | + | |
| 591 | + | |
| 592 | + | |
| 593 | + | |
| 594 | + | |
588 | 595 | | |
589 | 596 | | |
590 | 597 | | |
| |||
625 | 632 | | |
626 | 633 | | |
627 | 634 | | |
628 | | - | |
| 635 | + | |
| 636 | + | |
629 | 637 | | |
630 | | - | |
| 638 | + | |
631 | 639 | | |
632 | 640 | | |
633 | 641 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1355 | 1355 | | |
1356 | 1356 | | |
1357 | 1357 | | |
1358 | | - | |
| 1358 | + | |
1359 | 1359 | | |
1360 | 1360 | | |
1361 | 1361 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17050 | 17050 | | |
17051 | 17051 | | |
17052 | 17052 | | |
| 17053 | + | |
| 17054 | + | |
17053 | 17055 | | |
17054 | 17056 | | |
17055 | 17057 | | |
| |||
17156 | 17158 | | |
17157 | 17159 | | |
17158 | 17160 | | |
| 17161 | + | |
| 17162 | + | |
| 17163 | + | |
| 17164 | + | |
17159 | 17165 | | |
17160 | | - | |
| 17166 | + | |
17161 | 17167 | | |
17162 | 17168 | | |
17163 | 17169 | | |
| |||
17355 | 17361 | | |
17356 | 17362 | | |
17357 | 17363 | | |
17358 | | - | |
| 17364 | + | |
17359 | 17365 | | |
17360 | | - | |
| 17366 | + | |
17361 | 17367 | | |
17362 | 17368 | | |
17363 | 17369 | | |
| |||
18064 | 18070 | | |
18065 | 18071 | | |
18066 | 18072 | | |
18067 | | - | |
| 18073 | + | |
18068 | 18074 | | |
18069 | 18075 | | |
18070 | 18076 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
126 | 126 | | |
127 | 127 | | |
128 | 128 | | |
| 129 | + | |
| 130 | + | |
129 | 131 | | |
130 | 132 | | |
131 | 133 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
528 | 528 | | |
529 | 529 | | |
530 | 530 | | |
| 531 | + | |
| 532 | + | |
| 533 | + | |
| 534 | + | |
| 535 | + | |
| 536 | + | |
| 537 | + | |
| 538 | + | |
| 539 | + | |
| 540 | + | |
531 | 541 | | |
532 | 542 | | |
533 | 543 | | |
| |||
0 commit comments