Repository navigation
Commit 4c9404c
committed
Build: every strategy TU is compiled with -ffp-contract=off, as libpineforge is (lane FPC)
libpineforge.a and libpineforge_kernel.a are compiled with -ffp-contract=off
(TradingView's runtime has no FMA, so every multiply-add rounds twice), but
the option was PRIVATE: no consumer inherited it. A strategy TU inlines the
header-side arithmetic (ta::*, series math) beside the generated Pine
expressions, and on ARM64 / FMA-enabled x86 it fused them. Measured at
d292f19: 89 of the 312 corpus strategy objects held 194 scalar FMAs on this
Mac (the same 89/194 on spark, GCC 13.3 aarch64), 80 of the 201 bench slots
497; the library objects none.
- CMakeLists.txt: both library targets add -ffp-contract=off as an INTERFACE
compile option. The library's own flags are unchanged (no library object
recompiles); every target that links pineforge / pineforge_kernel (corpus,
bench, tutorial, tests, find_package consumers through install(EXPORT))
now compiles with it. With it the 312 corpus and 201 bench strategy
objects hold 0 fused instructions, and their trades are byte-identical to
before on macOS arm64 and Linux aarch64 (312/312 against
scripts/corpus_parity_baseline.txt, 201/201 bench slots).
- benchmarks/run_all.sh: the hand-compiled canonical indicator runner, which
inlines ta::*, gets the flag too.
- cmake/smoke_consumer: the find_package consumer ci_verify builds refuses a
package whose PineForge::pineforge / PineForge::kernel lost the option,
and its run fails when its own multiply-add was fused (FMA hosts).
Fail-before against the d292f19 install: configure stops with
"PineForge::pineforge does not carry -ffp-contract=off to its consumers
(INTERFACE_COMPILE_OPTIONS: _pf_options-NOTFOUND)".
- docs: README's Pine -> .so recipe, integration-cmake (what the package
carries, Makefile / pkg-config recipes), ci.md and install.md (the
smoke checks; install.md named the binary smoke_consumer, it is
smoke_version), and two CMakeLists.txt anchors the ten inserted lines
moved.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
(cherry picked from commit 6ce79fb4a513f72b1899bcd2b20e7f702e99afff)
INT19 conflict resolution (docs only): one design-doc hunk where both INT18
and this commit re-anchored digits (this commit: CMakeLists.txt:427-428 ->
437-438 for the ten lines it adds); kept the base's digits -- the
citations are re-anchored once, at the end of INT19. Every other hunk
applied as written.1 parent 48b3e23 commit 4c9404c
9 files changed
Lines changed: 66 additions & 9 deletions
File tree
- benchmarks
- cmake/smoke_consumer
- docs
- adr
- pages
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
209 | 209 | | |
210 | 210 | | |
211 | 211 | | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
212 | 222 | | |
213 | 223 | | |
214 | 224 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
128 | 128 | | |
129 | 129 | | |
130 | 130 | | |
131 | | - | |
| 131 | + | |
132 | 132 | | |
133 | 133 | | |
134 | 134 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
241 | 241 | | |
242 | 242 | | |
243 | 243 | | |
244 | | - | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
245 | 247 | | |
246 | 248 | | |
247 | 249 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
6 | 18 | | |
7 | 19 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
4 | 19 | | |
5 | 20 | | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
6 | 26 | | |
7 | 27 | | |
8 | 28 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
339 | 339 | | |
340 | 340 | | |
341 | 341 | | |
342 | | - | |
| 342 | + | |
343 | 343 | | |
344 | 344 | | |
345 | 345 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
25 | | - | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
26 | 30 | | |
27 | 31 | | |
28 | 32 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
84 | | - | |
| 84 | + | |
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
88 | | - | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
26 | 31 | | |
27 | 32 | | |
28 | 33 | | |
| |||
49 | 54 | | |
50 | 55 | | |
51 | 56 | | |
52 | | - | |
| 57 | + | |
53 | 58 | | |
54 | 59 | | |
55 | 60 | | |
| |||
59 | 64 | | |
60 | 65 | | |
61 | 66 | | |
| 67 | + | |
| 68 | + | |
62 | 69 | | |
63 | 70 | | |
64 | 71 | | |
| |||
75 | 82 | | |
76 | 83 | | |
77 | 84 | | |
78 | | - | |
| 85 | + | |
79 | 86 | | |
80 | 87 | | |
81 | 88 | | |
| |||
0 commit comments