Skip to content

Commit 46bb21f

Browse files
luisleo526claude
andcommitted
Correct the claims of the corpus gate documentation
The documentation of the corpus repository validation gate said that the validator measures the selected subset and that a coverage limit is a finding. The validator compares only the header of each produced trade file with the recorded tape header and never compares trades, and no code emits a coverage finding. The section also described the corpus workflow in the present tense although the workflow is added by a later corpus pull request. This rewrites the three sentences, quoted here as they were so that the documentation checker can see them named: - "The corpus workflow runs the engine's `scripts/validate_corpus_sha.py` against the proposed corpus checkout and prints the engine commit it ran." - "The validator checks recorded bytes and checkout cleanliness, builds the probes and measures the selected subset." - "A coverage limit is a finding; subset measurement does not establish full population parity." The page is two lines longer, 2109 lines, so the two length pins in the preflight tests move together. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
1 parent 3e568e7 commit 46bb21f

2 files changed

Lines changed: 14 additions & 12 deletions

File tree

‎docs/ci.md‎

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2089,16 +2089,18 @@ comes from the trusted base tree, and the head checkout is data. A pull request
20892089
cannot replace the checker that judges its proposed corpus commit.
20902090
The job uses only its read-only job token and the admitted base and head SHAs.
20912091

2092-
The corpus workflow runs the engine's `scripts/validate_corpus_sha.py` against
2093-
the proposed corpus checkout and prints the engine commit it ran.
2094-
The validator checks recorded bytes and checkout cleanliness, builds the
2095-
probes and measures the selected subset. The manifest `file_digests.json`,
2096-
written by `scripts/write_corpus_file_digests.py`, binds every tracked corpus
2097-
file except itself. The checked commit binds the manifest's own bytes.
2092+
The corpus workflow, added by the corpus pull request, is to run the engine's
2093+
`scripts/validate_corpus_sha.py` on the proposed corpus checkout and print the
2094+
engine commit it ran. The validator checks recorded bytes and checkout
2095+
cleanliness, builds the selected probes and compares each produced trade file's
2096+
header with the recorded tape header; it never compares trades.
2097+
The manifest `file_digests.json`, written by
2098+
`scripts/write_corpus_file_digests.py`, binds every tracked corpus file except
2099+
itself. The checked commit binds the manifest's own bytes.
20982100
The manifest is not a signature: it detects unrecorded changes and exposes
20992101
deliberate rewrites for review, without proving the correctness of those files.
2100-
A coverage limit is a finding; subset measurement does not establish full
2101-
population parity. The full parity sweep remains a separate gate.
2102+
Subset probes do not establish population parity.
2103+
The full parity sweep remains a separate gate.
21022104

21032105
Known limit: while corpus OLD remains accepted, as arm OLD is today, a pull
21042106
request that removes the corpus job and restores OLD result wiring is admitted.

‎scripts/test_ci_preflight.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3040,8 +3040,8 @@ def test_post_jobs_refuse_other_fleets_scalars_and_reordered_labels(self):
30403040

30413041
def test_post_fleet_docs_match_runner_policy(self):
30423042
docs = (ROOT / 'docs/ci.md').read_text()
3043-
# expectation corrected: 2062 -> 2107, because corpus admission and gate documentation was added.
3044-
self.assertEqual(len(docs.splitlines()), 2107)
3043+
# expectation corrected: 2062 -> 2109, because corpus admission and gate documentation was added.
3044+
self.assertEqual(len(docs.splitlines()), 2109)
30453045
# The test-owned job catalog defines the protected label inventory.
30463046
tables = re.findall(
30473047
r"^\| Workflow \| Events/callers \| Inline jobs' `runs-on` \|\n"
@@ -5555,8 +5555,8 @@ def test_measured_slow_rows_refuse_variable_in_place_of_literal(self):
55555555

55565556
def test_documented_slow_row_counts_match_literal_population(self):
55575557
text = (ROOT / 'docs/ci.md').read_text()
5558-
# expectation corrected: 2062 -> 2107, because corpus admission and gate documentation was added.
5559-
self.assertEqual(len(text.splitlines()), 2107)
5558+
# expectation corrected: 2062 -> 2109, because corpus admission and gate documentation was added.
5559+
self.assertEqual(len(text.splitlines()), 2109)
55605560
slices = tuple(name for name in EXPECTED_PR_SLOW_ROWS
55615561
if name.startswith('test_ci_verify_slice_'))
55625562
self.assertTrue(slices, 'verifier slice inventory must not be empty')

0 commit comments

Comments
 (0)