Repository navigation
Commit 29c544f
test_check_doc_reverts: do not inherit the caller's PINEFORGE_DOC_REVERT_BASE (#516)
The lab queue ships PINEFORGE_DOC_REVERT_BASE (the engine tree's merge base) in
the environment of the whole preflight step. The tests in MustFail and MustPass
build throwaway repositories and call the checker with no --base, so they read
that value from the environment, and a sha of the engine history does not
exist in a fixture repository: the checker exits 2 "cannot resolve '<sha>'".
Three rows failed on every lab preflight of an engine tree (the queue-run
preflights of 10-26 04:33-05:10); GitHub CI never sets the variable and did not
see it.
- setUpModule / tearDownModule remove the variable for this module's tests and
restore the previous value (set, empty or unset) afterwards, so every present
and future class is independent of the host; DefaultBase.setUp still sets its
own empty value on top.
- MustPass.test_explicit_base_precedes_environment_base: with the variable set
to a sha the fixture does not have, an explicit --base wins and the check
passes, judging from the given base.
Only this test file changes; the checker is untouched.
Co-authored-by: CORE-TOP <[email protected]>
Co-authored-by: Claude Opus 5.5 (1M context) <[email protected]>1 parent 180630f commit 29c544f
1 file changed
Lines changed: 24 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
43 | 58 | | |
44 | 59 | | |
45 | 60 | | |
| |||
261 | 276 | | |
262 | 277 | | |
263 | 278 | | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
264 | 288 | | |
265 | 289 | | |
266 | 290 | | |
| |||
0 commit comments