Repository navigation
Commit 27c2d8e
XAU-CAL: a C host's session day moves only on a 1D script, a run's begin reads no earlier run's day labels, a calendar that fails to install leaves none, and every doc anchor is re-anchored once
A second read-only review (opus, "approve with comments") of the day-label
and calendar fixes found:
- the C host read every bar's session day at max(script_interval_open_ms,
script_interval_eligible_open_ms), which also moved 2D, W and M bars on a
masked session whose period opens on a day that does not trade (February
2025 on 0930-1600:23456: nominal Sat 02-01 -> Mon 02-03), an ABI field
outside the lane. It now does so only on a 1D script, where only a daily
stamp moves a bar's label before its session's open
(native_c_host.cpp; the pf_native_decision_v1 doc says so). Witness:
tests/test_native_c_api.c check_decision_session_day_of_a_masked_month --
the February bar keeps its nominal open's day; against c7df82e6
(r5/xau-cal-7239^, this code before this commit) "a masked month's day
moved to its first session". The check pins main's reading, so it passes
on main 0411892, where no label moves. The dated-day check still holds.
- a host reused across runs kept the previous run's day labels through the
next begin until prepare_day_labels ran at its end; they are cleared where
the begin clears its interval cache (prepare_public_begin).
- deliver_tick read a print's input slot at its raw stamp while its script
interval went through day_label_origin; both read the bar's own now.
- a calendar announcement that fails to install (a day missing) left the
earlier run's calendar installed for a later run that announces nothing;
the announcement now replaces it, so none is left
(install_symbol_calendar_metadata). Witness:
tests/test_symbol_calendar_tapes.cpp, "96 checks, 0 failures"; against
c7df82e6 "96 checks, 2 failures".
Not changed, as reported: _infer_bar_interval_ms (pre-existing, 76482e6)
reads a chart's first gap and parses stamps with int(); lanes pass
script_tf, so the daily route never infers. A hand-written malformed
calendar metadata makes the fingerprint's calendar digest raise, which main
already turns into "fingerprint: skipped".
Doc anchors, once, on the tree rebased onto main 0411892: of 1743, 275
did not resolve (main's digits moved by this lane's lines, and the lane's
own); check_doc_anchors.py --fix took 75, reanchor_doc_citations.py
--ref 0411892 --ref 12e3e507 (the lane's head before the rebase,
r5/xau-cal-7239) carried 181 by line map, and 21 were set by hand from a
main-to-this-tree line map: the four floor-constant citations (ci_verify.py
:320, :587; CONTRIBUTING.md, docs/pages/contributing-llm.md), native_c_api.h
:1485 (three pages) and :2137-2141, ADR-0001's pine_strategy_host.cpp
citations (:1872, :1982, :1933, :1901), the lane's own ADR row (:1958,
:2529, :2011), native-feature-parity.md's :3115 and :2005, and two
native_c_host.cpp citations (:4048, :3232-3236). check_doc_anchors.py: all
1743 resolve; check_doc_lint.py clean.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>1 parent 6f951cb commit 27c2d8e
13 files changed
Lines changed: 334 additions & 231 deletions
File tree
- docs
- adr
- design
- pages
- include/pineforge
- src
- source
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
152 | 152 | | |
153 | 153 | | |
154 | 154 | | |
155 | | - | |
156 | | - | |
| 155 | + | |
| 156 | + | |
157 | 157 | | |
158 | 158 | | |
159 | 159 | | |
| |||
Large diffs are not rendered by default.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
194 | 194 | | |
195 | 195 | | |
196 | 196 | | |
197 | | - | |
| 197 | + | |
198 | 198 | | |
199 | | - | |
| 199 | + | |
200 | 200 | | |
201 | 201 | | |
202 | 202 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
117 | 117 | | |
118 | 118 | | |
119 | 119 | | |
120 | | - | |
121 | | - | |
| 120 | + | |
| 121 | + | |
122 | 122 | | |
123 | 123 | | |
124 | 124 | | |
| |||
252 | 252 | | |
253 | 253 | | |
254 | 254 | | |
255 | | - | |
| 255 | + | |
256 | 256 | | |
257 | 257 | | |
258 | 258 | | |
| |||
264 | 264 | | |
265 | 265 | | |
266 | 266 | | |
267 | | - | |
| 267 | + | |
268 | 268 | | |
269 | 269 | | |
270 | 270 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
470 | 470 | | |
471 | 471 | | |
472 | 472 | | |
473 | | - | |
| 473 | + | |
474 | 474 | | |
475 | 475 | | |
476 | 476 | | |
| |||
638 | 638 | | |
639 | 639 | | |
640 | 640 | | |
641 | | - | |
| 641 | + | |
642 | 642 | | |
643 | 643 | | |
644 | 644 | | |
645 | | - | |
| 645 | + | |
646 | 646 | | |
647 | 647 | | |
648 | 648 | | |
| |||
1987 | 1987 | | |
1988 | 1988 | | |
1989 | 1989 | | |
1990 | | - | |
| 1990 | + | |
1991 | 1991 | | |
1992 | 1992 | | |
1993 | 1993 | | |
| |||
2108 | 2108 | | |
2109 | 2109 | | |
2110 | 2110 | | |
2111 | | - | |
| 2111 | + | |
2112 | 2112 | | |
2113 | 2113 | | |
2114 | 2114 | | |
| |||
3078 | 3078 | | |
3079 | 3079 | | |
3080 | 3080 | | |
3081 | | - | |
| 3081 | + | |
3082 | 3082 | | |
3083 | 3083 | | |
3084 | 3084 | | |
| |||
3164 | 3164 | | |
3165 | 3165 | | |
3166 | 3166 | | |
3167 | | - | |
| 3167 | + | |
3168 | 3168 | | |
3169 | 3169 | | |
3170 | 3170 | | |
| |||
0 commit comments