Skip to content

Commit 0c8e1a8

Browse files
authored
Combine pull requests 781, 758, 780 and 783 with the corpus validation, trade text and RCI changes (#788)
## Summary This branch combines seven source heads into one change on top of main (`755e6658`), so that the build, the parity sweep and the review each run once. Every source head was merged with an ordinary merge commit: nothing was rebased, nothing was squashed inside the branch, no conflict occurred in these merges and nothing was resolved by hand. Every source head contains main (`755e6658`) except the trade text channel's, which contains the main before one documentation-only commit (`63f3978a`); the combined branch contains main. When this change merges, pull requests 781, 758, 780 and 783 are closed with a link to it. A moving average change (head `4c5c65f4`, "Compute SMA from a correctly rounded window sum") was merged into this branch between the trade text channel and #783 and is taken out again by the last commit of the branch, a plain revert of that merge (`git revert -m 1`, no conflict). The parity measurement of the branch with it showed 40 probes whose graded tier falls against their committed TradingView tapes, every one of them calling `ta.sma`; a measurement of main plus only that change gave the same 40 results, and no other probe changed. The change is not part of this merge; whether it returns, and in what form, is decided separately. The tree of this branch equals the tree of the seven heads below merged on main without it. PR type: code (engine sources, tests, CI scripts and documentation). Fixes #779 ## Sources | Source | Title | Source head | |---|---|---| | #781 | ci: validate split releases and retained smoke output | `130bda2db570bd63bdec57b6b5fdd3cabacab7fc` | | branch | Validate corpus records and gitlink results in the pull-request checks | `46bb21fb169091722d49d3b2f2e4f1f589148166` | | #758 | test(ci): register rerun-preempted controller tests | `348a89766e0ff23f88b4837bce80957f7635ef8e` | | branch | Add an opt-in trade text companion channel | `5930d7f8d12010d67c77a098804eb6cd295095db` | | #783 | Add generated CLI coverage for map pair limits | `163abf58f1a73c7ec9160120774954fb29f4bd2d` | | branch | Avoid copying RCI price history during ranking | `022750f8451aadd93066ffad3b54695e23956116` | | #780 | Make nested consumer state construction portable to Clang | `000e2dac0e8e5e73fe53551adec7fbdf3f251af6` | The head listed for the corpus validation change already contains the heads listed for #781 and #758, so merging it brings both along and the separate merge of the #758 head changes nothing (it is listed because its pull request closes with this change). The merges that this branch makes of the source heads resolve no conflict by hand. The source histories themselves carry six merges that were resolved by hand in their own branches, before the heads were handed over: three in the history of the corpus validation head and three in the history of the trade text channel head. Corpus validation: `d482eb37` (`scripts/test_ci_preflight.py`: the stage-inventory counts between the registration of the rerun-controller tests and the corpus validation job), `f7519bb8` (`scripts/ci_preflight.py` and `scripts/test_ci_preflight.py`) and `cecedc0e` (`CHANGELOG.md`, `ci/cr150-source-bounds.yaml`, `scripts/test_cr150_source_gate.py` and `tests/private_fixture_reads.evidence`). Trade text channel: `09c9fb52` (`CHANGELOG.md` and `runner/main.cpp`), `8c17d14e` and `5930d7f8` (both in `ci/cr150-source-bounds.yaml` and `scripts/test_cr150_source_gate.py`). The head listed for #758 is that pull request's branch merged once with main; the head published on #758 is older. The head listed for #780 is the head of its branch (the construction fixes and the refreshed source citations in three documentation pages). ## How it was built The merges were made in the order of the table, with the moving average change between the trade text channel and #783 (see above), except that the separate merge of the #758 head was skipped because the corpus validation head contains it. Relative to main, 52 files change. Besides the files that #781 and #758 share with the corpus validation head, three files are touched by more than one source and were merged automatically without a conflict: `docs/ci.md` (the corpus validation change and #783), `docs/design/native-feature-parity.md` (the trade text channel and #780) and `scripts/test_ci_preflight.py` (#781, #758, the corpus validation change and #783). For every source, the changed lines of the files that only it touches equal the changed lines of this branch, and for every shared file the union of the sources' changed lines equals the branch's; an independent chain of the same merges in the reverse order gives the same tree. docs/ci.md: the slow-label bound paragraph and the slow-label inventory paragraph, introduced by 69cddc9 (#679), now state the size of the pinned set (90 names, including test_cr559_map_capacity_cli) instead of the retired 43 + 28 = 71 breakdown. docs/ci.md: the three sentences of 42527b6 (#704) that said gke-pr.yml admits exactly two variants, that OLD is the shape without the arm job kept so earlier workflow files still pass, that NEW requires the exact arm classifier output, and that hybrids and extra jobs, outputs, needs or arm steps are refused while OLD retains its original exact rules and templates for a workflow without the arm job, are rewritten to cover the arm and the corpus variants. ## What was done before merge Hosted CI was green on this head. One parity sweep against the active baseline measured this exact tree: 7,989 probes compared, no probe changed tier, no leaver, no regression, and the gate returned its neutral pass. One review of the combined diff, which cites each source, and of the revert commit gave a GO on this head and tree. The results already recorded on the individual pull requests and branches are not repeated here and do not stand in for these. The moving average change is not in this merge: it was merged into this branch and taken out again by the last commit, a plain revert. The full post-merge workflow was also run on this head (run 42452226570). It failed exactly the twelve jobs that fail on main `755e6658` (run 42435140307): the eight sanitizer shards and the live-sanitizer job, each stopping at the final link with "No space left on device", and their aggregate jobs. Every other job passed, and no job failed that passes on main. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
1 parent 755e665 commit 0c8e1a8

52 files changed

Lines changed: 11216 additions & 90 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎AGENTS.md‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ exact engine and codegen HEADs for baseline promotion.
7171

7272
| Command | Run it when the change touches | Why CI skips it |
7373
| --- | --- | --- |
74-
| `python3 scripts/test_ci_rerun_preempted.py` | `scripts/ci/rerun_preempted.py`, `scripts/fixtures/ci_rerun_preempted/`, `.github/workflows/rerun-preempted.yml` | no workflow, ctest row or preflight stage names it |
7574
| `python3 scripts/test_run_strategy_native_feed.py` | the native higher-timeframe feed path (`native_security_feeds`) of `scripts/run_strategy.py` | same |
7675
| `python3 scripts/verify_self_test.py` | the grading in `scripts/verify_corpus.py` (without the `corpus/` submodule it prints SKIP and exits 0) | same |
7776
| `python3 -I -m pytest -q tests/ownership/test_driver_selftest.py` | `tests/ownership/driver.py` (the self-tests need no codegen or engine, a real probe run does: `tests/ownership/README.md`) | CI runs only `tests/ownership/test_manifest_checker.py` (stage `selected-window-ownership-tests`) |

‎CHANGELOG.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,10 @@ version number follows semantic versioning over the surfaces the
3636
sooner (that total timeout covers connecting). A positive value sets the
3737
connect bound in seconds. Files and stdin ignore a well-formed value;
3838
malformed values are refused for every feed kind.
39+
- `pineforge-live run --trade-text PATH` optionally writes a separate finished
40+
report companion with all four trade text fields, run and row identity,
41+
and a count/SHA-256 trailer. It is off by default and has no text size cap;
42+
primary report and sink bytes remain unchanged.
3943
- **Default change, user-visible:** `pineforge-live run --feed -` (the stdin
4044
feed) no longer ends a run by itself after 15 seconds without data or 15
4145
seconds to complete a line. With neither flag given, `--feed-idle-timeout`

‎CLAUDE.md‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ exact engine and codegen HEADs for baseline promotion.
7171

7272
| Command | Run it when the change touches | Why CI skips it |
7373
| --- | --- | --- |
74-
| `python3 scripts/test_ci_rerun_preempted.py` | `scripts/ci/rerun_preempted.py`, `scripts/fixtures/ci_rerun_preempted/`, `.github/workflows/rerun-preempted.yml` | no workflow, ctest row or preflight stage names it |
7574
| `python3 scripts/test_run_strategy_native_feed.py` | the native higher-timeframe feed path (`native_security_feeds`) of `scripts/run_strategy.py` | same |
7675
| `python3 scripts/verify_self_test.py` | the grading in `scripts/verify_corpus.py` (without the `corpus/` submodule it prints SKIP and exits 0) | same |
7776
| `python3 -I -m pytest -q tests/ownership/test_driver_selftest.py` | `tests/ownership/driver.py` (the self-tests need no codegen or engine, a real probe run does: `tests/ownership/README.md`) | CI runs only `tests/ownership/test_manifest_checker.py` (stage `selected-window-ownership-tests`) |

‎ci/cr150-source-bounds.yaml‎

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,10 @@ ceilings:
9292
# blocks written in place, so the ceiling drops by two.
9393
# One materialize_relative_exits local-list group and three
9494
# SeriesPercentileNearestRank groups remain OPEN as well.
95-
unreviewed: 1404
95+
# Five more groups for the finished trade text companion: the source's text
96+
# accessor and the writer's transfer buffer, transfer bytes, carried bytes and
97+
# integer text temporaries. None is bounded.
98+
unreviewed: 1409
9699
pending-flat-memory: 184
97100
owners:
98101
- {name: "generated-cpp", globs: ["tutorial/**"]}
@@ -1736,3 +1739,8 @@ entries:
17361739
- {id: "U1724", file: "include/pineforge/source/pine_ta_length.hpp", symbol: "history_", ops: ["decl"], container: "std::vector<double>", owner: "source-layer", phase: "unclassified", state: "unreviewed", note: "SeriesPercentileNearestRank's append ring retains kMaxBarsBack + 1 doubles. Its optional ta::PercentileWindow retains the requested length, at most kMaxBarsBack + 1 values, and is rebuilt on a length change. OPEN.", line: 289}
17371740
- {id: "U1725", file: "src/source/pine_ta_length.cpp", symbol: "history_", ops: ["grow"], container: "unresolved by the index: history_.assign(...)", owner: "source-layer", phase: "unclassified", state: "unreviewed", note: "SeriesPercentileNearestRank's append ring is assigned once at kMaxBarsBack + 1 doubles and then overwrites slots. The optional ta::PercentileWindow retains the requested length, at most kMaxBarsBack + 1 values, and is rebuilt on a length change. OPEN.", line: 342}
17381741
- {id: "U1728", file: "src/source/pine_ta_length.cpp", symbol: "window_", ops: ["grow"], container: "unresolved by the index: window_.emplace(...)", owner: "source-layer", phase: "unclassified", state: "unreviewed", note: "SeriesPercentileNearestRank builds its ta::PercentileWindow for the requested length and builds it again when the requested length changes; the window retains that length, at most kMaxBarsBack + 1 values. OPEN.", line: 366}
1742+
- {id: "U1729", file: "include/pineforge/trade_text_source.hpp", symbol: "text_value", ops: ["decl"], container: "std::string", owner: "engine-core", phase: "unclassified", state: "unreviewed", note: "The trade text source returns one text field (an entry or exit id or comment) as a std::string by value: the virtual accessor and its ledger-backed and report-backed overrides. Each read_text call asks for the whole field again and copies a window of it, so a field longer than the transfer quantum is materialised once per transfer. A field length has no fixed bound. OPEN.", line: 86}
1743+
- {id: "U1730", file: "src/trade_text_writer.hpp", symbol: "buffer", ops: ["decl"], container: "std::vector<char>", owner: "engine-core", phase: "unclassified", state: "unreviewed", note: "The companion writer's one transfer buffer, allocated once per companion write at the read_capacity the caller supplies. read_capacity is a transfer quantum, not a limit on a field, a record or the stream. OPEN.", line: 26}
1744+
- {id: "U1731", file: "src/trade_text_writer.hpp", symbol: "bytes", ops: ["decl", "grow"], container: "std::string", owner: "engine-core", phase: "unclassified", state: "unreviewed", note: "One transfer of a text field: the held trailing bytes of the previous transfer plus the copied transfer, at most read_capacity + 3 bytes. OPEN.", line: 54}
1745+
- {id: "U1732", file: "src/trade_text_writer.hpp", symbol: "pending", ops: ["assign", "decl"], container: "std::string", owner: "engine-core", phase: "unclassified", state: "unreviewed", note: "Per text field: the at most three trailing bytes of a UTF-8 scalar that may cross a transfer boundary, carried into the next transfer. OPEN.", line: 45}
1746+
- {id: "U1733", file: "src/trade_text_writer.hpp", symbol: "std::to_string", ops: ["temp"], container: "unresolved by the index: std::to_string(...)", owner: "engine-core", phase: "unclassified", state: "unreviewed", note: "Decimal text of an unsigned 64-bit integer, at most 20 characters: the row index and the entry incarnation of each row, and the row count of the trailer. OPEN.", line: 83}

‎ci/cr150-source-sites.json‎

Lines changed: 142 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13194,6 +13194,43 @@
1319413194
"spelling": "const_iterator",
1319513195
"ordinal": 1
1319613196
},
13197+
{
13198+
"file": "include/pineforge/trade_text_source.hpp",
13199+
"symbol": "text_value",
13200+
"scope": [
13201+
"namespace pineforge #1",
13202+
"namespace report #1",
13203+
"namespace trade_source_detail #1",
13204+
"class TradeValueSourceV1 : public TradeSourceV1 #1"
13205+
],
13206+
"cls": "decl",
13207+
"spelling": "std :: string",
13208+
"ordinal": 1
13209+
},
13210+
{
13211+
"file": "include/pineforge/trade_text_source.hpp",
13212+
"symbol": "text_value",
13213+
"scope": [
13214+
"namespace pineforge #1",
13215+
"namespace report #1",
13216+
"class LedgerTradeSourceV1 final : public trade_source_detail :: TradeValueSourceV1 #1"
13217+
],
13218+
"cls": "decl",
13219+
"spelling": "std :: string",
13220+
"ordinal": 1
13221+
},
13222+
{
13223+
"file": "include/pineforge/trade_text_source.hpp",
13224+
"symbol": "text_value",
13225+
"scope": [
13226+
"namespace pineforge #1",
13227+
"namespace report #1",
13228+
"class EngineReportTradeSourceV1 final : public trade_source_detail :: TradeValueSourceV1 #1"
13229+
],
13230+
"cls": "decl",
13231+
"spelling": "std :: string",
13232+
"ordinal": 1
13233+
},
1319713234
{
1319813235
"file": "include/pineforge/window_sum.hpp",
1319913236
"symbol": "values_",
@@ -46690,6 +46727,111 @@
4669046727
"spelling": "std :: string",
4669146728
"ordinal": 1
4669246729
},
46730+
{
46731+
"file": "src/trade_text_writer.hpp",
46732+
"symbol": "buffer",
46733+
"scope": [
46734+
"namespace pineforge #1",
46735+
"namespace report #1",
46736+
"template < class Write > void write_trade_text_companion_to ( Write && write , std :: string_view run_id , const TradeSourceV1 & source , std :: size_t read_capacity ) #1"
46737+
],
46738+
"cls": "decl",
46739+
"spelling": "std :: vector < char >",
46740+
"ordinal": 1
46741+
},
46742+
{
46743+
"file": "src/trade_text_writer.hpp",
46744+
"symbol": "pending",
46745+
"scope": [
46746+
"namespace pineforge #1",
46747+
"namespace report #1",
46748+
"template < class Write > void write_trade_text_companion_to ( Write && write , std :: string_view run_id , const TradeSourceV1 & source , std :: size_t read_capacity ) #1",
46749+
"const auto text = [ & ] ( LogicalIndexV1 index , TradeTextV1 field ) #1"
46750+
],
46751+
"cls": "decl",
46752+
"spelling": "std :: string",
46753+
"ordinal": 1
46754+
},
46755+
{
46756+
"file": "src/trade_text_writer.hpp",
46757+
"symbol": "bytes",
46758+
"scope": [
46759+
"namespace pineforge #1",
46760+
"namespace report #1",
46761+
"template < class Write > void write_trade_text_companion_to ( Write && write , std :: string_view run_id , const TradeSourceV1 & source , std :: size_t read_capacity ) #1",
46762+
"const auto text = [ & ] ( LogicalIndexV1 index , TradeTextV1 field ) #1",
46763+
"while ( offset < length ) #1"
46764+
],
46765+
"cls": "decl",
46766+
"spelling": "std :: string",
46767+
"ordinal": 1
46768+
},
46769+
{
46770+
"file": "src/trade_text_writer.hpp",
46771+
"symbol": "bytes",
46772+
"scope": [
46773+
"namespace pineforge #1",
46774+
"namespace report #1",
46775+
"template < class Write > void write_trade_text_companion_to ( Write && write , std :: string_view run_id , const TradeSourceV1 & source , std :: size_t read_capacity ) #1",
46776+
"const auto text = [ & ] ( LogicalIndexV1 index , TradeTextV1 field ) #1",
46777+
"while ( offset < length ) #1"
46778+
],
46779+
"cls": "grow",
46780+
"spelling": "bytes . append ( . . . )",
46781+
"ordinal": 1
46782+
},
46783+
{
46784+
"file": "src/trade_text_writer.hpp",
46785+
"symbol": "pending",
46786+
"scope": [
46787+
"namespace pineforge #1",
46788+
"namespace report #1",
46789+
"template < class Write > void write_trade_text_companion_to ( Write && write , std :: string_view run_id , const TradeSourceV1 & source , std :: size_t read_capacity ) #1",
46790+
"const auto text = [ & ] ( LogicalIndexV1 index , TradeTextV1 field ) #1",
46791+
"while ( offset < length ) #1"
46792+
],
46793+
"cls": "assign",
46794+
"spelling": "pending = . . .",
46795+
"ordinal": 1
46796+
},
46797+
{
46798+
"file": "src/trade_text_writer.hpp",
46799+
"symbol": "std::to_string",
46800+
"scope": [
46801+
"namespace pineforge #1",
46802+
"namespace report #1",
46803+
"template < class Write > void write_trade_text_companion_to ( Write && write , std :: string_view run_id , const TradeSourceV1 & source , std :: size_t read_capacity ) #1",
46804+
"+ + index ) #1"
46805+
],
46806+
"cls": "temp",
46807+
"spelling": "std :: to_string ( . . . )",
46808+
"ordinal": 1
46809+
},
46810+
{
46811+
"file": "src/trade_text_writer.hpp",
46812+
"symbol": "std::to_string",
46813+
"scope": [
46814+
"namespace pineforge #1",
46815+
"namespace report #1",
46816+
"template < class Write > void write_trade_text_companion_to ( Write && write , std :: string_view run_id , const TradeSourceV1 & source , std :: size_t read_capacity ) #1",
46817+
"+ + index ) #1"
46818+
],
46819+
"cls": "temp",
46820+
"spelling": "std :: to_string ( . . . )",
46821+
"ordinal": 2
46822+
},
46823+
{
46824+
"file": "src/trade_text_writer.hpp",
46825+
"symbol": "std::to_string",
46826+
"scope": [
46827+
"namespace pineforge #1",
46828+
"namespace report #1",
46829+
"template < class Write > void write_trade_text_companion_to ( Write && write , std :: string_view run_id , const TradeSourceV1 & source , std :: size_t read_capacity ) #1"
46830+
],
46831+
"cls": "temp",
46832+
"spelling": "std :: to_string ( . . . )",
46833+
"ordinal": 1
46834+
},
4669346835
{
4669446836
"file": "tutorial/macd/generated.cpp",
4669546837
"symbol": "_pf_derive_prefix",

0 commit comments

Comments
 (0)