Skip to content

Clarify unreleased fixes and numeric helper documentation - #353

Merged
luisleo526 merged 1 commit into
mainfrom
docs/unreleased-notes-1108
Nov 8, 2026
Merged

luisleo526 merged 1 commit into
mainfrom
docs/unreleased-notes-1108

Conversation

@luisleo526

Copy link
Copy Markdown
Contributor

Clarify the existing Unreleased entries for #287, #291, #293 and #294 while retaining all six issue references and the unchanged #286/#311 entries.

Explain the per-bar loop-history change, distinguish full-month parsing from existing 64-bit timestamp handling, and mark scalar empty-timeframe behavior as preserved. Replace obsolete numeric-helper provenance with a description of the current helpers.

Validation: source and diff inspection only; no tests run. The helper's executable code, numeric assertions, fixtures, expected values and skip behavior are unchanged. Hosted CI remains required.

🤖 Generated with Claude Code

Distinguish new parsing behavior from preserved behavior and explain the loop history change. Replace obsolete helper provenance with a description of its current responsibilities.

@graphify-labs graphify-labs Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graphify reviewed this change.

No issues found by static checks — no coupling regressions or blocking issues in the code graph. That is not the same as safe to merge: see what was not checked.

Not checked: tests were not run; no formal proof of the changed code.


Graphify review — findings

Rewords several CHANGELOG entries and a test-helper docstring, with no code behaviour change. The request.security and loop-history entries are reflowed, and the loop-history one now states the old behaviour: each iteration opened a separate slot, so y[i] could read prior iterations instead of prior bars. The timestamp("...") entry is also reworded so the full month-name support reads as new and the 64-bit handling as preserved. The tests/_numeric_support.py docstring drops its provenance note and describes what _sha, _json, _process and _git_identity do (e.g. _json rejects NaN and infinity, _process runs under LC_ALL=C).

No blocking issues surfaced.

Analysis details — impact, health, verification

Impact & health

Graphify review

Impact — 87 functions depend on the 84 functions this change touches.

Health — grade A; 2 existing hotspot(s) in the area this change touches (pre-existing, not introduced here):

  • _native_values() — 3 callers, 5 callees (medium)
  • test_default_result_native_after_real_strategy_run() — 0 callers, 8 callees (medium)

Verification — 87 functions in the blast radius were not formally verified this run (proofs are advisory here).

Gate & verification

graphify gate

PASS — objectively clean (no health regressions, tests not run — proofs not run this pass (advisory)). Grounded, not self-assessed.

Advisory (not blocking):

  • verification_scope: 87 function(s) in the blast radius were not formally verified this run

Cross-repo impact

Cross-repo impact

No cross-repo impact detected among the indexed peer repo(s).

1 peer repo(s) in this group are not yet indexed — cross-repo impact may be incomplete.

Cross-repo linkage is derived (SCIP-moniker matches are sound; name/contract matches are heuristic) and ADVISORY — it never affects this check's conclusion.

@luisleo526
luisleo526 merged commit 437b906 into main Nov 8, 2026
27 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant