Repository navigation
codegen: strategy.account_currency follows strategy(currency=...) (#227) - #250
Merged
Merged
Conversation
Brings the branch up to date with codegen main (CHANGELOG backfill, #248). The merge is clean: CHANGELOG.md auto-merged and keeps both the main entries and the Unreleased note for strategy.account_currency (#227). Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
luisleo526
added a commit
that referenced
this pull request
Oct 25, 2026
Brings the branch up to date with codegen main, which now holds the strategy.account_currency fix (#227, #250). CHANGELOG.md conflicted in the Unreleased section only; both bullets are kept (the input.color metadata fix of this branch first, then the account_currency fix from main). No other file conflicted. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
luisleo526
added a commit
that referenced
this pull request
Oct 26, 2026
## What Replaces the three-bullet `## Unreleased` block of `CHANGELOG.md` with the full planned-1.8.0 entry and its migration notes. `CHANGELOG.md` is the only file changed (+54/-10). Documentation only. ## Why The release workflow creates the GitHub release with a fixed install line and no migration notes; the notes users read are this file. They must be on main before the release dispatch. The heading stays `## Unreleased` until the `v1.8.0` tag exists, as the file's own release note policy says; a separate docs-only commit dates it after the tag. ## Content - Compatibility and migration: exact pairing with engine `v1.8.0`; regenerate strategy C++ and relink; the new `color` input type with its unsigned packed `0xAARRGGBB` default that hosts must preserve; the `strategy.account_currency` emitted-C++ change (intended to change only for scripts that read it; not a byte comparison against 1.7.0); CRLF and lone CR line endings accepted. - The four pull requests merged after `v1.7.0`: #251 (#231), #250 (#227), #252 (#230), #248 (CHANGELOG backfill, no behaviour change). - One sentence about pineforge-hpo accepting color inputs from its 1.8.0 release; true of hpo main today, re-checked against hpo's 1.8.0 entry before the release. ## Checks - Read as a committed diff by an independent reviewer: GO. The four commits since `v1.7.0` are the four bullets. - The `color.red` value `4294063685` (`0xFFF23645`) was recomputed. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Supersedes #256 (same change; the commit message no longer carries an internal tracking id).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #227.
strategy.account_currencynow follows thecurrencyargument ofstrategy()(the symbol's currency when it is omitted orcurrency.NONE), and comparing it with acurrency.*constant and concatenating it into a string both build. No currency conversion is added; only the value is corrected.Red-first tests:
tests/test_strategy_account_currency.py(from the issue's cases). Lab proof on engine main: pytest 10474 passed, compile-corpus 312 passed, 0 failures. Reviewed (REV-CX GO).🤖 Generated with Claude Code