Skip to content

docs: stop naming a retired private repository in five lines - #239

Merged
luisleo526 merged 2 commits into
mainfrom
lab-m3c-v2
Oct 21, 2026
Merged

luisleo526 merged 2 commits into
mainfrom
lab-m3c-v2

Conversation

@luisleo526

Copy link
Copy Markdown
Contributor

What

Five lines in this public repository name a private repository (frozen, to be deleted). Each now describes the frozen campaign verifier by its commit (3bac0b7b) and script path (scripts/verify-engine-local.py:1698), or the facts' origin ("the maintainers' campaign verifier"), without a repository name. Comments, docstrings and two documentation lines only: no executable line, fixture or assertion changes (5 files, 5 lines).

Part of the owner's order of 2026-10-20 to remove every dependency on a private campaign repository. Opened after the v1.6.2 tags exist, so nothing lands on main before the cut.

Rows

repo file:line kind change
pineforge-codegen-oss pineforge_codegen/pine_libraries.py:21 module docstring a repository name before "3bac0b7b" becomes "commit"
pineforge-codegen-oss tests/test_pine_libraries.py:13 test docstring same
pineforge-codegen-oss tests/test_e2e_session_ismarket.py:158 test comment drops the repository name
pineforge-codegen-oss AGENTS.md:430 docs (instruction file, one phrase of one table row) a private repository name becomes "the frozen campaign verifier"
pineforge-codegen-oss CLAUDE.md:430 docs (same row, same phrase) same

Checks

  • pine_libraries.py:21 is inside the module docstring, not a string the code uses: no __doc__ read of that module and no assertion on its text (searched: __doc__ appears only in three unrelated CLI scripts). Parentheses of the sentence stay balanced.
  • A search of the tree for that repository's name: no match after the change.
  • Left on purpose: AGENTS.md/CLAUDE.md line 430 also name another private repository; outside this change, flagged to the supervisor.
  • TypeSafe diff guard (second opinion): pass; literal_hack 0.02, scope_creep 0.09, debug_left 0.01, does_what_brief_asks 0.69. The supervisor read every hunk.
  • CI of this repository runs on the PR (no code path is touched).

🤖 Generated with Claude Code

luisleo526 and others added 2 commits October 22, 2026 02:04
The frozen campaign verifier is described by its commit (3bac0b7b) and its script path; the repository name it lived in is gone. Comments and docs only: no executable line, fixture or assertion changes.
@luisleo526
luisleo526 merged commit 961f44f into main Oct 21, 2026
8 checks passed
luisleo526 added a commit that referenced this pull request Oct 25, 2026
* CHANGELOG: sections for 1.6.2 and 1.6.3 (release-notes backfill, CR-315)

The CHANGELOG had no 1.6.2 or 1.6.3 section: 1.7.0 sat directly above 1.6.1, although the
release note policy at the top of the file asks for a section per released version. This
adds both, from the tags (`git log` and `git diff` between v1.6.1, v1.6.2, v1.6.3) and the
GitHub release notes and the published advisory GHSA-5www-2x9c-mgr6:

- 1.6.3 (2026-10-23): the security fix merged from a private fork (commit 0418898,
  "Codegen can emit C++ calls and type names taken from the input script", high, CWE-94,
  affected pineforge-codegen 0.6.4 up to 1.6.3 and @pineforge/codegen-pyodide 0.7.0 up to
  1.6.3), stated as the advisory states it and without a reproduction recipe; and #237,
  #238, #239, #240 (CI, npm publishing environment, documentation).
- 1.6.2 (2026-10-21): the pf-cpp-allowlist checker (#210), the LIBC_RESERVED_NAMES
  reserved-name change in the emitter, the licensor entity written as PINEFORGE LLC (#234),
  and the CI changes #212, #214, #215, #216, #217, #221, #223, #225, #233, #236.

Additions only (0 lines removed): no sentence is replaced. No file other than CHANGELOG.md
changes.

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

* CHANGELOG: 1.6.3 compatibility text states that the security fix refuses scripts (REV P2) (CR-315)

REV-CX's read of the CR-315 backfill (reports/verdict-cr315.md) found that the 1.6.3
Compatibility bullet understated the fix. Checked against `git diff v1.6.2 v1.6.3` of
pineforge_codegen/ before writing it:

- visit_call.py / visit_expr.py: an unknown call or a member read on a builtin-backed
  receiver no longer reaches the emitted C++ as text; it ends with
  "<name>(...) is not implemented in PineForge runtime.";
- parser.py: a string, number or operator in a type position or inside <...> raises a
  located ParseError;
- support_checker.py: array.new / array.from with an undeclared element type is refused
  with the same "not implemented" message;
- types.py: the default of an enum-typed element is na<double>() (a name that is not a
  declared user type falls back to its slot's default); visit_expr.py: format, currency
  and order values are typed std::string.

So a script that compiled under 1.6.2 can fail under 1.6.3, which the bullet now says.
Also (REV P3): the pf-cpp-allowlist entry carries the advisory's own caveat (a denylist
with known false positives, not proof that a unit is safe), and the Security entry states
that release images before 1.6.3 contain an affected codegen and the 1.6.3 image the fixed
one.

Replaces text added by the previous commit of this change (d009aee), not on main.
CHANGELOG.md only.

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

---------

Co-authored-by: Claude Sonnet 5.5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant