Conversation
bdd
approved these changes
Jul 10, 2025
Contributor
bdd
left a comment
bdd
left a comment
There was a problem hiding this comment.
Thanks for fixing argtable3 dependency and also the broken test path for dfu file parsing.
I will enable unit tests for the Nix package as this lands, and hopefully leads to, dunno, 0.5.0 release.
Collaborator
Author
|
I think once your fixes are merged I'm happy to tag a new version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to extend supported files to also include hex files.
This comes with limitations; in that I've hard coded a sensible max size and only done light testing. Will test a bit more before its merged :)