Enable macOS universal builds#52
Merged
gamelaster merged 3 commits intopine64:masterfrom Aug 28, 2023
Merged
Conversation
Contributor
Author
|
Thanks for enabling the workflows @gamelaster This hopefully also solves issue #34 Even though the OP of that issue was having a compilation error. I managed to compile it locally without issues, and the same with the Github action. So I am not sure if that issue is still present. |
Member
|
@amxfonseca thank you very much for this, I am sure this will be helpful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables universal binaries for the macOS build. This way you are able to run blisp on newer machines, without having to rely on Rosetta 2.
The change is quite simple, since CMake already exposes a variable that provided such functionality.
This PR sets the CMAKE_OSX_ARCHITECTURES to enable both x86_64 and arm64 builds on a single binary. This options is already ignored for the remaining platforms, so we don't need to conditionally set it.
Alternatively we can also manually provide this setting via the command line. That way we can keep the legacy build running as it is, and create a separate build job that outputs a universal artefact. But fat binaries are well supported on all versions of macOS, so I don't think such options is needed.