Compile internal file_parsers lib always statically#51
Merged
Ralim merged 1 commit intopine64:masterfrom Aug 10, 2023
Merged
Conversation
Otherwise, depending on BUILD_SHARED_LIBS default, it may be compiled dynamically. However, the resulting DSO currently would not be installed, resulting in unusable installed blisp binary.
Contributor
Author
|
As proposal, should fix #50 |
Ralim
approved these changes
Aug 10, 2023
Collaborator
|
Oops sorry. That's my bad. Would be super keen to add this to the GitHub actions build tests if we can so I can't make this mistake again 😂. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, depending on BUILD_SHARED_LIBS default, it may be compiled dynamically. However, the resulting DSO currently would not be installed, resulting in unusable installed blisp binary.