Skip to content

Comments

Add support for building against system libraries of libserialport an…#36

Closed
schdro wants to merge 9 commits intopine64:masterfrom
schdro:feature-allow-syslibs
Closed

Add support for building against system libraries of libserialport an…#36
schdro wants to merge 9 commits intopine64:masterfrom
schdro:feature-allow-syslibs

Conversation

@schdro
Copy link
Contributor

@schdro schdro commented Apr 9, 2023

Allow building against existing system libraries of libserialport and argtable.
By default (new variable unset), still prepackages vendor libraries should be used for build.

Proposal to fix created issue:
Resolves #35

Schdro and others added 2 commits April 9, 2023 17:54
Avoid including include dir when building against system lib
(to avoid possible dup when also checked out as submodule).
Refine README description.
@Ralim
Copy link
Collaborator

Ralim commented May 9, 2023

@schdro If you can rebase this I'm happy for this to go in :)

@schdro
Copy link
Contributor Author

schdro commented May 14, 2023

Hmm, rebase seems to break PR (pulling in old commits), closing for now.

@schdro schdro closed this May 14, 2023
@Ralim
Copy link
Collaborator

Ralim commented May 14, 2023

Damn sorry; if you can get it working I would be keen to add it.

Would be ideal to also build with system libs in ci if we can, to try and make sure it works.

@schdro
Copy link
Contributor Author

schdro commented May 14, 2023

ok, understood
When time permits, will try to create new fbranch/PR from scratch.

For Ubuntu (CI) unsure if they already have syslibs in place. Might then mean to somehow install other packages first.

The change certainly is interesting, because should allow to build e.g. for source based dists, where binaries and submodule downloads by the build are undesired (e.g. Gentoo sandbox by default disables unmanaged build downloads). Using it here as local Gentoo ebuild, sys-apps/blisp + dev-libs/argtable-3.2.2 + dev-libs/libserialport. ArchLinux might be similar.

@schdro schdro deleted the feature-allow-syslibs branch June 4, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow building with system installed libraries

3 participants