Skip to content

BUILD_SHARED_LIBS=ON: Incomplete CMake installation #50

@schdro

Description

@schdro

When CMake BUILD_SHARED_LIBS=ON is set (e.g. Gentoo Linux CMake default), the current build will:

  • Build new DFU file_parsers library as shared
  • Install only blisp binary without the also required file_parsers DSO

Therefore, the binary is not usable.

With BUILD_SHARED_LIBS=OFF (regular default e.g. for manual builds), no error to be noticed.

Reason is that blisp/src/file_parsers/CMakeLists.txt does not declare any library type (https://cmake.org/cmake/help/latest/variable/BUILD_SHARED_LIBS.html).

  • Either, in case of shared library which is intended to be used also as public export, the built/needed DSO (plus possible public header files) would need to be installed.
  • Or, more along the likely intention of f1b93a1: This internal library should be always built explicitly as STATIC.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions