Skip to content

Conversation

@bjohansebas
Copy link
Member

Could this be a breaking change? This might make it a breaking change in the new MIME types resolution, which is why I have doubts about it. This is also a direct dependency of Express, so I'm not sure.

Related expressjs/express#6316

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also we need to update the HISTORY.md here too @bjohansebas

@UlisesGascon UlisesGascon changed the title deps: update mime-types to v3.0.0 deps: update mime-types to v3.0.1 Mar 24, 2025
UlisesGascon and others added 2 commits March 24, 2025 11:32
Co-authored-by: Sebastian Beltran <[email protected]>
Co-authored-by: Sebastian Beltran <[email protected]>
@UlisesGascon UlisesGascon self-assigned this Mar 24, 2025
Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the mime-types change was a node version drop which is already dropped here I think this is low risk from a breaking change.

@UlisesGascon UlisesGascon merged commit c2d618c into pillarjs:master Mar 26, 2025
7 of 10 checks passed
@UlisesGascon UlisesGascon mentioned this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants