-
-
Notifications
You must be signed in to change notification settings - Fork 194
deps: update mime-types to v3.0.1
#251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
UlisesGascon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Related expressjs/express#6316 (comment)
UlisesGascon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also we need to update the HISTORY.md here too @bjohansebas
mime-types to v3.0.0mime-types to v3.0.1
Co-authored-by: Sebastian Beltran <[email protected]>
Co-authored-by: Sebastian Beltran <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the mime-types change was a node version drop which is already dropped here I think this is low risk from a breaking change.
Could this be a breaking change? This might make it a breaking change in the new MIME types resolution, which is why I have doubts about it. This is also a direct dependency of Express, so I'm not sure.
Related expressjs/express#6316