Pull Request Test Coverage Report for Build 17037641521

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 93.837%

Totals
Change from base Build 17015959667:	0.0%
Covered Lines:	944
Relevant Lines:	1006

💛 - Coveralls

Hey, I just modified your PR to add tests for the types. I’m still testing a few things to make sure I don’t break anything, but feel free to push changes if you see something missing.

Very valid. I've pushed the relevant changes.

Hey @bjohansebas, can you port this to the v1 branch?

Hi,
The new typings are not compatible with module: "node20". One gets :

Property 'decode' does not exist on type 'typeof iconv'.

I've been experimenting. I initially did not want to modify lib/index.js when creating this PR, but editing the file may be needed for importing iconv properly across different NodeJS and TypeScript versions, with ESM and CJS.

It's a straightforward change. Rather than setting properties/methods in the iconv variable, we set them in the exports object instead. For example:

-- iconv.encodings = null
-- iconv.encode = function encode (str, encoding, options) {...}
++ exports.encodings = null
++ exports.encode = function encode (str, encoding, options) {...}

iconv variable can still be used internally. For example, when creating a new Codec in iconv.getCodec.

I have a working branch (https://github.com/plbstl/iconv-lite/tree/more-typedefs-improvements) with the test and test:typescript tests passing.

Hi, The new typings are not compatible with module: "node20". One gets :

Property 'decode' does not exist on type 'typeof iconv'.

@prigaux Can you provide more information? How are you attempting to access decode?

Hey @prigaux , could you please create a new issue with a minimal reproducible example?

(sorry for not giving enough information, i thought i was enough to reproduce)

To reproduce, you need "type": "module" in package.json and --module node20 param to tsc.

Reproduced with

• the following package.json:

{
  "type": "module",
  "dependencies": {
    "iconv-lite": "^0.7.1",
    "typescript": "^5.9.3",
    "@types/node": "^25.0.2"
  }
}

• a simple test.ts file containing:

import iconv from 'iconv-lite'
iconv.decode

• and running cmd

npx tsc --module nodenext test.ts 

=>

test.ts:2:7 - error TS2339: Property 'decode' does not exist on type 'typeof iconv'.

@prigaux I can’t manage to reproduce it. Could you create a clean GitHub repo with that so we can debug it more easily?

Hi, @plbstl @bjohansebas

Property 'decode' does not exist on type 'typeof iconv'.

I faced with the same error message; I'm not sure if I'm with same condition though.
Here is the code for reproduction.
https://github.com/takayukioda/reproduce-lab/blob/main/iconv-lite-not-found/src/index.ts
If you change the version from 0.7.1 to 0.7.0, it'll succeed to build. Or, if you change the import declaration from * as iconv to iconv, it also succeed.

Here is a clean repo: https://github.com/prigaux/iconv-lite-typescript-modules-issue

git clone https://github.com/prigaux/iconv-lite-typescript-modules-issue
cd iconv-lite-typescript-modules-issue/
npm install
npm run test1
npm run test2

I have nodejs 24.11.1-1nodesource1