fix: remove unpipe package and use native unpipe method #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleytodd
approved these changes
Nov 14, 2024
Phillip9587
force-pushed
the
remove-unpipe
branch
from
5f05d5f to
c212980
Compare
Contributor
Author
|
Hi @wesleytodd, I hope you're doing well! I just wanted to kindly follow up on this PR. I added a entry in the HISTORY.md and believe it’s ready to merge now. If there’s anything else needed on my end, please let me know. Thank you for your time and consideration! |
Member
|
No action necessary on your end. I have just been catching up and trying to balance this work with my other commitments and have not had time to put together releases for these packages yet. It will happen though, just takes time. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
unpipepackage was used to unpipes all destinations from a given stream.Taken from the unpipe readme:
As our minimum supported Node version is v18 the
unpipepackage is no longer needed.