Repository navigation
fix: decode a Cal colour space without its dictionary as the device space - #750
Closed
RavSinghChandan wants to merge 1 commit into
Closed
RavSinghChandan wants to merge 1 commit into
RavSinghChandan wants to merge 1 commit into
Conversation
RavSinghChandan
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #750 +/- ##
=======================================
Coverage 92.58% 92.58%
=======================================
Files 118 118
Lines 15637 15637
Branches 900 900
=======================================
+ Hits 14477 14478 +1
+ Misses 1160 1159 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
RavSinghChandan
force-pushed
the
fix-cal-colorspace-without-dict
branch
from
October 19, 2026 06:45
65519f8 to
f2b9cef
Compare
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
synthesize_cal_icc()documents that it returns None for malformed Cal* colour spaces and catches several errors for that, but notIndexError. So an image with/ColorSpace [/CalRGB](no parameter dictionary) failed inas_pil_image()withIndexError: list index out of range, while one missing only/WhitePointalready falls back to the device space. CatchingIndexErrortoo gives both the same fallback.Added
test_cal_missing_dictionary_falls_backnext totest_cal_missing_whitepoint_falls_back, plus a release note.AI-assisted (Claude Code); I reviewed and tested the change.