Repository navigation
fix: warn instead of raising KeyError for an unknown page label style - #749
Closed
RavSinghChandan wants to merge 1 commit into
Closed
RavSinghChandan wants to merge 1 commit into
RavSinghChandan wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #749 +/- ##
==========================================
- Coverage 92.38% 92.38% -0.01%
==========================================
Files 112 112
Lines 15489 15488 -1
Branches 836 836
==========================================
- Hits 14309 14308 -1
Misses 1180 1180 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
RavSinghChandan
force-pushed
the
fix-unknown-page-label-style
branch
from
October 19, 2026 06:44
6beda63 to
0b9e1ce
Compare
Member
|
Thanks! This was merged to main as 6beda63, so I'm closing the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading
page.labelraisedKeyError: 'Z'when a page label dictionary had a style name outside D, R, r, A, a (for example/S /Z). A style that is not a name already warns "Page label dictionary has invalid page label style" and keeps the prefix; an unknown name now does the same, so one malformed label no longer stops code that lists page labels.Added a case to
test_page_label_dictsand a release note.AI-assisted (Claude Code); I reviewed and tested the change.