Skip to content

Build pipeline updates#937

Merged
gmr merged 1 commit intomasterfrom
build-changes
Jan 30, 2018
Merged

Build pipeline updates#937
gmr merged 1 commit intomasterfrom
build-changes

Conversation

@gmr
Copy link
Copy Markdown
Member

@gmr gmr commented Jan 30, 2018 •
edited
Loading

  • Drops testing support for Python 2.6
  • Moves to the build stages setup for travis
  • Builds combined coverage across all Python versions and uploads it to codecov
  • Adds testing of pypy and pypy3

@gmr gmr requested a review from lukebakken January 30, 2018 21:56
lukebakken
lukebakken reviewed Jan 30, 2018
View reviewed changes
.travis.yml
- python: 2.7
- python: 3.4
- python: 3.5
- python: 3.6
Copy link
Copy Markdown
Member

@lukebakken lukebakken Jan 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should 3.7-dev be included as well as in #934?

Copy link
Copy Markdown
Member Author

@gmr gmr Jan 30, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to merge this as something atomic that works. I don't know what will or will not break in 3.7 and I'd rather get us to a baseline before tackling any 3.7 specific changes.

#934 should rebase based upon this add add a 3.7-dev version in IMO.

@lukebakken lukebakken mentioned this pull request Jan 30, 2018
Merged
@lukebakken lukebakken added this to the 1.0.0 milestone Jan 30, 2018
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 30, 2018 •
edited
Loading

Codecov Report

Merging #937 into master will decrease coverage by 2.59%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #937     +/-   ##
=========================================
- Coverage   82.12%   79.52%   -2.6%     
=========================================
  Files          21       21             
  Lines        3776     3776             
  Branches      560      560             
=========================================
- Hits         3101     3003     -98     
- Misses        517      626    +109     
+ Partials      158      147     -11
Impacted Files Coverage Δ
pika/adapters/libev_connection.py 0.78% <0%> (-72.66%) ⬇️
pika/__init__.py 78.94% <0%> (-21.06%) ⬇️
pika/adapters/blocking_connection.py 84.74% <0%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef157cb...06f294c. Read the comment docs.

@gmr gmr merged commit 44ff74f into master Jan 30, 2018
@gmr gmr deleted the build-changes branch January 30, 2018 22:14
@hugovk
Copy link
Copy Markdown
Contributor

hugovk commented Jan 31, 2018

The coverage build job fails on PRs (eg. #933) and forks because:

0.54s$ aws s3 cp --recursive s3://com-gavinroy-travis/pika/$TRAVIS_BUILD_NUMBER/ coverage
fatal error: Unable to locate credentials

This should be disabled from PRs and forks.

@gmr
Copy link
Copy Markdown
Member Author

gmr commented Jan 31, 2018 •
edited
Loading

EDIT: So it looks like the PR job is run against your repo and it can't submit coverage. I'll add a condition to the job for now, but need to figure out a better way to handle it.

lukebakken pushed a commit that referenced this pull request Apr 12, 2018
@gmr @lukebakken
Merge pull request #937 from pika/build-changes
8638f05 
Build pipeline updates

(cherry picked from commit 44ff74f)
@lukebakken lukebakken mentioned this pull request Apr 13, 2018
Merged
@lukebakken lukebakken mentioned this pull request Nov 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukebakken lukebakken lukebakken approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@gmr @hugovk @lukebakken