Drop support for EOL Python 2.6 and 3.3#933
Conversation
|
When merged, the 2.6 skips in #932 can be removed. |
Codecov Report
@@ Coverage Diff @@
## master #933 +/- ##
==========================================
- Coverage 82.26% 82.09% -0.18%
==========================================
Files 20 21 +1
Lines 3643 3769 +126
Branches 541 559 +18
==========================================
+ Hits 2997 3094 +97
- Misses 499 518 +19
- Partials 147 157 +10
Continue to review full report at Codecov.
|
|
@lukebakken @gmr fine with you to merge? |
lukebakken
left a comment
lukebakken
left a comment
There was a problem hiding this comment.
Thanks, I have requested some changes.
.travis.yml
Outdated
| python: | ||
| - 2.6 | ||
| - 2.7 | ||
| - 3.3 |
| import json | ||
| import random | ||
|
|
||
| print(('pika version: %s') % pika.__version__) |
There was a problem hiding this comment.
Could these changes be part of a separate PR? They aren't directly related to dropping 2.6 and 3.3 support, right?
| `Basic.Cancel` | ||
| """ | ||
|
|
||
| __slots__ = ('method_frame') |
There was a problem hiding this comment.
See my comment about making these changes in a separate PR
| def genSingleEncode(prefix, cValue, unresolved_domain): | ||
| type = spec.resolveDomain(unresolved_domain) | ||
| if type == 'shortstr': | ||
| print(prefix + \ |
There was a problem hiding this comment.
Please use a separate PR for formatting changes.
|
There's a lot of work in this PR that I'd say misattributes the changes to removal of 2.6 support. Code formatting and style changes aren't the same as removing 2.6. I don't disagree with the code formatting changes, but I'd rather separate concerns TBH. |
|
That being said I'm a big +1 for dropping 2.6 support as long as we're very clear in versioning that it is a breaking change for anyone who's stuck in Python pre 2013. (2.6 EOL was 2013). |
|
Some of the changes are only possible after dropping 2.6 (formatters/set/dict), but sure, I can move all those to another PR! |
|
This PR updated to only include dropping the EOL versions. Will create another for the others. The coverage build job fails because: This is unrelated, and should be disabled from PRs and forks. |
Drop support for EOL Python 2.6 and 3.3 (cherry picked from commit b8325ec)
4 participants
#932 (comment) says:
Here's the pip installs for pika from PyPI for last month:
Source:
pypinfo --start-date -60 --end-date -30 --percent --pip --markdown pika pyversionPython 3.3 is also EOL and even less used, so let's drop that too.
It also does some minor code cleanup.