Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #924 +/- ##
=======================================
Coverage 82.12% 82.12%
=======================================
Files 21 21
Lines 3776 3776
Branches 560 560
=======================================
Hits 3101 3101
Misses 517 517
Partials 158 158
Continue to review full report at Codecov.
|
Contributor
|
How about also testing on
|
Member
Author
|
@hugovk - we would be happy to review a pull request with that change. |
Merged
Contributor
|
@lukebakken Sure, there you go! #934 |
michaelklishin
approved these changes
Jan 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorporates #923 with one change.
See #923
Fixes #921