You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 34f0543
Browse filesBrowse the repository at this point in the historyBrowse files
feat(web): game-harness UI renders only for game projects
Owner request (2026-08-08, two screenshots): a non-game project showed a
"No engine" chip in the chat header, and a t3code-fork thread's composer
displayed the Mafia Game Unity editor's "Directional Light" selection chip.
Core design -- the three-state engine signal (resolveEngineChipState):
"unknown" (project entity not loaded, or engineType absent on an older
server) / "none" (detection ran, no marker matched) / a concrete engine.
Every new gate keys off this, never a collapsed `?? null` -- the collapse
would have unmounted the composer's presence socket on every project
switch (re-minted DPoP tickets + a "connecting..." flash) and blanked all
engine UI on older backends.
- EngineToolbar renders NOTHING for a null engine, as its own contract
(single engine source: the resolvedEngineType prop is deleted, the view
is the one input; the old "still renders 'No engine'" test flipped
red-first with the fixture disagreement corrected).
- The composer chip row is now game-gated AND project-scoped through one
pure seam (resolveEditorPresenceChipsView): hidden for "none", chips
filtered by workspaceRoot via the same selectEditorPresenceChipsForProject
the send path uses. The container publishes the RENDERED list, so
see-what-you-send is structural; the send path keeps its own identical
filter as defense in depth.
- Ruling supersession recorded in place (store.ts, EngineToolbar.logic.ts,
EditorPresenceChips.tsx, unity-header-cleanup.md,
plan-engine-header-redesign.md): task pingdotgg#71's "row shows every editor by
owner ruling" display half is overturned by the 2026-08-08 report; both
rulings carried with dates.
Process: 4-lane research workflow -> spec -> fresh Opus critique (14
findings incl. 1 blocker, all incorporated; rev 1's last-good retention
DROPPED as masking a real 60s+ server state, replaced by the three-state
signal) -> Sonnet implementation -> orchestrator diff review.
Verification: typecheck exit 0 all packages; web 2410/2410 (10 new tests:
4 resolveEngineChipState branches, 6+1 chip-view gate/scoping, toolbar
null-case flip red-proven by old-file restore, "none"-gate red-proven by
line deletion); server 2197 green (untouched, sanity); /usr/bin/grep
"No engine" in apps/*/src: zero. E2E pass on the packaged build still OPEN
(tracked in task pingdotgg#135): t3code-fork bare header/composer + Mafia Game
unchanged + the cross-project screenshot scenario re-run.
Spec: docs/specs/no-engine-ui-for-non-game-projects.md (rev 2)
Co-Authored-By: Claude Fable 5 <[email protected]>
0 commit comments